Skip to contentSkip to conversation

backlight: document sysfs interfaces

PATCH Superseded Aishwarya Pant 4 participants 16 messages Jan 26, 2018 – Feb 5, 2018

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

cover backlight: document sysfs interfaces

Patchset contains documentation of the sysfs interfaces for the following five backlight drivers-
1) lp8788
2) lp855x
3) lm3639
4) adp5520
5) adp8860

It was compiled from data sheets, reading code and git history logs.

Aishwarya Pant (5):
backlight: lp8788: document sysfs attributes
backlight: lp855: document sysfs attributes
backlight: lm3639: document sysfs attributes
backlight: adp5520: document sysfs attributes
backlight: adp8860: document sysfs attributes

 .../ABI/testing/sysfs-class-backlight-adp5520      | 31 +++++++++++++
 .../ABI/testing/sysfs-class-backlight-adp8860      | 54 ++++++++++++++++++++++
 .../ABI/testing/sysfs-class-backlight-lm3639       | 13 ++++++
 .../ABI/testing/sysfs-class-backlight-lp855x       | 19 ++++++++
 .../ABI/testing/sysfs-class-backlight-lp8788       | 10 ++++
 5 files changed, 127 insertions(+)
 create mode 100644 Documentation/ABI/testing/sysfs-class-backlight-adp5520
 create mode 100644 Documentation/ABI/testing/sysfs-class-backlight-adp8860
 create mode 100644 Documentation/ABI/testing/sysfs-class-backlight-lm3639
 create mode 100644 Documentation/ABI/testing/sysfs-class-backlight-lp855x
 create mode 100644 Documentation/ABI/testing/sysfs-class-backlight-lp8788
Signature · 1 line
2.16.1
#1 lore raw

PATCH 1/5 backlight: lp8788: document sysfs attributes

Add documentation for sysfs interfaces of lp8788 backlight driver by looking through the code and the git commit history.

---
 Documentation/ABI/testing/sysfs-class-backlight-lp8788 | 10 ++++++++++
 1 file changed, 10 insertions(+)
 create mode 100644 Documentation/ABI/testing/sysfs-class-backlight-lp8788
Documentation/ABI/testing/sysfs-class-backlight-lp8788 new file +10 -0
new file mode 100644
index 000000000000..c0e565c8d63d
@@ -0,0 +1,10 @@
+sysfs interface for Texas Instruments lp8788 mfd backlight driver
+-----------------------------------------------------------------
+
+What:		/sys/class/backlight/<backlight>/bl_ctl_mode
+Date:		Feb, 2013
+KernelVersion:	v3.10
+Contact:	Milo Kim <[email protected]>
+Description:
+		(RO) Displays whether the brightness is controlled by the PWM
+		input("PWM based") or the I2C register("Register based").
Signature · 1 line
2.16.1
#2 lore raw

Re: [PATCH 1/5] backlight: lp8788: document sysfs attributes

Quoted 15 lines · Aishwarya Pant

Add documentation for sysfs interfaces of lp8788 backlight driver by looking through the code and the git commit history.

---
 Documentation/ABI/testing/sysfs-class-backlight-lp8788 | 10 ++++++++++
 1 file changed, 10 insertions(+)
 create mode 100644 Documentation/ABI/testing/sysfs-class-backlight-lp8788
Documentation/ABI/testing/sysfs-class-backlight-lp8788 new file +0 -0
new file mode 100644
index 000000000000..c0e565c8d63d

Documentation/ABI/testing/sysfs-class-backlight-lp8788 line 10

Quoted 10 lines
Documentation/ABI/testing/sysfs-class-backlight-lp8788 new file +10 -0
@@ -0,0 +1,10 @@
+sysfs interface for Texas Instruments lp8788 mfd backlight driver
+-----------------------------------------------------------------
+
+What:		/sys/class/backlight/<backlight>/bl_ctl_mode
+Date:		Feb, 2013
+KernelVersion:	v3.10
+Contact:	Milo Kim <[email protected]>
+Description:
+		(RO) Displays whether the brightness is controlled by the PWM
+		input("PWM based") or the I2C register("Register based").

I rather dislike drivers with this type of "bonus" sysfs controls. I'm struggling to come up with any reason why the userspace would want to read this control (and I think bl_ctl_mode gets the fewest hits after searching with google hits of any search I've tried) . It looks to me like this is debug information that should never have gone into sysfs at all.

So I think this is either something that should go directly into ABI/obsolete (with a fairly short expiry time) or perhaps simply remove the property entirely.

Daniel.

#3 lore raw

Re: [PATCH 1/5] backlight: lp8788: document sysfs attributes

Quoted 25 lines · Daniel Thompson
Quoted 24 lines · Aishwarya Pant

Add documentation for sysfs interfaces of lp8788 backlight driver by looking through the code and the git commit history.

---
 Documentation/ABI/testing/sysfs-class-backlight-lp8788 | 10 ++++++++++
 1 file changed, 10 insertions(+)
 create mode 100644 Documentation/ABI/testing/sysfs-class-backlight-lp8788
Documentation/ABI/testing/sysfs-class-backlight-lp8788 new file +9 -0
new file mode 100644
index 000000000000..c0e565c8d63d
@@ -0,0 +1,10 @@
+sysfs interface for Texas Instruments lp8788 mfd backlight driver
+-----------------------------------------------------------------
+
+What:		/sys/class/backlight/<backlight>/bl_ctl_mode
+Date:		Feb, 2013
+KernelVersion:	v3.10
+Contact:	Milo Kim <[email protected]>
+Description:
+		(RO) Displays whether the brightness is controlled by the PWM
Quoted 8 lines

Documentation/ABI/testing/sysfs-class-backlight-lp8788 line 10

Quoted 1 line
Documentation/ABI/testing/sysfs-class-backlight-lp8788 new file +1 -0
+		input("PWM based") or the I2C register("Register based").

I rather dislike drivers with this type of "bonus" sysfs controls. I'm struggling to come up with any reason why the userspace would want to read this control (and I think bl_ctl_mode gets the fewest hits after searching with google hits of any search I've tried) . It looks to me like this is debug information that should never have gone into sysfs at all.

Agreed. I think the same holds for the other extra sysfs attributes. At worst, having these prevents the backlight class from adding the names later on, which is just backwards.

BR,
Jani.

Quoted 11 lines

So I think this is either something that should go directly into ABI/obsolete (with a fairly short expiry time) or perhaps simply remove the property entirely.

Daniel.
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Signature · 1 line
Jani Nikula, Intel Open Source Technology Center
#4 lore raw

Re: [PATCH 1/5] backlight: lp8788: document sysfs attributes

Quoted 35 lines · Jani Nikula
Quoted 25 lines · Daniel Thompson
Quoted 24 lines · Aishwarya Pant

Add documentation for sysfs interfaces of lp8788 backlight driver by looking through the code and the git commit history.

---
 Documentation/ABI/testing/sysfs-class-backlight-lp8788 | 10 ++++++++++
 1 file changed, 10 insertions(+)
 create mode 100644 Documentation/ABI/testing/sysfs-class-backlight-lp8788
Documentation/ABI/testing/sysfs-class-backlight-lp8788 new file +9 -0
new file mode 100644
index 000000000000..c0e565c8d63d
@@ -0,0 +1,10 @@
+sysfs interface for Texas Instruments lp8788 mfd backlight driver
+-----------------------------------------------------------------
+
+What:		/sys/class/backlight/<backlight>/bl_ctl_mode
+Date:		Feb, 2013
+KernelVersion:	v3.10
+Contact:	Milo Kim <[email protected]>
+Description:
+		(RO) Displays whether the brightness is controlled by the PWM
Quoted 8 lines

Documentation/ABI/testing/sysfs-class-backlight-lp8788 line 10

Quoted 1 line
Documentation/ABI/testing/sysfs-class-backlight-lp8788 new file +1 -0
+		input("PWM based") or the I2C register("Register based").

I rather dislike drivers with this type of "bonus" sysfs controls. I'm struggling to come up with any reason why the userspace would want to read this control (and I think bl_ctl_mode gets the fewest hits after searching with google hits of any search I've tried) . It looks to me like this is debug information that should never have gone into sysfs at all.

Quoted 3 lines

Agreed. I think the same holds for the other extra sysfs attributes. At worst, having these prevents the backlight class from adding the names later on, which is just backwards.

The problem is that they do exist...

For controls which appear to be misplaced debug attributes I think I am happy to nuke the values entirely. It is extremely improbable that any userspace will notice.

Unfortunately some of the controls look like they could be poked by an custom userspace so I'm quite so confident about nuking these ones...and if we don't nuke we should document (so thanks Aishwarya!).

Daniel.

#5 lore raw

Re: [PATCH 1/5] backlight: lp8788: document sysfs attributes

Quoted 42 lines · Daniel Thompson
Quoted 35 lines · Jani Nikula
Quoted 25 lines · Daniel Thompson
Quoted 24 lines · Aishwarya Pant

Add documentation for sysfs interfaces of lp8788 backlight driver by looking through the code and the git commit history.

---
 Documentation/ABI/testing/sysfs-class-backlight-lp8788 | 10 ++++++++++
 1 file changed, 10 insertions(+)
 create mode 100644 Documentation/ABI/testing/sysfs-class-backlight-lp8788
Documentation/ABI/testing/sysfs-class-backlight-lp8788 new file +9 -0
new file mode 100644
index 000000000000..c0e565c8d63d
@@ -0,0 +1,10 @@
+sysfs interface for Texas Instruments lp8788 mfd backlight driver
+-----------------------------------------------------------------
+
+What:		/sys/class/backlight/<backlight>/bl_ctl_mode
+Date:		Feb, 2013
+KernelVersion:	v3.10
+Contact:	Milo Kim <[email protected]>
+Description:
+		(RO) Displays whether the brightness is controlled by the PWM
Quoted 8 lines

Documentation/ABI/testing/sysfs-class-backlight-lp8788 line 10

Quoted 1 line
Documentation/ABI/testing/sysfs-class-backlight-lp8788 new file +1 -0
+		input("PWM based") or the I2C register("Register based").

I rather dislike drivers with this type of "bonus" sysfs controls. I'm struggling to come up with any reason why the userspace would want to read this control (and I think bl_ctl_mode gets the fewest hits after searching with google hits of any search I've tried) . It looks to me like this is debug information that should never have gone into sysfs at all.

Quoted 3 lines

Agreed. I think the same holds for the other extra sysfs attributes. At worst, having these prevents the backlight class from adding the names later on, which is just backwards.

The problem is that they do exist...

Quoted 8 lines

For controls which appear to be misplaced debug attributes I think I am happy to nuke the values entirely. It is extremely improbable that any userspace will notice.

Unfortunately some of the controls look like they could be poked by an custom userspace so I'm quite so confident about nuking these ones...and if we don't nuke we should document (so thanks Aishwarya!).

Hi

Thanks for reviewing. Should I take it to assume that we would like to keep the debug-like attributes in documentation for now?

Aishwarya

Quoted 2 lines

Daniel.

#6 lore raw

Re: [PATCH 1/5] backlight: lp8788: document sysfs attributes

Quoted 52 lines · Aishwarya Pant
Quoted 42 lines · Daniel Thompson
Quoted 35 lines · Jani Nikula
Quoted 25 lines · Daniel Thompson
Quoted 24 lines · Aishwarya Pant

Add documentation for sysfs interfaces of lp8788 backlight driver by looking through the code and the git commit history.

---
 Documentation/ABI/testing/sysfs-class-backlight-lp8788 | 10 ++++++++++
 1 file changed, 10 insertions(+)
 create mode 100644 Documentation/ABI/testing/sysfs-class-backlight-lp8788
Documentation/ABI/testing/sysfs-class-backlight-lp8788 new file +9 -0
new file mode 100644
index 000000000000..c0e565c8d63d
@@ -0,0 +1,10 @@
+sysfs interface for Texas Instruments lp8788 mfd backlight driver
+-----------------------------------------------------------------
+
+What:		/sys/class/backlight/<backlight>/bl_ctl_mode
+Date:		Feb, 2013
+KernelVersion:	v3.10
+Contact:	Milo Kim <[email protected]>
+Description:
+		(RO) Displays whether the brightness is controlled by the PWM
Quoted 8 lines

Documentation/ABI/testing/sysfs-class-backlight-lp8788 line 10

Quoted 1 line
Documentation/ABI/testing/sysfs-class-backlight-lp8788 new file +1 -0
+		input("PWM based") or the I2C register("Register based").

I rather dislike drivers with this type of "bonus" sysfs controls. I'm struggling to come up with any reason why the userspace would want to read this control (and I think bl_ctl_mode gets the fewest hits after searching with google hits of any search I've tried) . It looks to me like this is debug information that should never have gone into sysfs at all.

Quoted 3 lines

Agreed. I think the same holds for the other extra sysfs attributes. At worst, having these prevents the backlight class from adding the names later on, which is just backwards.

The problem is that they do exist...

Quoted 8 lines

For controls which appear to be misplaced debug attributes I think I am happy to nuke the values entirely. It is extremely improbable that any userspace will notice.

Unfortunately some of the controls look like they could be poked by an custom userspace so I'm quite so confident about nuking these ones...and if we don't nuke we should document (so thanks Aishwarya!).

Quoted 4 lines

Hi

Thanks for reviewing. Should I take it to assume that we would like to keep the debug-like attributes in documentation for now?

The opposite I think!

Can you drop patch 1/2 from this series, tidy the maintainer values, etc and resubmit?

If you want to propose patches to remove the debug attributes from the TI drivers that's up to you (perhaps adding a dev_dbg() containing equivalent information). If you want to you are welcome to add to these:

Daniel.

#7 lore raw

PATCH 2/5 backlight: lp855x: document sysfs attributes

In reply to Aishwarya Pant

Add documentation for sysfs interface of Texas Instruments lp855x backlight driver by reading code and looking through git commit logs.

---
 .../ABI/testing/sysfs-class-backlight-lp855x          | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 Documentation/ABI/testing/sysfs-class-backlight-lp855x
Documentation/ABI/testing/sysfs-class-backlight-lp855x new file +19 -0
new file mode 100644
index 000000000000..5b9d38958875
@@ -0,0 +1,19 @@
+sysfs interface for Texas Instruments lp855x backlight driver
+------------------------------------------------------------
+
+What:		/sys/class/backlight/<backlight>/chip_id
+Date:		Mar, 2012
+KernelVersion:	v3.10
+Contact:	Milo Kim <[email protected]>
+Description:
+		(RO) Displays the lp8755x chip id. Possible values are:
+		lp8550, lp8551, lp8552, lp8553, lp8555, lp8556 or lp8557.
+
+
+What:		/sys/class/backlight/<backlight>/bl_ctl_mode
+Date:		Mar, 2012
+KernelVersion:	v3.10
+Contact:	Linux kernel mailing list <[email protected]>
+Description:
+		(RO) Displays whether the brightness is controlled by the pwm
+		input("pwm based) or the i2c register("register based").
Signature · 1 line
2.16.1
#8 lore raw

Re: [PATCH 2/5] backlight: lp855x: document sysfs attributes

Quoted 24 lines · Aishwarya Pant

Add documentation for sysfs interface of Texas Instruments lp855x backlight driver by reading code and looking through git commit logs.

---
 .../ABI/testing/sysfs-class-backlight-lp855x          | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 Documentation/ABI/testing/sysfs-class-backlight-lp855x
Documentation/ABI/testing/sysfs-class-backlight-lp855x new file +9 -0
new file mode 100644
index 000000000000..5b9d38958875
@@ -0,0 +1,19 @@
+sysfs interface for Texas Instruments lp855x backlight driver
+------------------------------------------------------------
+
+What:		/sys/class/backlight/<backlight>/chip_id
+Date:		Mar, 2012
+KernelVersion:	v3.10
+Contact:	Milo Kim <[email protected]>
+Description:
+		(RO) Displays the lp8755x chip id. Possible values are:

Documentation/ABI/testing/sysfs-class-backlight-lp855x line 19

Quoted 10 lines
Documentation/ABI/testing/sysfs-class-backlight-lp855x new file +10 -0
+		lp8550, lp8551, lp8552, lp8553, lp8555, lp8556 or lp8557.
+
+
+What:		/sys/class/backlight/<backlight>/bl_ctl_mode
+Date:		Mar, 2012
+KernelVersion:	v3.10
+Contact:	Linux kernel mailing list <[email protected]>
+Description:
+		(RO) Displays whether the brightness is controlled by the pwm
+		input("pwm based) or the i2c register("register based").

Since like the first patch in the series, these look like they are for debugging. That thread is still active but whatever the outcome of that thread please assume it also applies to this patch.

Daniel.

#9 lore raw

Re: [PATCH 2/5] backlight: lp855x: document sysfs attributes

Quoted 31 lines · Daniel Thompson
Quoted 30 lines · Aishwarya Pant

Add documentation for sysfs interface of Texas Instruments lp855x backlight driver by reading code and looking through git commit logs.

---
 .../ABI/testing/sysfs-class-backlight-lp855x          | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 Documentation/ABI/testing/sysfs-class-backlight-lp855x
Documentation/ABI/testing/sysfs-class-backlight-lp855x new file +15 -0
new file mode 100644
index 000000000000..5b9d38958875
@@ -0,0 +1,19 @@
+sysfs interface for Texas Instruments lp855x backlight driver
+------------------------------------------------------------
+
+What:		/sys/class/backlight/<backlight>/chip_id
+Date:		Mar, 2012
+KernelVersion:	v3.10
+Contact:	Milo Kim <[email protected]>
+Description:
+		(RO) Displays the lp8755x chip id. Possible values are:
+		lp8550, lp8551, lp8552, lp8553, lp8555, lp8556 or lp8557.
+
+
+What:		/sys/class/backlight/<backlight>/bl_ctl_mode
+Date:		Mar, 2012
+KernelVersion:	v3.10
Quoted 8 lines

Documentation/ABI/testing/sysfs-class-backlight-lp855x line 19

Quoted 4 lines
Documentation/ABI/testing/sysfs-class-backlight-lp855x new file +4 -0
+Contact:	Linux kernel mailing list <[email protected]>
+Description:
+		(RO) Displays whether the brightness is controlled by the pwm
+		input("pwm based) or the i2c register("register based").

Since like the first patch in the series, these look like they are for debugging. That thread is still active but whatever the outcome of that thread please assume it also applies to this patch.

All right, I'll wait for conclusion on that thread before I re-send the patchset with the updates.

Aishwarya

Quoted 3 lines

Daniel.

#10 lore raw

PATCH 3/5 backlight: lm3639: document sysfs attributes

In reply to Aishwarya Pant

Add documentation for sysfs interfaces of Texas Instruments lm3639 backlight + flash led driver chip by looking through git commits and reading code.

---
 Documentation/ABI/testing/sysfs-class-backlight-lm3639 | 13 +++++++++++++
 1 file changed, 13 insertions(+)
 create mode 100644 Documentation/ABI/testing/sysfs-class-backlight-lm3639
Documentation/ABI/testing/sysfs-class-backlight-lm3639 new file +13 -0
new file mode 100644
index 000000000000..ec87dc8f4395
@@ -0,0 +1,13 @@
+sysfs interface for Texas Instruments lm3639 backlight + flash led driver chip
+------------------------------------------------------------------------------
+
+What:		/sys/class/backlight/<backlight>/bled_mode
+Date:		Oct, 2012
+KernelVersion:	v3.10
+Contact:	Lee Jones <[email protected]>,
+		Daniel Thompson <[email protected]>,
+		Jingoo Han <[email protected]>
+Description:
+		(WO) Write to the backlight mapping mode. The backlight current
+		can be mapped for either exponential (value "0") or linear
+		mapping modes (default).
Signature · 1 line
2.16.1
Acked-by on v1 3/5
#11 lore raw

Re: [PATCH 3/5] backlight: lm3639: document sysfs attributes

Quoted 16 lines · Aishwarya Pant

Add documentation for sysfs interfaces of Texas Instruments lm3639 backlight + flash led driver chip by looking through git commits and reading code.

---
 Documentation/ABI/testing/sysfs-class-backlight-lm3639 | 13 +++++++++++++
 1 file changed, 13 insertions(+)
 create mode 100644 Documentation/ABI/testing/sysfs-class-backlight-lm3639
Documentation/ABI/testing/sysfs-class-backlight-lm3639 new file +0 -0
new file mode 100644
index 000000000000..ec87dc8f4395

Documentation/ABI/testing/sysfs-class-backlight-lm3639 line 9

Quoted 9 lines
Documentation/ABI/testing/sysfs-class-backlight-lm3639 new file +9 -0
@@ -0,0 +1,13 @@
+sysfs interface for Texas Instruments lm3639 backlight + flash led driver chip
+------------------------------------------------------------------------------
+
+What:		/sys/class/backlight/<backlight>/bled_mode
+Date:		Oct, 2012
+KernelVersion:	v3.10
+Contact:	Lee Jones <[email protected]>,
+		Daniel Thompson <[email protected]>,
+		Jingoo Han <[email protected]>

We've recently added a ML to MAINTAINERS (see
https://patchwork.kernel.org/patch/10169327/ ). I think a better Contact might simply be:

Contact: [email protected]

Documentation/ABI/testing/sysfs-class-backlight-lm3639 line 13

Quoted 4 lines
Documentation/ABI/testing/sysfs-class-backlight-lm3639 new file +4 -0
+Description:
+		(WO) Write to the backlight mapping mode. The backlight current
+		can be mapped for either exponential (value "0") or linear
+		mapping modes (default).

The ambiguity of meaning w.r.t. linear or exponential is something of a thorn in the side of backlight... and so long as that ambiguity remains this control is something the userspace may want to poke (albeit only once during boot).

If you repost with an updated contact then please add my ack for this patch:

Daniel.

#12 lore raw

PATCH 4/5 backlight: adp5520: document sysfs attributes

In reply to Aishwarya Pant

Add documentation for sysfs interface of adp5520/adp5501 analog devices backlight driver by reading code and looking through git commit logs.

---
 .../ABI/testing/sysfs-class-backlight-adp5520      | 31 ++++++++++++++++++++++
 1 file changed, 31 insertions(+)
 create mode 100644 Documentation/ABI/testing/sysfs-class-backlight-adp5520
Documentation/ABI/testing/sysfs-class-backlight-adp5520 new file +31 -0
new file mode 100644
index 000000000000..34b6ebafa210
@@ -0,0 +1,31 @@
+sysfs interface for analog devices adp5520(01) backlight driver
+---------------------------------------------------------------
+
+The backlight brightness control operates at three different levels for the
+adp5520 and adp5501 devices: daylight (level 1), office (level 2) and dark
+(level 3). By default the brightness operates at the daylight brightness level.
+
+What:		/sys/class/backlight/<backlight>/daylight_max
+What:		/sys/class/backlight/<backlight>/office_max
+What:		/sys/class/backlight/<backlight>/dark_max
+Date:		Sep, 2009
+KernelVersion:	v2.6.32
+Contact:	Michael Hennerich <[email protected]>
+Description:
+		(RW) Maximum current setting for the backlight when brightness
+		is at one of the three levels (daylight, office or dark). This
+		is an input code between 0 and 127, which is transformed to a
+		value between 0 mA and 30 mA using linear or non-linear
+		algorithms.
+
+What:		/sys/class/backlight/<backlight>/daylight_dim
+What:		/sys/class/backlight/<backlight>/office_dim
+What:		/sys/class/backlight/<backlight>/dark_dim
+Date:		Sep, 2009
+KernelVersion:	v2.6.32
+Contact:	Michael Hennerich <[email protected]>
+Description:
+		(RW) Dim current setting for the backlight when brightness is at
+		one of the three levels (daylight, office or dark). This is an
+		input code between 0 and 127, which is transformed to a value
+		between 0 mA and 30 mA using linear or non-linear algorithms.
Signature · 1 line
2.16.1
Acked-by on v1 4/5
#13 lore raw

Re: [PATCH 4/5] backlight: adp5520: document sysfs attributes

Quoted 4 lines · Aishwarya Pant

Add documentation for sysfs interface of adp5520/adp5501 analog devices backlight driver by reading code and looking through git commit logs.

Quoted 43 lines
---
  .../ABI/testing/sysfs-class-backlight-adp5520      | 31 ++++++++++++++++++++++
  1 file changed, 31 insertions(+)

create mode 100644 Documentation/ABI/testing/sysfs-class-backlight-adp5520

Documentation/ABI/testing/sysfs-class-backlight-adp5520 new file +31 -0
new file mode 100644
index 000000000000..34b6ebafa210
@@ -0,0 +1,31 @@
+sysfs interface for analog devices adp5520(01) backlight driver
+---------------------------------------------------------------
+
+The backlight brightness control operates at three different levels for the
+adp5520 and adp5501 devices: daylight (level 1), office (level 2) and dark
+(level 3). By default the brightness operates at the daylight brightness level.
+
+What:		/sys/class/backlight/<backlight>/daylight_max
+What:		/sys/class/backlight/<backlight>/office_max
+What:		/sys/class/backlight/<backlight>/dark_max
+Date:		Sep, 2009
+KernelVersion:	v2.6.32
+Contact:	Michael Hennerich <[email protected]>
+Description:
+		(RW) Maximum current setting for the backlight when brightness
+		is at one of the three levels (daylight, office or dark). This
+		is an input code between 0 and 127, which is transformed to a
+		value between 0 mA and 30 mA using linear or non-linear
+		algorithms.
+
+What:		/sys/class/backlight/<backlight>/daylight_dim
+What:		/sys/class/backlight/<backlight>/office_dim
+What:		/sys/class/backlight/<backlight>/dark_dim
+Date:		Sep, 2009
+KernelVersion:	v2.6.32
+Contact:	Michael Hennerich <[email protected]>
+Description:
+		(RW) Dim current setting for the backlight when brightness is at
+		one of the three levels (daylight, office or dark). This is an
+		input code between 0 and 127, which is transformed to a value
+		between 0 mA and 30 mA using linear or non-linear algorithms.
#14 lore raw

PATCH 5/5 backlight: adp8860: document sysfs attributes

In reply to Aishwarya Pant

Add documentation for sysfs interface of adp8860 series backlight devices by reading through code and git commits.

---
 .../ABI/testing/sysfs-class-backlight-adp8860      | 54 ++++++++++++++++++++++
 1 file changed, 54 insertions(+)
 create mode 100644 Documentation/ABI/testing/sysfs-class-backlight-adp8860
Documentation/ABI/testing/sysfs-class-backlight-adp8860 new file +54 -0
new file mode 100644
index 000000000000..54d61c788b1b
@@ -0,0 +1,54 @@
+sysfs interface for analog devices adp8860 backlight driver
+-----------------------------------------------------------
+
+The backlight brightness control operates at three different levels for the
+adp8860, adp8861 and adp8863 devices: daylight (level 1), office (level 2) and
+dark (level 3). By default the brightness operates at the daylight brightness
+level.
+
+What:		/sys/class/backlight/<backlight>/ambient_light_level
+Date:		Apr, 2010
+KernelVersion:	v2.6.35
+Contact:	Michael Hennerich <[email protected]>
+Description:
+		(RO) 13-bit conversion value for the first light sensor—high
+		byte (Bit 12 to Bit 8). The value is updated every 80 ms (when
+		the light sensor is enabled).
+
+
+What:		/sys/class/backlight/<backlight>/ambient_light_zone
+Date:		Apr, 2010
+KernelVersion:	v2.6.35
+Contact:	Michael Hennerich <[email protected]>
+Description:
+		(RW) Read or write the specific level at which the backlight
+		operates. Value "0" enables automatic ambient light sensing, and
+		values "1", "2" or "3" set the control to daylight, office or
+		dark respectively.
+
+
+What:		/sys/class/backlight/<backlight>/l1_daylight_max
+What:		/sys/class/backlight/<backlight>/l2_office_max
+What:		/sys/class/backlight/<backlight>/l3_dark_max
+Date:		Apr, 2010
+KernelVersion:	v2.6.35
+Contact:	Michael Hennerich <[email protected]>
+Description:
+		(RW) Maximum current setting for the backlight when brightness
+		is at one of the three levels (daylight, office or dark). This
+		is an input code between 0 and 127, which is transformed to a
+		value between 0 mA and 30 mA using linear or non-linear
+		algorithms.
+
+
+What:		/sys/class/backlight/<backlight>/l1_daylight_dim
+What:		/sys/class/backlight/<backlight>/l2_office_dim
+What:		/sys/class/backlight/<backlight>/l3_dark_dim
+Date:		Apr, 2010
+KernelVersion:	v2.6.35
+Contact:	Michael Hennerich <[email protected]>
+Description:
+		(RW) Dim current setting for the backlight when brightness is at
+		one of the three levels (daylight, office or dark). This is an
+		input code between 0 and 127, which is transformed to a value
+		between 0 mA and 30 mA using linear or non-linear algorithms.
Signature · 1 line
2.16.1
Acked-by on v1 5/5
#15 lore raw

Re: [PATCH 5/5] backlight: adp8860: document sysfs attributes

Quoted 4 lines · Aishwarya Pant

Add documentation for sysfs interface of adp8860 series backlight devices by reading through code and git commits.

Quoted 66 lines
---
  .../ABI/testing/sysfs-class-backlight-adp8860      | 54 ++++++++++++++++++++++
  1 file changed, 54 insertions(+)

create mode 100644 Documentation/ABI/testing/sysfs-class-backlight-adp8860

Documentation/ABI/testing/sysfs-class-backlight-adp8860 new file +54 -0
new file mode 100644
index 000000000000..54d61c788b1b
@@ -0,0 +1,54 @@
+sysfs interface for analog devices adp8860 backlight driver
+-----------------------------------------------------------
+
+The backlight brightness control operates at three different levels for the
+adp8860, adp8861 and adp8863 devices: daylight (level 1), office (level 2) and
+dark (level 3). By default the brightness operates at the daylight brightness
+level.
+
+What:		/sys/class/backlight/<backlight>/ambient_light_level
+Date:		Apr, 2010
+KernelVersion:	v2.6.35
+Contact:	Michael Hennerich <[email protected]>
+Description:
+		(RO) 13-bit conversion value for the first light sensor—high
+		byte (Bit 12 to Bit 8). The value is updated every 80 ms (when
+		the light sensor is enabled).
+
+
+What:		/sys/class/backlight/<backlight>/ambient_light_zone
+Date:		Apr, 2010
+KernelVersion:	v2.6.35
+Contact:	Michael Hennerich <[email protected]>
+Description:
+		(RW) Read or write the specific level at which the backlight
+		operates. Value "0" enables automatic ambient light sensing, and
+		values "1", "2" or "3" set the control to daylight, office or
+		dark respectively.
+
+
+What:		/sys/class/backlight/<backlight>/l1_daylight_max
+What:		/sys/class/backlight/<backlight>/l2_office_max
+What:		/sys/class/backlight/<backlight>/l3_dark_max
+Date:		Apr, 2010
+KernelVersion:	v2.6.35
+Contact:	Michael Hennerich <[email protected]>
+Description:
+		(RW) Maximum current setting for the backlight when brightness
+		is at one of the three levels (daylight, office or dark). This
+		is an input code between 0 and 127, which is transformed to a
+		value between 0 mA and 30 mA using linear or non-linear
+		algorithms.
+
+
+What:		/sys/class/backlight/<backlight>/l1_daylight_dim
+What:		/sys/class/backlight/<backlight>/l2_office_dim
+What:		/sys/class/backlight/<backlight>/l3_dark_dim
+Date:		Apr, 2010
+KernelVersion:	v2.6.35
+Contact:	Michael Hennerich <[email protected]>
+Description:
+		(RW) Dim current setting for the backlight when brightness is at
+		one of the three levels (daylight, office or dark). This is an
+		input code between 0 and 127, which is transformed to a value
+		between 0 mA and 30 mA using linear or non-linear algorithms.