Skip to contentSkip to conversation

flite: disable ALSA support

PATCH New Vicente Olivert Riera 2 participants 2 messages Dec 4, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 flite: disable ALSA support

Upstream says that ALSA support in flite is broken for earlier versions:

"Seems the alsa code I have breaks on earlier versions I'm not sure what the threshold version is, but made this depend on the one I know -- you can still specific --with-audio=alsa"

So let's disable it. It will prevent failures like this one:

/br/output/host/usr/bin/mipsel-linux-gcc -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Os -Wall -o ../bin/find_sts find_sts_main.o -L../build/mipsel-linux-uclibc/lib -lflite -lm ../build/mipsel-linux-uclibc/lib/libflite.a(audio.o): In function `audio_open':
audio.c:(.text+0x1c): undefined reference to `audio_open_oss'

---
 package/flite/flite.mk | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)
package/flite/flite.mk +1 -6
index 611e334..c5d7828 100644
@@ -36,11 +36,6 @@ FLITE_DEPENDENCIES = host-pkgconf
 # shared libraries.
 FLITE_MAKE = $(MAKE1)
 
-ifeq ($(BR2_PACKAGE_ALSA_LIB),y)
-FLITE_DEPENDENCIES += alsa-lib
-FLITE_CONF_OPTS += --with-audio=alsa
-else
-FLITE_CONF_OPTS += --with-audio=oss
-endif
+FLITE_CONF_OPTS = --with-audio=oss
 
 $(eval $(autotools-package))
Signature · 1 line
2.4.10
#1 lore raw

PATCH 1/1 flite: disable ALSA support

Quoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Vicente" == Vicente Olivert Riera <[email protected]> writes:

Upstream says that ALSA support in flite is broken for earlier versions:
"Seems the alsa code I have breaks on earlier versions I'm not sure what the threshold version is, but made this depend on the one I know -- you can still specific --with-audio=alsa"

But we have the newest alsa-lib release in Buildroot, right?

Quoted 9 lines

So let's disable it. It will prevent failures like this one:

/br/output/host/usr/bin/mipsel-linux-gcc -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Os -Wall -o ../bin/find_sts find_sts_main.o -L../build/mipsel-linux-uclibc/lib -lflite -lm ../build/mipsel-linux-uclibc/lib/libflite.a(audio.o): In function `audio_open':
audio.c:(.text+0x1c): undefined reference to `audio_open_oss'

This sounds more like it is building without alsa support. From flite-1.4-release/src/audio/native_audio.h:

#ifdef CST_AUDIO_LINUX

#define AUDIO_OPEN_NATIVE audio_open_oss
..

#endif

#ifdef CST_AUDIO_ALSA

#define AUDIO_OPEN_NATIVE audio_open_alsa
..

#endif

Could you check config.log why it fails?

Signature · 1 line
Bye, Peter Korsgaard