Skip to contentSkip to conversation

uclibc: fix coreutils cut bug, enable needed config symbols

PATCH New Waldemar Brodkorb 3 participants 7 messages Sep 5, 2015 – Sep 6, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 2/3 uclibc: fix coreutils cut bug, enable needed config symbols

Fixes https://bugs.buildroot.org/show_bug.cgi?id=4099

---
 package/uclibc/uClibc-ng.config |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/uclibc/uClibc-ng.config +2 -2
index 6523585..c17603d 100644
@@ -24,8 +24,8 @@ UCLIBC_HAS_LIBNSL_STUB=y
 UCLIBC_HAS_CTYPE_CHECKED=y
 UCLIBC_HAS_HEXADECIMAL_FLOATS=y
 UCLIBC_HAS_GLIBC_CUSTOM_PRINTF=y
-# UCLIBC_HAS_STDIO_GETC_MACRO is not set
-# UCLIBC_HAS_STDIO_PUTC_MACRO is not set
+UCLIBC_HAS_STDIO_GETC_MACRO=y
+UCLIBC_HAS_STDIO_PUTC_MACRO=y
 UCLIBC_HAS_FOPEN_EXCLUSIVE_MODE=y
 UCLIBC_HAS_GLIBC_CUSTOM_STREAMS=y
 UCLIBC_HAS_PRINTF_M_SPEC=y
Signature · 1 line
1.7.10.4
#2 lore raw

PATCH 2/3 uclibc: fix coreutils cut bug, enable needed config symbols

Peter, Waldemar,

Quoted 7 lines · Peter Korsgaard
Quoted 4 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Waldemar" == Waldemar Brodkorb <[email protected]> writes:

Fixes https://bugs.buildroot.org/show_bug.cgi?id=4099

I slightly tweaked the description to make it clear this is for uClibc-ng and committed, thanks.

This is not only for uClibc-ng, it should also be done in uClibc-0.9.33.config and uClibc-snapshot.config, as far as I understand.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#3 lore raw

PATCH 2/3 uclibc: fix coreutils cut bug, enable needed config symbols

Hi Thomas,
Thomas Petazzoni wrote,

Quoted 5 lines

Peter, Waldemar,

Quoted 2 lines · Peter Korsgaard
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Waldemar" == Waldemar Brodkorb <[email protected]> writes:

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

Fixes https://bugs.buildroot.org/show_bug.cgi?id=4099

I slightly tweaked the description to make it clear this is for uClibc-ng and committed, thanks.

This is not only for uClibc-ng, it should also be done in uClibc-0.9.33.config and uClibc-snapshot.config, as far as I understand.

Yes, would be required.
What about your idea to deprecate uClibc-0.9.33 and snapshot?

best regards
Waldemar

#4 lore raw

PATCH 2/3 uclibc: fix coreutils cut bug, enable needed config symbols

Waldemar,

Quoted 2 lines · Waldemar Brodkorb

Yes, would be required.
What about your idea to deprecate uClibc-0.9.33 and snapshot?

It's an unrelated decision. For now, they are still supported, so the fix should also be made for them.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#5 lore raw

PATCH 2/3 uclibc: fix coreutils cut bug, enable needed config symbols

In reply to Thomas Petazzoni
Quoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Peter, Waldemar,

Quoted 2 lines · Peter Korsgaard
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Waldemar" == Waldemar Brodkorb <[email protected]> writes:

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

Fixes https://bugs.buildroot.org/show_bug.cgi?id=4099

I slightly tweaked the description to make it clear this is for uClibc-ng and committed, thanks.

This is not only for uClibc-ng, it should also be done in uClibc-0.9.33.config and uClibc-snapshot.config, as far as I understand.

Possibly, but that was not what the patch did. If this error and workaround also applies to 0.9.33 / snapshot, then lets please also adjust it there. Waldemar?

Signature · 2 lines
Venlig hilsen,
Peter Korsgaard 
#6 lore raw

PATCH 2/3 uclibc: fix coreutils cut bug, enable needed config symbols

Peter,

Quoted 7 lines · Peter Korsgaard
Quoted 5 lines
Quoted 2 lines

I slightly tweaked the description to make it clear this is for uClibc-ng and committed, thanks.

This is not only for uClibc-ng, it should also be done in uClibc-0.9.33.config and uClibc-snapshot.config, as far as I understand.

Possibly, but that was not what the patch did.

Well, that's precisely what I'm saying: you changed the commit log to "make it clear it's for uclibc-ng", and I'm saying that the issue is not uClibc-ng specific. It also applies to other uClibc versions.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com