Skip to contentSkip to conversation

Checking on interest in some patches...

DISCUSSION Ben Greear 2 participants 3 messages Dec 31, 2014 – Jan 13, 2015 Qualcomm Atheros ATH10K wireless driver

lore
Share & tools
lore

Ben Greear

author
#0 lore raw

Previously, I was at a dead end trying to get support for CT firmware features, expanded crash dump features, and other things accepted upstream.

I am working on porting my changes to the 3.19 kernel, and was curious if there is any change of opinion on possibly accepting at least some CT firmware support or the crash dump features. If so, I'll clean up and re-post once I have tested them.

Thanks,
Ben

Signature · 8 lines
Ben Greear <[email protected]>
Candela Technologies Inc  http://www.candelatech.com


_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
#1 lore raw
Quoted 7 lines · Ben Greear

Previously, I was at a dead end trying to get support for CT firmware features, expanded crash dump features, and other things accepted upstream.

I am working on porting my changes to the 3.19 kernel, and was curious if there is any change of opinion on possibly accepting at least some CT firmware support or the crash dump features. If so, I'll clean up and re-post once I have tested them.

We have now four different firmware branches to support and I fear even more to come. Adding yet another branch is quite daunting from maintenance point of view.

Crash dump support is already upstream, but what's missing is porting it to use Johannes' device coredump (commit 833c95456a70) and RAM dump part. (And I guess we also want some sort register dump?)

Last year I implemented the RAM dump part, but only did some quick verification and that's why I haven't submitted it yet. I think I need to submit it as RFC instead of bitrotting on my hard drive.

Signature · 6 lines
Kalle Valo

_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
author
#2 lore raw
Quoted 5 lines · Kalle Valo
Quoted 3 lines · Ben Greear

Previously, I was at a dead end trying to get support for CT firmware features, expanded crash dump features, and other things accepted upstream.

Quoted 8 lines
Quoted 4 lines

I am working on porting my changes to the 3.19 kernel, and was curious if there is any change of opinion on possibly accepting at least some CT firmware support or the crash dump features. If so, I'll clean up and re-post once I have tested them.

We have now four different firmware branches to support and I fear even more to come. Adding yet another branch is quite daunting from maintenance point of view.

No worse than the current code...and mine isn't really a new branch, just a few small deviations from the existing 10.1 firmware. Even if you don't want some of the larger changes, it would be nice to get in some of the small and easy things like ibss support, lots of vdevs, maybe tx-rate reporting, etc.

Quoted 7 lines

Crash dump support is already upstream, but what's missing is porting it to use Johannes' device coredump (commit 833c95456a70) and RAM dump part. (And I guess we also want some sort register dump?)

Last year I implemented the RAM dump part, but only did some quick verification and that's why I haven't submitted it yet. I think I need to submit it as RFC instead of bitrotting on my hard drive.

I have some well tested RAM and ROM and debuglog dump patches. Similar to the patches we had worked on before. ROM and RAM require new ie header on firmware, and 3.19 ath10k broke dbglog on upstream 10.1 firmware, but aside from that, it works great :)

I have register dump supported over regular WMI api (shown in debugfs) in CT firmware, but it is not part of the crash dump. At least for me, that has not been a problem.

Thanks,
Ben

Signature · 8 lines
Ben Greear <[email protected]>
Candela Technologies Inc  http://www.candelatech.com


_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k