Skip to contentSkip to conversation

webkit: Add --enable-dependency-tracking to the configure options

PATCH New Vicente Olivert Riera 3 participants 3 messages Nov 6, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 webkit: Add --enable-dependency-tracking to the configure options

--disable-dependency-tracking was added globally to package/pkg-autotools.mk by this commit:

http://git.buildroot.net/buildroot/commit/?id=3e37b0fc6cbbe2245e39fedb247a381fb4e0d992

This causes a failure in webkit because some source files are generated after the Makefile is created. To fix this, we add --enable-dependency-tracking to the configure options.

Fixes:
http://autobuild.buildroot.net/results/5beea967b02df202bca1d42afd6fa8c2c13383d5/

---
 package/webkit/webkit.mk |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
package/webkit/webkit.mk +1 -0
index fae2e7e..98da1d6 100644
@@ -40,6 +40,7 @@ WEBKIT_CONF_ENV = ac_cv_path_icu_config=$(STAGING_DIR)/usr/bin/icu-config \
 	AR_FLAGS="cru"
 
 WEBKIT_CONF_OPTS += \
+	--enable-dependency-tracking \
 	--with-gtk=2.0 \
 	--disable-geolocation \
 	--disable-webkit2 \
Signature · 1 line
1.7.1
#1 lore raw

PATCH 1/1 webkit: Add --enable-dependency-tracking to the configure options

Dear Vicente Olivert Riera,

Quoted 11 lines · Vicente Olivert Riera

--disable-dependency-tracking was added globally to package/pkg-autotools.mk by this commit:

http://git.buildroot.net/buildroot/commit/?id=3e37b0fc6cbbe2245e39fedb247a381fb4e0d992

This causes a failure in webkit because some source files are generated after the Makefile is created. To fix this, we add --enable-dependency-tracking to the configure options.

Fixes:
http://autobuild.buildroot.net/results/5beea967b02df202bca1d42afd6fa8c2c13383d5/

Aaah, that's what causing the build failure of webkit. I believe it's wrong for webkit to do that, because dependency tracking should only be needed for the developers of the package, and not needed for a normal build. But since we're anyway going to bump webkit at some point thanks to the work of Eric Le Bihan, I don't think we want to debug this webkit version.

Therefore:

And thanks a lot for the investigation!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 webkit: Add --enable-dependency-tracking to the configure options

In reply to Vicente Olivert Riera
Quoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Vicente" == Vicente Olivert Riera <[email protected]> writes:

--disable-dependency-tracking was added globally to package/pkg-autotools.mk by this commit:

http://git.buildroot.net/buildroot/commit/?id=3e37b0fc6cbbe2245e39fedb247a381fb4e0d992

This causes a failure in webkit because some source files are generated after the Makefile is created. To fix this, we add --enable-dependency-tracking to the configure options.

Quoted 5 lines

Fixes:
http://autobuild.buildroot.net/results/5beea967b02df202bca1d42afd6fa8c2c13383d5/

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard