Skip to contentSkip to conversation

arch/arc: fix atomics selection

PATCH New Yann E. MORIN 2 participants 2 messages Sep 11, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arch/arc: fix atomics selection

Due to a kconfig limitation, we can't select a no-prompt symbol that gets its dependencies by being conditionally re-defined in one or more if-blocks, like we currently do for BR2_ARCH_HAS_ATOMICS.

As a workaround to this issue, we just redefine that symbol in the arc if-block, like we do for all other architectures, except that in the arc case, the default value is conditional.

[yann.morin.1998 at free.fr: indepently re-done a patch similar to the one
Thomas made on his own]

---
 arch/Config.in.arc | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
arch/Config.in.arc +3 -1
index 8a7f290..fcb5d7d 100644
@@ -1,7 +1,9 @@
 # Choise of atomic instructions presence
 config BR2_ARC_ATOMIC_EXT
 	bool "Atomic extension (LLOCK/SCOND instructions)"
-	select BR2_ARCH_HAS_ATOMICS
+
+config BR2_ARCH_HAS_ATOMICS
+	default y if BR2_ARC_ATOMIC_EXT
 
 config BR2_ARCH
 	default "arc"	if BR2_arcle
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 arch/arc: fix atomics selection

Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

Due to a kconfig limitation, we can't select a no-prompt symbol that gets its dependencies by being conditionally re-defined in one or more if-blocks, like we currently do for BR2_ARCH_HAS_ATOMICS.

As a workaround to this issue, we just redefine that symbol in the arc if-block, like we do for all other architectures, except that in the arc case, the default value is conditional.

Quoted 6 lines

[yann.morin.1998 at free.fr: indepently re-done a patch similar to the one
Thomas made on his own]

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard