drm/i915/SDVO: For sysfs link put directory and target in correct order
Subsystems (2)
PATCH 1/1 drm/i915/SDVO: For sysfs link put directory and target in correct order
When linking the i2c sysfs file into the connector's directory pass directory and link target in the right order. This code was introduced with:
commit 931c1c26983b4f84e33b78579fc8d57e4a14c6b4
Author: Imre Deak <[email protected]>
Date: Tue Feb 11 17:12:51 2014 +0200
drm/i915: sdvo: add i2c sysfs symlink to the connector's directory
This is the same what we do for DP connectors, so make things more consistent.
--- drivers/gpu/drm/i915/intel_sdvo.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/intel_sdvo.c +2 -2
@@ -2428,8 +2428,8 @@ intel_sdvo_connector_init(struct intel_sdvo_connector *connector,if (ret <0 ) goto err1; - ret =sysfs_create_link (&encoder->ddc.dev.kobj, - &drm_connector->kdev->kobj, + ret =sysfs_create_link (&drm_connector->kdev->kobj, + &encoder->ddc.dev.kobj, encoder->ddc.dev.kobj.name);if (ret <0 ) goto err2;
Signature · 1 line
1.8.4.5
Quoted 8 lines · Egbert Eich
When linking the i2c sysfs file into the connector's directory pass directory and link target in the right order. This code was introduced with:
commit
931c1c26983b4f84e33b78579fc8d57e4a14c6b4
Author: Imre Deak <[email protected]>
Date: Tue Feb 11 17:12:51 2014 +0200
Quoted 6 lines
drm/i915: sdvo: add i2c sysfs symlink to the connector's directory
This is the same what we do for DP connectors, so make things more consistent.
Signed-off-by Egbert Eich <[email protected]>
Oops, good catch. The fix looks ok, fwiw:
Quoted 9 lines
--- drivers/gpu/drm/i915/intel_sdvo.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/intel_sdvo.c +0
-0
drivers/gpu/drm/i915/intel_sdvo.c intel_sdvo_connector_init(struct intel_sdvo_connector *connector, · line 2435
Quoted 10 lines
drivers/gpu/drm/i915/intel_sdvo.c +2
-2@@ -2428,8 +2428,8 @@ intel_sdvo_connector_init(struct intel_sdvo_connector *connector,if (ret <0 ) goto err1; - ret =sysfs_create_link (&encoder->ddc.dev.kobj, - &drm_connector->kdev->kobj, + ret =sysfs_create_link (&drm_connector->kdev->kobj, + &encoder->ddc.dev.kobj, encoder->ddc.dev.kobj.name);if (ret <0 ) goto err2;
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Daniel Vetter
AppliedQuoted 11 lines · Imre Deak
Quoted 10 lines · Egbert Eich
When linking the i2c sysfs file into the connector's directory pass directory and link target in the right order. This code was introduced with:
commit
931c1c26983b4f84e33b78579fc8d57e4a14c6b4
Author: Imre Deak <[email protected]>
Date: Tue Feb 11 17:12:51 2014 +0200drm/i915: sdvo: add i2c sysfs symlink to the connector's directory
Quoted 7 lines
Quoted 4 lines
This is the same what we do for DP connectors, so make things more consistent.
Signed-off-by Egbert Eich <[email protected]>Oops, good catch. The fix looks ok, fwiw:
Reviewed-by Imre Deak <[email protected]>
Queued for -next, thanks for the patch.
-Daniel
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch
Jani Nikula
maintainerQuoted 15 lines · Daniel Vetter
Quoted 14 lines · Imre Deak
Quoted 13 lines · Egbert Eich
When linking the i2c sysfs file into the connector's directory pass directory and link target in the right order. This code was introduced with:
commit
931c1c26983b4f84e33b78579fc8d57e4a14c6b4
Author: Imre Deak <[email protected]>
Date: Tue Feb 11 17:12:51 2014 +0200drm/i915: sdvo: add i2c sysfs symlink to the connector's directory
This is the same what we do for DP connectors, so make things more consistent.
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
Signed-off-by Egbert Eich <[email protected]>Oops, good catch. The fix looks ok, fwiw:
Reviewed-by Imre Deak <[email protected]>Queued for -next, thanks for the patch.
And picked up for -fixes and queuing for 3.15.
BR,
Jani.
Signature · 1 line
Jani Nikula, Intel Open Source Technology Center