Skip to contentSkip to conversation

fix -boot strict regressed in commit 6ef4716

PATCH In review Amos Kong 3 participants 3 messages Dec 9, 2013

lore
Share & tools
lore

Amos Kong

author
#0 lore raw

PATCH v3 1/1 fix -boot strict regressed in commit 6ef4716

Commit 6ef4716 cleaned up parsing of -boot option argument, but accidentally dropped parameter strict. It should have been updated exactly like parameter menu. Do that.

---
v2: remove bios.bin change, I just used it for testing (mjt)
v3: merge two patches together, correct the commitlog (markus)

---
 vl.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
vl.c +2 -1
index b0399de..ae6d0c6 100644
@@ -461,7 +461,7 @@ static QemuOptsList qemu_boot_opts = {
             .type = QEMU_OPT_STRING,
         }, {
             .name = "strict",
-            .type = QEMU_OPT_STRING,
+            .type = QEMU_OPT_BOOL,
         },
         { /*End of list */ }
     },
@@ -4074,6 +4074,7 @@ int main(int argc, char **argv, char **envp)
         }
 
         boot_menu = qemu_opt_get_bool(opts, "menu", boot_menu);
+        boot_strict = qemu_opt_get_bool(opts, "strict", false);
     }
 
     if (!kernel_cmdline) {
Signature · 1 line
1.7.1
#2 lore raw
In reply to Amos Kong
Quoted 8 lines · Amos Kong

Commit 6ef4716 cleaned up parsing of -boot option argument, but accidentally dropped parameter strict. It should have been updated exactly like parameter menu. Do that.

---
v2: remove bios.bin change, I just used it for testing (mjt)
v3: merge two patches together, correct the commitlog (markus)

Picked the new version up on trivial-patches, thank you!

/mjt