Skip to contentSkip to conversation

mmc: bfin_sdh: Forgot to write SDH_CFG register in function set_ios.

PATCH In review Sonic Zhang 2 participants 2 messages Oct 16, 2013 – Oct 21, 2013 MMC, SD and SDIO

lore
Share & tools
lore

Sonic Zhang

author
#0 lore raw

PATCH 1/1 mmc: bfin_sdh: Forgot to write SDH_CFG register in function set_ios.

From: Sonic Zhang <[email protected]>

The DMA operation in SDIO CMD53 may fail because the 4 bit SDIO mode is not set up correctly on BF548.
Remove 2 blank lines as well.

Signed-off-by Sonic Zhang <[email protected]>
---
 drivers/mmc/host/bfin_sdh.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/mmc/host/bfin_sdh.c +1 -2
index 94fae2f..e62c5bc 100644
@@ -391,6 +391,7 @@ static void sdh_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
 		/* Disable 4 bit SDIO */
 		cfg &= ~SD4E;
 	}
+	bfin_write_SDH_CFG(cfg);
 
 	host->power_mode = ios->power_mode;
 #ifndef RSI_BLKSZ

@@ -415,7 +416,6 @@ static void sdh_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
 		cfg &= ~SD_CMD_OD;
 # endif
 
-
 	if (ios->power_mode != MMC_POWER_OFF)
 		cfg |= PWR_ON;
 	else

@@ -433,7 +433,6 @@ static void sdh_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
 		clk_ctl |= CLK_E;
 		host->clk_div = clk_div;
 		bfin_write_SDH_CLK_CTL(clk_ctl);
-
 	} else
 		sdh_stop_clock(host);
Signature · 1 line
1.8.2.3