Skip to contentSkip to conversation

toolchain-external: add a specific check to avoid Angstrom toolchains

PATCH Superseded Thomas Petazzoni 4 participants 6 messages Oct 13, 2013 – Oct 22, 2013

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 toolchain-external: add a specific check to avoid Angstrom toolchains

The Angstrom toolchains available at
http://www.angstrom-distribution.org/toolchains/ are not usable as external toolchains in Buildroot, because they are not pure toolchains with just the C library, but instead complete SDKs with many cross-compiled libraries (Gtk, Qt, glib, neon, sqlite, X.org, and many more, approximately 200 MB of libraries).

Buildroot cannot use such toolchains, and while this is documented in our manual, some users still try to do this. Today, one such user came on the IRC channel, reporting a build problem, which we started investigating, only to realize after a long time that he was using an Angstrom toolchain.

To avoid this problem in the future, we explicitly check if the toolchain is from Angstrom by looking at the vendor part of the tuple exposed by the toolchain: as soon as it is <something>-angstrom-<something-else>, we reject the toolchain with an explanation.

---
Changes since v1:

* Fix typos in the comments (Thomas DS)
* Rename function to check_unusable_toolchain (Thomas DS)
* Use -dumpmachine instead of -v and some nasty sed'ing (Thomas DS)
* Add quotes around $${vendor} (Thomas DS)

 toolchain/helpers.mk                               | 18 ++++++++++++++++++
 toolchain/toolchain-external/toolchain-external.mk |  1 +
 2 files changed, 19 insertions(+)
toolchain/helpers.mk +18 -0
index 95120cd..a8944ce 100644
@@ -324,3 +324,21 @@ check_cross_compiler_exists = \
 		echo "Cannot execute cross-compiler '$${__CROSS_CC}'" ; \
 		exit 1 ; \
 	fi
+
+#
+# Check for toolchains known not to work with Buildroot. For now, we
+# only check for Angstrom toolchains, by looking at the vendor part of
+# the host tuple.
+#
+# $1: cross-gcc path
+#
+check_unusable_toolchain = \
+	__CROSS_CC=$(strip $1) ; \
+	vendor=`$${__CROSS_CC} -dumpmachine | cut -f2 -d'-'` ; \
+	if test "$${vendor}" = "angstrom" ; then \
+		echo "Angstrom toolchains are not pure toolchains: they contain" ; \
+		echo "many other libraries than just the C library, which makes" ; \
+		echo "them unsuitable as external toolchains for build systems" ; \
+		echo "such as Buildroot." ; \
+		exit 1 ; \
+	fi
toolchain/toolchain-external/toolchain-external.mk +1 -0
index b5b1ce7..d41cc7c 100644
@@ -371,6 +371,7 @@ endif
 # type of C library and all C library features.
 define TOOLCHAIN_EXTERNAL_CONFIGURE_CMDS
 	$(Q)$(call check_cross_compiler_exists,$(TOOLCHAIN_EXTERNAL_CC))
+	$(Q)$(call check_unusable_toolchain,$(TOOLCHAIN_EXTERNAL_CC))
 	$(Q)LIBC_A_LOCATION=`readlink -f $$(LANG=C $(TOOLCHAIN_EXTERNAL_CC) -print-file-name=libc.a)` ; \
 	SYSROOT_DIR=`echo $${LIBC_A_LOCATION} | sed -r -e 's:(usr/)?lib(32|64)?/(.*/)?libc\.a::'` ; \
 	if test -z "$${SYSROOT_DIR}" ; then \
Signature · 1 line
1.8.1.2
#1 lore raw

PATCH v2 1/1 toolchain-external: add a specific check to avoid Angstrom toolchains

Quoted 23 lines · Thomas Petazzoni

The Angstrom toolchains available at
http://www.angstrom-distribution.org/toolchains/ are not usable as external toolchains in Buildroot, because they are not pure toolchains with just the C library, but instead complete SDKs with many cross-compiled libraries (Gtk, Qt, glib, neon, sqlite, X.org, and many more, approximately 200 MB of libraries).

Buildroot cannot use such toolchains, and while this is documented in our manual, some users still try to do this. Today, one such user came on the IRC channel, reporting a build problem, which we started investigating, only to realize after a long time that he was using an Angstrom toolchain.

To avoid this problem in the future, we explicitly check if the toolchain is from Angstrom by looking at the vendor part of the tuple exposed by the toolchain: as soon as it is <something>-angstrom-<something-else>, we reject the toolchain with an explanation.

---
Changes since v1:

Quoted 8 lines

* Fix typos in the comments (Thomas DS)
* Rename function to check_unusable_toolchain (Thomas DS)
* Use -dumpmachine instead of -v and some nasty sed'ing (Thomas DS)
* Add quotes around $${vendor} (Thomas DS)

 toolchain/helpers.mk                               | 18 ++++++++++++++++++
 toolchain/toolchain-external/toolchain-external.mk |  1 +
 2 files changed, 19 insertions(+)
#2 lore raw

PATCH v2 1/1 toolchain-external: add a specific check to avoid Angstrom toolchains

In reply to Thomas Petazzoni
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Thomas> The Angstrom toolchains available at
Thomas> http://www.angstrom-distribution.org/toolchains/ are not usable as Thomas> external toolchains in Buildroot, because they are not pure toolchains Thomas> with just the C library, but instead complete SDKs with many Thomas> cross-compiled libraries (Gtk, Qt, glib, neon, sqlite, X.org, and many Thomas> more, approximately 200 MB of libraries).

Thomas> Buildroot cannot use such toolchains, and while this is documented in Thomas> our manual, some users still try to do this. Today, one such user came Thomas> on the IRC channel, reporting a build problem, which we started Thomas> investigating, only to realize after a long time that he was using an Thomas> Angstrom toolchain.

Thomas> To avoid this problem in the future, we explicitly check if the Thomas> toolchain is from Angstrom by looking at the vendor part of the tuple Thomas> exposed by the toolchain: as soon as it is
Thomas> <something>-angstrom-<something-else>, we reject the toolchain with an Thomas> explanation.

Thomas> Signed-off-by: Thomas Petazzoni <[email protected]>

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#3 lore raw

PATCH v2 1/1 toolchain-external: add a specific check to avoid Angstrom toolchains

In reply to Thomas Petazzoni
Quoted 7 lines · Thomas Petazzoni

The Angstrom toolchains available at
http://www.angstrom-distribution.org/toolchains/ are not usable as external toolchains in Buildroot, because they are not pure toolchains with just the C library, but instead complete SDKs with many cross-compiled libraries (Gtk, Qt, glib, neon, sqlite, X.org, and many more, approximately 200 MB of libraries).

Quoted 5 lines

Buildroot cannot use such toolchains, and while this is documented in our manual, some users still try to do this. Today, one such user came on the IRC channel, reporting a build problem, which we started investigating, only to realize after a long time that he was using an Angstrom toolchain.

Just for my info, how is it possible that we cannot use such an
Angstrom toolchain as an external toolchain, but it is possible to use a buildroot-generated one? We can also generate a host dir with loads of libs, and these are perfectly usable as external toolchain, right?

Regards,
Arnout

Quoted 6 lines

To avoid this problem in the future, we explicitly check if the toolchain is from Angstrom by looking at the vendor part of the tuple exposed by the toolchain: as soon as it is <something>-angstrom-<something-else>, we reject the toolchain with an explanation.

[snip]

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#4 lore raw

PATCH v2 1/1 toolchain-external: add a specific check to avoid Angstrom toolchains

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Arnout" == Arnout Vandecappelle <[email protected]> writes:

Hi,

Quoted 4 lines

Just for my info, how is it possible that we cannot use such an
Angstrom toolchain as an external toolchain, but it is possible to use a buildroot-generated one? We can also generate a host dir with loads of libs, and these are perfectly usable as external toolchain, right?

No, we can afaik only reuse a buildroot toolchain if it is "bare", E.G. no packages selected.

Signature · 1 line
Bye, Peter Korsgaard
#5 lore raw

PATCH v2 1/1 toolchain-external: add a specific check to avoid Angstrom toolchains

Peter, Arnout,

Quoted 7 lines · Peter Korsgaard
Quoted 4 lines

Just for my info, how is it possible that we cannot use such an
Angstrom toolchain as an external toolchain, but it is possible to use a buildroot-generated one? We can also generate a host dir with loads of libs, and these are perfectly usable as external toolchain, right?

No, we can afaik only reuse a buildroot toolchain if it is "bare", E.G. no packages selected.

Yes, absolutely. Ideally, my check for "angstrom" toolchain shouldn't check for angstrom, but should instead validate that the toolchain is "pure" (i.e only the C library). Unfortunately, I don't quite see an easy and reliable way to make sure that the only libraries/headers provided are the ones of the C library.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com