ARM: OMAP: omap_device: fix return value check in omap_device_build_ss()
Subsystems (2)
PATCH 1/1 ARM: OMAP: omap_device: fix return value check in omap_device_build_ss()
From: Wei Yongjun <[email protected]>
In case of error, the function omap_device_alloc() returns ERR_PTR() and never returns NULL pointer. The NULL test in the return value check should be replaced with IS_ERR().
dpatch engine is used to auto generated this patch.
(https://github.com/weiyj/dpatch)
--- arch/arm/plat-omap/omap_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/plat-omap/omap_device.c +1 -1
@@ -671,7 +671,7 @@ struct platform_device __init *omap_device_build_ss(const char *pdev_name, int pdev_set_name (&pdev->dev,"%s" , pdev->name); od =omap_device_alloc (pdev, ohs, oh_cnt, pm_lats, pm_lats_cnt); -if (!od) +if (IS_ERR (od)) goto odbs_exit1; ret =platform_device_add_data (pdev, pdata, pdata_len);
PATCH 1/1 ARM: OMAP: omap_device: fix return value check in omap_device_build_ss()
Quoted 10 lines · Wei Yongjun
From: Wei Yongjun <[email protected]>
In case of error, the function
omap_device_alloc()returnsERR_PTR()and never returns NULL pointer. The NULL test in the return value check should be replaced withIS_ERR().dpatch engine is used to auto generated this patch.
(https://github.com/weiyj/dpatch)Signed-off-by Wei Yongjun <[email protected]>
Quoted 23 lines
--- arch/arm/plat-omap/omap_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/plat-omap/omap_device.c +1
-2@@ -671,7 +671,7 @@ struct platform_device __init *omap_device_build_ss(const char *pdev_name, int pdev_set_name (&pdev->dev,"%s" , pdev->name); od =omap_device_alloc (pdev, ohs, oh_cnt, pm_lats, pm_lats_cnt); -if (!od) +if (IS_ERR (od)) goto odbs_exit1; ret =platform_device_add_data (pdev, pdata, pdata_len); --To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH 1/1 ARM: OMAP: omap_device: fix return value check in omap_device_build_ss()
In reply to Wei YongjunQuoted 10 lines · Wei Yongjun
From: Wei Yongjun <[email protected]>
In case of error, the function
omap_device_alloc()returnsERR_PTR()and never returns NULL pointer. The NULL test in the return value check should be replaced withIS_ERR().dpatch engine is used to auto generated this patch.
(https://github.com/weiyj/dpatch)Signed-off-by Wei Yongjun <[email protected]>
Thanks, queueing this for v3.7-rc.
Kevin