Skip to contentSkip to conversation

TI814X: Create board support and enable build for TI8148 EVM

PATCH Superseded Hemant Pedanekar 3 participants 5 messages Aug 4, 2011 – Sep 8, 2011

Subsystems (3)
Arm (32-bit) Arm sub-architectures OMAP2+ support

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Hemant Pedanekar

author
#0 lore raw

PATCH 3/3 TI814X: Create board support and enable build for TI8148 EVM

This patch adds minimal support and build configuration for TI8148 EVM. Also adds support for low level debugging on UART1 console on the EVM.

Signed-off-by Hemant Pedanekar <[email protected]>
---
 arch/arm/mach-omap2/Kconfig                  |    5 ++
 arch/arm/mach-omap2/Makefile                 |    1 +
 arch/arm/mach-omap2/board-ti8148evm.c        |   57 ++++++++++++++++++++++++++
 arch/arm/plat-omap/include/plat/uncompress.h |    3 +
 4 files changed, 66 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/mach-omap2/board-ti8148evm.c
arch/arm/mach-omap2/Kconfig +5 -0
index 242d9ab..4dacb8e 100644
@@ -317,6 +317,11 @@ config MACH_TI8168EVM
 	depends on SOC_OMAPTI81XX
 	default y
 
+config MACH_TI8148EVM
+	bool "TI8148 Evaluation Module"
+	depends on SOC_OMAPTI81XX
+	default y
+
 config MACH_OMAP_4430SDP
 	bool "OMAP 4430 SDP board"
 	default y
arch/arm/mach-omap2/Makefile +1 -0
index fb02937..fa54361 100644
@@ -262,6 +262,7 @@ obj-$(CONFIG_MACH_CRANEBOARD)		+= board-am3517crane.o
 obj-$(CONFIG_MACH_SBC3530)		+= board-omap3stalker.o \
 					   hsmmc.o
 obj-$(CONFIG_MACH_TI8168EVM)		+= board-ti8168evm.o
+obj-$(CONFIG_MACH_TI8148EVM)		+= board-ti8148evm.o
 # Platform specific device init code
 usbfs-$(CONFIG_ARCH_OMAP_OTG)		:= usb-fs.o
 obj-y					+= $(usbfs-m) $(usbfs-y)
arch/arm/mach-omap2/board-ti8148evm.c new file +57 -0

57 lines not on this page · raw message

arch/arm/plat-omap/include/plat/uncompress.h +3 -0
index 40336ad..8d052e7 100644
@@ -175,6 +175,9 @@ static inline void __arch_decomp_setup(unsigned long arch_id)
 		/* TI8168 base boards using UART3 */
 		DEBUG_LL_TI81XX(3, ti8168evm);
 
+		/* TI8148 base boards using UART1 */
+		DEBUG_LL_TI81XX(1, ti8148evm);
+
 	} while (0);
 }
Signature · 1 line
1.7.3.5
maintainer
#1 lore raw

PATCH 3/3 TI814X: Create board support and enable build for TI8148 EVM

Quoted 2 lines · Hemant Pedanekar

This patch adds minimal support and build configuration for TI8148 EVM. Also adds support for low level debugging on UART1 console on the EVM.

...

arch/arm/mach-omap2/board-ti8148evm.c line 57

Quoted 9 lines
arch/arm/mach-omap2/board-ti8148evm.c new file +9 -0
+MACHINE_START(TI8148EVM, "ti8148evm")
+	/* Maintainer: Texas Instruments */
+	.boot_params	= 0x80000100,
+	.map_io		= ti8148_evm_map_io,
+	.init_early	= ti8148_init_early,
+	.init_irq	= ti81xx_init_irq,
+	.timer		= &omap3_timer,
+	.init_machine	= ti8148_evm_init,
+MACHINE_END

Please just combine this with board-ti8168evm.c by adding the MACHINE_START there. It seems the files are identical otherwise?

Regards,

Tony

author
#2 lore raw

PATCH 3/3 TI814X: Create board support and enable build for TI8148 EVM

Tony Lindgren wrote on Monday, August 15, 2011 8:45 PM:

Quoted 5 lines · Hemant Pedanekar
Quoted 2 lines

This patch adds minimal support and build configuration for TI8148 EVM. Also adds support for low level debugging on UART1 console on the EVM. ...

Quoted 13 lines

arch/arm/mach-omap2/board-ti8148evm.c line 57

Quoted 9 lines
arch/arm/mach-omap2/board-ti8148evm.c new file +9 -0
+MACHINE_START(TI8148EVM, "ti8148evm")
+	/* Maintainer: Texas Instruments */
+	.boot_params	= 0x80000100,
+	.map_io		= ti8148_evm_map_io,
+	.init_early	= ti8148_init_early,
+	.init_irq	= ti81xx_init_irq,
+	.timer		= &omap3_timer,
+	.init_machine	= ti8148_evm_init,
+MACHINE_END

Please just combine this with board-ti8168evm.c by adding the MACHINE_START there. It seems the files are identical otherwise?

Tony,
There will be more additions in respective board files such as I2C I/O expander data, mux handling depending upon the EVM (8168/8148), on board peripherals etc When these board files would deviate.

What do you suggest to handle such?

Thanks.
Hemant

#3 lore raw

PATCH 3/3 TI814X: Create board support and enable build for TI8148 EVM

In reply to Hemant Pedanekar
Quoted 4 lines · Hemant Pedanekar

This patch adds minimal support and build configuration for TI8148 EVM. Also adds support for low level debugging on UART1 console on the EVM.

Signed-off-by Hemant Pedanekar <[email protected]>

[...]

arch/arm/mach-omap2/board-ti8148evm.c line 33

Quoted 4 lines
arch/arm/mach-omap2/board-ti8148evm.c new file +4 -0
+static void __init ti8148_init_early(void)
+{
+	omap2_init_common_infrastructure();
+	omap2_init_common_devices(NULL, NULL);

Note that this function no longer exists in mainline.

Kevin

author
#4 lore raw

PATCH 3/3 TI814X: Create board support and enable build for TI8148 EVM

Hilman, Kevin wrote on Tuesday, August 30, 2011 5:43 AM:

Quoted 9 lines
Quoted 4 lines · Hemant Pedanekar

This patch adds minimal support and build configuration for TI8148 EVM. Also adds support for low level debugging on UART1 console on the EVM.

Signed-off-by Hemant Pedanekar <[email protected]>

[...]

Quoted 8 lines

arch/arm/mach-omap2/board-ti8148evm.c line 33

Quoted 4 lines
arch/arm/mach-omap2/board-ti8148evm.c new file +4 -0
+static void __init ti8148_init_early(void)
+{
+	omap2_init_common_infrastructure();
+	omap2_init_common_devices(NULL, NULL);

Note that this function no longer exists in mainline.

Kevin

Will fix this in v2.

Thanks.
Hemant