Skip to contentSkip to conversation

MTD: Correct misspelled Kconfig var CONFIG_MTD_DATAFLASH_VERIFY_WRITE

PATCH In review Robert P. J. Day 3 participants 4 messages Sep 11, 2009 – Sep 14, 2009 Memory technology devices (MTD)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 MTD: Correct misspelled Kconfig var CONFIG_MTD_DATAFLASH_VERIFY_WRITE

Make the source file correction CONFIG_MTD_DATAFLASH_VERIFY_WRITE -> CONFIG_MTD_DATAFLASH_WRITE_VERIFY to match the Kconfig variable in drivers/mtd/devices/Kconfig.

---

whoops, sorry, previous commit msg didn't show the actual
correction, this one does.

drivers/mtd/devices/mtd_dataflash.c +2 -2
index 43976aa..70a7369 100644
@@ -401,7 +401,7 @@ static int dataflash_write(struct mtd_info *mtd, loff_t to, size_t len,
 		(void) dataflash_waitready(priv->spi);
 
 
-#ifdef CONFIG_MTD_DATAFLASH_VERIFY_WRITE
+#ifdef CONFIG_MTD_DATAFLASH_WRITE_VERIFY
 
 		/* (3) Compare to Buffer1 */
 		addr = pageaddr << priv->page_offset;
@@ -430,7 +430,7 @@ static int dataflash_write(struct mtd_info *mtd, loff_t to, size_t len,
 		} else
 			status = 0;
 
-#endif	/* CONFIG_MTD_DATAFLASH_VERIFY_WRITE */
+#endif	/* CONFIG_MTD_DATAFLASH_WRITE_VERIFY */
 
 		remaining = remaining - writelen;
 		pageaddr++;

========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA

Linux Consulting, Training and Annoying Kernel Pedantry.

Web page:                                          http://crashcourse.ca
Twitter:                                       http://twitter.com/rpjday

========================================================================

Acked-by on v1 1/1
#1 lore raw
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Robert" == Robert P J Day <[email protected]> writes:

Robert> Make the source file correction CONFIG_MTD_DATAFLASH_VERIFY_WRITE -> Robert> CONFIG_MTD_DATAFLASH_WRITE_VERIFY to match the Kconfig variable in Robert> drivers/mtd/devices/Kconfig.

Robert> Signed-off-by: Robert P. J. Day <[email protected]>

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw
In reply to Robert P. J. Day
Quoted 5 lines · Robert P. J. Day

Make the source file correction CONFIG_MTD_DATAFLASH_VERIFY_WRITE -> CONFIG_MTD_DATAFLASH_WRITE_VERIFY to match the Kconfig variable in drivers/mtd/devices/Kconfig.

Actually, a patch you sent earlier is already in the mtd-2.6.git tree:
http://git.infradead.org/mtd-2.6.git/commit/05dd180709fca14fbae617c0dab1bed56be334fc

Signature · 2 lines
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
#3 lore raw
Quoted 9 lines · Artem Bityutskiy
Quoted 5 lines · Robert P. J. Day

Make the source file correction CONFIG_MTD_DATAFLASH_VERIFY_WRITE -> CONFIG_MTD_DATAFLASH_WRITE_VERIFY to match the Kconfig variable in drivers/mtd/devices/Kconfig.

Actually, a patch you sent earlier is already in the mtd-2.6.git tree:
http://git.infradead.org/mtd-2.6.git/commit/05dd180709fca14fbae617c0dab1bed56be334fc

i submitted a different one based on the recommendation of what
should be changed for those two bits of text to match up. either one of those two patches will work just fine, they just resolve the issue in opposite ways. whatever people on this list prefer is fine with me.

rday
--

========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA

Linux Consulting, Training and Annoying Kernel Pedantry.

Web page:                                          http://crashcourse.ca
Twitter:                                       http://twitter.com/rpjday

========================================================================