Skip to contentSkip to conversation

Pull request for branch pciutils-fix

GIT PULL New Thomas Petazzoni 2 participants 4 messages Aug 1, 2009 – Aug 2, 2009

lore
Share & tools
lore

Thomas Petazzoni

author
#0 lore raw

The following changes since commit e15c0d07e15e94e800bd9a0cf3c24f45aeacd89c:
Peter Korsgaard (1):
target/device: rename program invocation symbol in defconfigs

are available in the git repository at:

git://git.busybox.net/~tpetazzoni/git/buildroot pciutils-fix

Thomas Petazzoni (1):
pciutils: fix build with external toolchains

 CHANGES                      |    1 +
 package/pciutils/pciutils.mk |    2 +-
 2 files changed, 2 insertions(+), 1 deletions(-)

Thanks,

Signature · 1 line
Thomas Petazzoni
author
#1 lore raw

PATCH 1/1 pciutils: fix build with external toolchains

Buildroot Makefile to compile pciutils wasn't passing TARGET_LDFLAGS to pciutils build system. Therefore, at link time, the pciutils build system was not taking into account the important --sysroot option, which was breaking the link with external toolchains.

Fixes bug #523.

Signed-off-by Thomas Petazzoni <[email protected]>
---
 CHANGES                      |    1 +
 package/pciutils/pciutils.mk |    2 +-
 2 files changed, 2 insertions(+), 1 deletions(-)
CHANGES +1 -0
index 527383c..684b394 100644
@@ -50,6 +50,7 @@
 	#495: Bump bind package to 9.5.1-P3 (security)
 	#497: OpenSSL RSA key generation hangs on x86_64
 	#509: Bump sqlite package to 3.6.16
+	#527: pciutils broken with external toolchain
 
 2009.05, Released June 1st, 2009:
package/pciutils/pciutils.mk +1 -1
index 0d8155f..976afbf 100644
@@ -41,7 +41,7 @@ $(PCIUTILS_DIR)/.unpacked: $(DL_DIR)/$(PCIUTILS_SOURCE) $(DL_DIR)/$(PCIIDS_SOURC
 	touch $@
 
 $(PCIUTILS_DIR)/.compiled: $(PCIUTILS_DIR)/.unpacked
-	$(MAKE1) CC="$(TARGET_CC)" OPT="$(TARGET_CFLAGS)" RANLIB=$(TARGET_RANLIB) AR=$(TARGET_AR) -C $(PCIUTILS_DIR) \
+	$(MAKE1) CC="$(TARGET_CC)" OPT="$(TARGET_CFLAGS)" LDFLAGS="$(TARGET_LDFLAGS)" RANLIB=$(TARGET_RANLIB) AR=$(TARGET_AR) -C $(PCIUTILS_DIR) \
 		SHAREDIR="/usr/share/misc" \
 		ZLIB=$(PCIUTILS_HAVE_ZLIB) \
 		HOST=$(KERNEL_ARCH)-linux \
Signature · 1 line
1.6.0.4
#2 lore raw

PATCH 1/1 pciutils: fix build with external toolchains

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Thomas> Buildroot Makefile to compile pciutils wasn't passing TARGET_LDFLAGS Thomas> to pciutils build system. Therefore, at link time, the pciutils build Thomas> system was not taking into account the important --sysroot option, Thomas> which was breaking the link with external toolchains.

Thomas> Fixes bug #523.

Thomas> +++ b/CHANGES
Thomas> @@ -50,6 +50,7 @@

 Thomas>  	#495: Bump bind package to 9.5.1-P3 (security)
 Thomas>  	#497: OpenSSL RSA key generation hangs on x86_64
 Thomas>  	#509: Bump sqlite package to 3.6.16

Thomas> + #527: pciutils broken with external toolchain

523, not 527 - But I'll fix that up myself.

Signature · 1 line
Bye, Peter Korsgaard
#3 lore raw
In reply to Thomas Petazzoni
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Thomas> The following changes since commit e15c0d07e15e94e800bd9a0cf3c24f45aeacd89c:
Thomas> Peter Korsgaard (1):
Thomas> target/device: rename program invocation symbol in defconfigs

Thomas> are available in the git repository at:

Thomas> git://git.busybox.net/~tpetazzoni/git/buildroot pciutils-fix

Thomas> Thomas Petazzoni (1):
Thomas> pciutils: fix build with external toolchains

Pulled and pushed, thanks!

Signature · 1 line
Bye, Peter Korsgaard