Skip to contentSkip to conversation

Make the MESSAGE Macro work

PATCH New hartleys 2 participants 3 messages Nov 5, 2008 – Nov 7, 2008

lore
Share & tools
lore

hartleys

author
#0 lore raw

PATCH 1/1 Make the MESSAGE Macro work

Hello all,

The following patch makes the MESSAGE Macro in Makefile.autotools.in work.

I think it was originally intended to print the messages in bold type but it doesn't appear to work correctly. This patch should work on all platforms.

---

--- package/Makefile.autotools.in.orig 2008-11-05 10:01:49.000000000
-0700
+++ package/Makefile.autotools.in 2008-11-05 10:08:25.000000000
-0700
@@ -114,8 +114,8 @@

# MESSAGE Macro -- display a message in bold type MESSAGE = @echo "$(TERM_BOLD)>>> $($(PKG)_NAME) $($(PKG)_VERSION)
$(1)$(TERM_RESET)"
-TERM_BOLD = #$(shell tput bold)
-TERM_RESET = #$(shell tput rmso)
+TERM_BOLD = $(shell tput smso)
+TERM_RESET = $(shell tput rmso)

# Utility programs used to build packages
TAR ?= tar

#1 lore raw

PATCH 1/1 Make the MESSAGE Macro work

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"hartleys" == hartleys <[email protected]> writes:

hartleys> Hello all,
hartleys> The following patch makes the MESSAGE Macro in Makefile.autotools.in hartleys> work.

hartleys> I think it was originally intended to print the messages in bold type hartleys> but it doesn't appear to work correctly. This patch should work on all hartleys> platforms.

hartleys> # MESSAGE Macro -- display a message in bold type hartleys> MESSAGE = @echo "$(TERM_BOLD)>>> $($(PKG)_NAME) $($(PKG)_VERSION) hartleys> $(1)$(TERM_RESET)"
hartleys> -TERM_BOLD = #$(shell tput bold)
hartleys> -TERM_RESET = #$(shell tput rmso)
hartleys> +TERM_BOLD = $(shell tput smso)
hartleys> +TERM_RESET = $(shell tput rmso)

These should probably be := so we don't end up with tons of tput calls.

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH 1/1 Make the MESSAGE Macro work

In reply to hartleys
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"hartleys" == hartleys <[email protected]> writes:

hartleys> Hello all,
hartleys> The following patch makes the MESSAGE Macro in Makefile.autotools.in hartleys> work.

hartleys> I think it was originally intended to print the messages in bold type hartleys> but it doesn't appear to work correctly. This patch should work on all

Thanks, committed (with :=) as r23955.

Signature · 1 line
Bye, Peter Korsgaard