Skip to contentSkip to conversation

arm: msm: trout: fix compile failure

PATCH New Daniel Walker 3 participants 4 messages Apr 12, 2012 – Apr 16, 2012

Subsystems (3)
Arm (32-bit) Arm sub-architectures Arm Qualcomm mailing list
lore
Share & tools
lore

Daniel Walker

author
#0 lore raw

PATCH 1/1 arm: msm: trout: fix compile failure

Fixes the following warnings,

arch/arm/mach-msm/board-trout.c: In function 'trout_init':
arch/arm/mach-msm/board-trout.c:71: error: 'system_rev' undeclared (first use in this function) arch/arm/mach-msm/board-trout.c:71: error: (Each undeclared identifier is reported only once arch/arm/mach-msm/board-trout.c:71: error: for each function it appears in.)

and

arch/arm/mach-msm/board-trout-panel.c: In function 'trout_init_panel':
arch/arm/mach-msm/board-trout-panel.c:267: error: 'system_rev' undeclared (first use in this function) arch/arm/mach-msm/board-trout-panel.c:267: error: (Each undeclared identifier is reported only once arch/arm/mach-msm/board-trout-panel.c:267: error: for each function it appears in.)

This came in with the following commit 9f97da78bf018206fb623cd351d454af2f105fe0 which removes asm/system.h

Signed-off-by Daniel Walker <[email protected]>
cc David Howells <[email protected]>
cc Bryan Huntsman <[email protected]>
cc linux-arm-msm at vger.kernel.org
cc linux-arm-kernel at lists.infradead.org
---
 arch/arm/mach-msm/board-trout-panel.c |    1 +
 arch/arm/mach-msm/board-trout.c       |    1 +
 2 files changed, 2 insertions(+)
arch/arm/mach-msm/board-trout-panel.c +1 -0
index 25105c1..89bf6b4 100644
@@ -12,6 +12,7 @@
 
 #include <asm/io.h>
 #include <asm/mach-types.h>
+#include <asm/system_info.h>
 
 #include <mach/msm_fb.h>
 #include <mach/vreg.h>
arch/arm/mach-msm/board-trout.c +1 -0
index 5414f76..d4060a3 100644
@@ -19,6 +19,7 @@
 #include <linux/platform_device.h>
 #include <linux/clkdev.h>
 
+#include <asm/system_info.h>
 #include <asm/mach-types.h>
 #include <asm/mach/arch.h>
 #include <asm/mach/map.h>
Signature · 1 line
1.7.10.130.g36e6c
author
#1 lore raw

PATCH 1/1 arm: msm: trout: fix compile failure

Quoted 7 lines · Daniel Walker

Fixes the following warnings,

arch/arm/mach-msm/board-trout.c: In function 'trout_init':
arch/arm/mach-msm/board-trout.c:71: error: 'system_rev' undeclared (first use in this function) arch/arm/mach-msm/board-trout.c:71: error: (Each undeclared identifier is reported only once arch/arm/mach-msm/board-trout.c:71: error: for each function it appears in.)

Quoted 7 lines

and

arch/arm/mach-msm/board-trout-panel.c: In function 'trout_init_panel':
arch/arm/mach-msm/board-trout-panel.c:267: error: 'system_rev' undeclared (first use in this function) arch/arm/mach-msm/board-trout-panel.c:267: error: (Each undeclared identifier is reported only once arch/arm/mach-msm/board-trout-panel.c:267: error: for each function it appears in.)

This needs to go upstream ASAP ..

Daniel

#2 lore raw

PATCH 1/1 arm: msm: trout: fix compile failure

Quoted 10 lines · Daniel Walker
Quoted 9 lines · Daniel Walker

Fixes the following warnings,

arch/arm/mach-msm/board-trout.c: In function 'trout_init':
arch/arm/mach-msm/board-trout.c:71: error: 'system_rev' undeclared (first use in this function) arch/arm/mach-msm/board-trout.c:71: error: (Each undeclared identifier is reported only once arch/arm/mach-msm/board-trout.c:71: error: for each function it appears in.)

and

Quoted 7 lines
Quoted 5 lines

arch/arm/mach-msm/board-trout-panel.c: In function 'trout_init_panel':
arch/arm/mach-msm/board-trout-panel.c:267: error: 'system_rev' undeclared (first use in this function) arch/arm/mach-msm/board-trout-panel.c:267: error: (Each undeclared identifier is reported only once arch/arm/mach-msm/board-trout-panel.c:267: error: for each function it appears in.)

This needs to go upstream ASAP ..

I was going to send out a pull request today.

David

Signature · 2 lines
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
#3 lore raw

PATCH 1/1 arm: msm: trout: fix compile failure

In reply to Daniel Walker
Quoted 14 lines · Daniel Walker

Fixes the following warnings,

arch/arm/mach-msm/board-trout.c: In function 'trout_init':
arch/arm/mach-msm/board-trout.c:71: error: 'system_rev' undeclared (first use in this function) arch/arm/mach-msm/board-trout.c:71: error: (Each undeclared identifier is reported only once arch/arm/mach-msm/board-trout.c:71: error: for each function it appears in.)

and

arch/arm/mach-msm/board-trout-panel.c: In function 'trout_init_panel':
arch/arm/mach-msm/board-trout-panel.c:267: error: 'system_rev' undeclared (first use in this function) arch/arm/mach-msm/board-trout-panel.c:267: error: (Each undeclared identifier is reported only once arch/arm/mach-msm/board-trout-panel.c:267: error: for each function it appears in.)

Quoted 8 lines

This came in with the following commit 9f97da78bf018206fb623cd351d454af2f105fe0 which removes asm/system.h

Signed-off-by Daniel Walker <[email protected]>
cc David Howells <[email protected]>
cc Bryan Huntsman <[email protected]>
cc linux-arm-msm at vger.kernel.org
cc linux-arm-kernel at lists.infradead.org
Acked-by David Howells <[email protected]>