Skip to contentSkip to conversation

Correct error message for --tls-crypt-v2-genkey client

PATCH In review tincanteksup 3 participants 3 messages Oct 30, 2018 – Oct 31, 2018

lore
Share & tools
lore

tincanteksup

author
#0 lore raw

PATCH 1/1 Correct error message for --tls-crypt-v2-genkey client

Correct error message for --tls-crypt-v2-genkey client

Signed-off-by Richard Bonhomme <[email protected]...>

---

src/openvpn/init.c +1 -1
index 882337b2..39e8ca5f 100644
@@ -1087,7 +1087,7 @@ do_genkey(const struct options *options)
         {
             if (!options->tls_crypt_v2_file)
             {
-                msg(M_USAGE, "--tls-crypt-v2-gen-client-key requires a server key to be set via --tls-crypt-v2");
+                msg(M_USAGE, "--tls-crypt-v2-genkey requires a server key to be set via --tls-crypt-v2 to create a client key");
             }

tls_crypt_v2_write_client_key_file(options->tls_crypt_v2_genkey_file,

Signature · 1 line
2.17.1
Acked-by on v1 1/1
#1 lore raw

Hi,

Quoted 19 lines · tincanteksup

Correct error message for --tls-crypt-v2-genkey client

Signed-off-by Richard Bonhomme <[email protected]...>

---

src/openvpn/init.c +1 -1
index 882337b2..39e8ca5f 100644
@@ -1087,7 +1087,7 @@ do_genkey(const struct options *options)
          {
              if (!options->tls_crypt_v2_file)
              {
-                msg(M_USAGE, "--tls-crypt-v2-gen-client-key requires a
 server key to be set via --tls-crypt-v2");
+                msg(M_USAGE, "--tls-crypt-v2-genkey requires a server
 key to be set via --tls-crypt-v2 to create a client key");
              }
Quoted 1 line

tls_crypt_v2_write_client_key_file(options->tls_crypt_v2_genkey_file,

This is a remnant of one of the earlier patch versions, where the option was named differently. Thanks for spotting and supplying the fix.

Acked-by Steffan Karger <[email protected]...>

-Steffan

#2 lore raw
In reply to tincanteksup

Your patch has been applied to the master branch.

Thanks for your first patch contribution :-) - a few words for the next
one: please do use "git send-email" to send your patches out, and do not let exchange anywhere near your patches. What you sent was so garbled by the mailer (lines wrapped, spaces at the beginning of the line changed) that I did not manage to apply it using "git am $mailfile" to my tree.

commit 658a8ee453a236e48ecc4bf19a81d8d7717955ff

Author: tincanteksup
Date:   Tue Oct 30 23:20:32 2018 +0000
     Correct error message for --tls-crypt-v2-genkey client

     Signed-off-by: Richard Bonhomme <[email protected]...>
     Acked-by: Steffan Karger <[email protected]...>
     Message-Id: <[email protected]...>
     URL: https://www.mail-archive.com/[email protected]/msg17862.html
     Signed-off-by: Gert Doering <[email protected]...>

--
kind regards,

Gert Doering