Skip to contentSkip to conversation

package/boost: cleanup HOST_BOOST_FLAGS

PATCH Applied Michael Nosthoff via buildroot 2 participants 3 messages Jul 12, 2024 – Aug 20, 2024

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 package/boost: cleanup HOST_BOOST_FLAGS

- fix alphabetical ordering
- put one module per line
- add comment explaining why options are enabled

---

v2: break the wall of text into one module per line

remark:
writing it this way leads to the generated list starting and ending with a ','. It's working fine but looks a bit weird in the output. Is this okay?

Quoted 1 line
Quoted 1 line

--without-libraries=,atomic,chrono,container,context,contract,coroutine,date_time,exception,fiber,filesystem,graph,graph_parallel,iostreams,json,locale,log,math,mpi,nowide,program_options,python,random,serialization,stacktrace,test,thread,timer,type_erasure,url,wave,

---
 package/boost/boost.mk | 37 ++++++++++++++++++++++++++++++++-----
 1 file changed, 32 insertions(+), 5 deletions(-)
package/boost/boost.mk +32 -5
index 9b1baec5bf..bb73edfda6 100644
@@ -13,12 +13,39 @@ BOOST_LICENSE_FILES = LICENSE_1_0.txt
 BOOST_CPE_ID_VENDOR = boost
 
 # keep host variant as minimal as possible
+# regex & system are needed by host-riscv-isa-sim
 HOST_BOOST_FLAGS = --without-icu --with-toolset=gcc \
-	--without-libraries=$(subst $(space),$(comma),atomic chrono context \
-	contract container coroutine date_time exception fiber filesystem graph \
-	graph_parallel iostreams json locale log math mpi nowide program_options \
-	python random serialization stacktrace test thread timer \
-	type_erasure url wave)
+	--without-libraries=$(subst $(space),$(comma),\
+	atomic \
+	chrono container \
+	context \
+	contract \
+	coroutine \
+	date_time \
+	exception \
+	fiber \
+	filesystem \
+	graph \
+	graph_parallel \
+	iostreams \
+	json \
+	locale \
+	log \
+	math \
+	mpi \
+	nowide \
+	program_options \
+	python \
+	random \
+	serialization \
+	stacktrace \
+	test \
+	thread \
+	timer \
+	type_erasure \
+	url \
+	wave\
+	)
 
 BOOST_WITHOUT_FLAGS += $(if $(BR2_PACKAGE_BOOST_ATOMIC),,atomic)
 BOOST_WITHOUT_FLAGS += $(if $(BR2_PACKAGE_BOOST_CHRONO),,chrono)
Signature · 6 lines
2.34.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw
Quoted 5 lines · Michael Nosthoff via buildroot

- fix alphabetical ordering
- put one module per line
- add comment explaining why options are enabled

Applied to master, thanks.

Regards,
Arnout

Quoted 53 lines

---

v2: break the wall of text into one module per line

remark:
writing it this way leads to the generated list starting and ending with a ','. It's working fine but looks a bit weird in the output. Is this okay?

Quoted 1 line
Quoted 1 line

--without-libraries=,atomic,chrono,container,context,contract,coroutine,date_time,exception,fiber,filesystem,graph,graph_parallel,iostreams,json,locale,log,math,mpi,nowide,program_options,python,random,serialization,stacktrace,test,thread,timer,type_erasure,url,wave,

---
  package/boost/boost.mk | 37 ++++++++++++++++++++++++++++++++-----
  1 file changed, 32 insertions(+), 5 deletions(-)
package/boost/boost.mk +25 -5
index 9b1baec5bf..bb73edfda6 100644
@@ -13,12 +13,39 @@ BOOST_LICENSE_FILES = LICENSE_1_0.txt
  BOOST_CPE_ID_VENDOR = boost
 
  # keep host variant as minimal as possible
+# regex & system are needed by host-riscv-isa-sim
  HOST_BOOST_FLAGS = --without-icu --with-toolset=gcc \
-	--without-libraries=$(subst $(space),$(comma),atomic chrono context \
-	contract container coroutine date_time exception fiber filesystem graph \
-	graph_parallel iostreams json locale log math mpi nowide program_options \
-	python random serialization stacktrace test thread timer \
-	type_erasure url wave)
+	--without-libraries=$(subst $(space),$(comma),\
+	atomic \
+	chrono container \
+	context \
+	contract \
+	coroutine \
+	date_time \
+	exception \
+	fiber \
+	filesystem \
+	graph \
+	graph_parallel \
+	iostreams \
+	json \
+	locale \
+	log \
+	math \
+	mpi \
+	nowide \
+	program_options \
+	python \
+	random \
+	serialization \
+	stacktrace \

package/boost/boost.mk BOOST_LICENSE_FILES = LICENSE_1_0.txt · line 51

Quoted 10 lines
package/boost/boost.mk +7 -0
+	test \
+	thread \
+	timer \
+	type_erasure \
+	url \
+	wave\
+	)
 
  BOOST_WITHOUT_FLAGS += $(if $(BR2_PACKAGE_BOOST_ATOMIC),,atomic)
  BOOST_WITHOUT_FLAGS += $(if $(BR2_PACKAGE_BOOST_CHRONO),,chrono)

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#2 lore raw
In reply to Michael Nosthoff via buildroot
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Michael" == Michael Nosthoff via buildroot <[email protected]> writes:

- fix alphabetical ordering
- put one module per line
- add comment explaining why options are enabled

Quoted 7 lines

---

v2: break the wall of text into one module per line

remark:
writing it this way leads to the generated list starting and ending with a ','. It's working fine but looks a bit weird in the output. Is this okay?

Committed to 2024.02.x and 2024.05.x, thanks.

Signature · 5 lines
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot