Skip to contentSkip to conversation

ALSA: hda/hdmi: Use only dynamic PCM device allocation

PATCH In review Jaroslav Kysela 4 participants 7 messages Sep 22, 2022 – Jan 27, 2023

Subsystems (3)
lore
Share & tools
lore

Jaroslav Kysela

author maintainer
#0 lore raw

PATCH 1/1 ALSA: hda/hdmi: Use only dynamic PCM device allocation

Per discussion on the alsa-devel mailing list [1], the legacy PIN to PCM device mapping is obsolete nowadays. The maximum number of the simultaneously usable PCM devices is equal to the HDMI codec converters.

Remove the extra PCM devices (beyond the detected converters) and force the use of the dynamic PCM device allocation. The legacy code is removed.

I believe that all HDMI codecs have the jack sensing feature. Move the check to the codec probe function and print a warning, if a codec without this feature is detected.

[1] https://lore.kernel.org/alsa-devel/[email protected]/

---
 include/sound/hda_codec.h   |   1 -
 sound/pci/hda/patch_hdmi.c  | 153 +++++++-----------------------------
 sound/soc/codecs/hda.c      |   3 -
 sound/soc/codecs/hdac_hda.c |   3 -
 4 files changed, 28 insertions(+), 132 deletions(-)
include/sound/hda_codec.h +0 -1
index 6d3c82c4b6ac..684e6131737e 100644
@@ -258,7 +258,6 @@ struct hda_codec {
 	unsigned int link_down_at_suspend:1; /* link down at runtime suspend */
 	unsigned int relaxed_resume:1;	/* don't resume forcibly for jack */
 	unsigned int forced_resume:1; /* forced resume for jack */
-	unsigned int mst_no_extra_pcms:1; /* no backup PCMs for DP-MST */
 
 #ifdef CONFIG_PM
 	unsigned long power_on_acct;
sound/pci/hda/patch_hdmi.c +28 -125

272 lines not on this page · raw message

sound/soc/codecs/hda.c +0 -3
index ad20a3dff9b7..61e8e9be6b8d 100644
@@ -224,9 +224,6 @@ static int hda_codec_probe(struct snd_soc_component *component)
 		goto err;
 	}
 
-	/* configure codec for 1:1 PCM:DAI mapping */
-	codec->mst_no_extra_pcms = 1;
-
 	ret = snd_hda_codec_parse_pcms(codec);
 	if (ret < 0) {
 		dev_err(&hdev->dev, "unable to map pcms to dai %d\n", ret);
sound/soc/codecs/hdac_hda.c +0 -3
index 8debcee59224..7876bdd558a7 100644
@@ -461,9 +461,6 @@ static int hdac_hda_codec_probe(struct snd_soc_component *component)
 		dev_dbg(&hdev->dev, "no patch file found\n");
 	}
 
-	/* configure codec for 1:1 PCM:DAI mapping */
-	hcodec->mst_no_extra_pcms = 1;
-
 	ret = snd_hda_codec_parse_pcms(hcodec);
 	if (ret < 0) {
 		dev_err(&hdev->dev, "unable to map pcms to dai %d\n", ret);
Signature · 1 line
2.35.3
#1 lore raw
Quoted 8 lines · Jaroslav Kysela

Per discussion on the alsa-devel mailing list [1], the legacy PIN to PCM device mapping is obsolete nowadays. The maximum number of the simultaneously usable PCM devices is equal to the HDMI codec converters.

Remove the extra PCM devices (beyond the detected converters) and force the use of the dynamic PCM device allocation. The legacy code is removed.

Quoted 8 lines

I believe that all HDMI codecs have the jack sensing feature. Move the check to the codec probe function and print a warning, if a codec without this feature is detected.

[1] https://lore.kernel.org/alsa-devel/[email protected]/

Applied now. Thanks.

Takashi

#2 lore raw
In reply to Jaroslav Kysela

CC'ing amd-gfx as this might be an issue in the amd driver.

This change causes a regression in Linux 6.1 at least on some AMD APUs. There are reports from users with Ryzen 4750U, 5800U and 5850U chips where the HDMI sound devices don't show up anymore. I'm affected by this as well.

Reverting this commit (ef6f5494) makes the HDMI audio devices show up again. I verified that this is still an issue in current Linux git (72a85e2b).

Am Donnerstag, dem 22.09.2022 um 10:40 +0200 schrieb Jaroslav Kysela:

Quoted 10 lines
Quoted 10 lines

Per discussion on the alsa-devel mailing list [1], the legacy PIN to PCM device mapping is obsolete nowadays. The maximum number of the simultaneously usable PCM devices is equal to the HDMI codec converters.

Remove the extra PCM devices (beyond the detected converters) and force the use of the dynamic PCM device allocation. The legacy code is removed.

I believe that all HDMI codecs have the jack sensing feature. Move the check to the codec probe function and print a warning, if a codec without this feature is detected.

The corresponding message ("jack not detectable") is not shown on the affected system.

Quoted 1 line
Quoted 1 line

[1] https://lore.kernel.org/alsa-devel/[email protected]/

Links to some reports of this issue:
https://bugzilla.kernel.org/show_bug.cgi?id=216836
https://bbs.archlinux.org/viewtopic.php?pid=2075700
https://bugs.archlinux.org/task/76917
https://www.reddit.com/r/archlinux/comments/zsqq7i/hdmi_audio_is_broken_after_updating_kernel_to_611

Best regards,
Michael

#3 lore raw
Quoted 27 lines · Michael Laß

CC'ing amd-gfx as this might be an issue in the amd driver.

This change causes a regression in Linux 6.1 at least on some AMD APUs. There are reports from users with Ryzen 4750U, 5800U and 5850U chips where the HDMI sound devices don't show up anymore. I'm affected by this as well.

Reverting this commit (ef6f5494) makes the HDMI audio devices show up again. I verified that this is still an issue in current Linux git (72a85e2b).

Am Donnerstag, dem 22.09.2022 um 10:40 +0200 schrieb Jaroslav Kysela:

Quoted 10 lines
Quoted 10 lines

Per discussion on the alsa-devel mailing list [1], the legacy PIN to PCM device mapping is obsolete nowadays. The maximum number of the simultaneously usable PCM devices is equal to the HDMI codec converters.

Remove the extra PCM devices (beyond the detected converters) and force the use of the dynamic PCM device allocation. The legacy code is removed.

I believe that all HDMI codecs have the jack sensing feature. Move the check to the codec probe function and print a warning, if a codec without this feature is detected.

The corresponding message ("jack not detectable") is not shown on the affected system.

Quoted 7 lines
Quoted 1 line
Quoted 1 line

[1] https://lore.kernel.org/alsa-devel/[email protected]/

Links to some reports of this issue:
https://bugzilla.kernel.org/show_bug.cgi?id=216836
https://bbs.archlinux.org/viewtopic.php?pid=2075700
https://bugs.archlinux.org/task/76917
https://www.reddit.com/r/archlinux/comments/zsqq7i/hdmi_audio_is_broken_after_updating_kernel_to_611

Could you give alsa-info.sh outputs from both working and non-working cases? Run the script with --no-upload option during the playback of HDMI stream, and attach the outputs.

thanks,

Takashi

author maintainer
#4 lore raw
Quoted 37 lines · Takashi Iwai
Quoted 27 lines · Michael Laß

CC'ing amd-gfx as this might be an issue in the amd driver.

This change causes a regression in Linux 6.1 at least on some AMD APUs. There are reports from users with Ryzen 4750U, 5800U and 5850U chips where the HDMI sound devices don't show up anymore. I'm affected by this as well.

Reverting this commit (ef6f5494) makes the HDMI audio devices show up again. I verified that this is still an issue in current Linux git (72a85e2b).

Am Donnerstag, dem 22.09.2022 um 10:40 +0200 schrieb Jaroslav Kysela:

Quoted 10 lines
Quoted 10 lines

Per discussion on the alsa-devel mailing list [1], the legacy PIN to PCM device mapping is obsolete nowadays. The maximum number of the simultaneously usable PCM devices is equal to the HDMI codec converters.

Remove the extra PCM devices (beyond the detected converters) and force the use of the dynamic PCM device allocation. The legacy code is removed.

I believe that all HDMI codecs have the jack sensing feature. Move the check to the codec probe function and print a warning, if a codec without this feature is detected.

The corresponding message ("jack not detectable") is not shown on the affected system.

Quoted 7 lines
Quoted 1 line
Quoted 1 line

[1] https://lore.kernel.org/alsa-devel/[email protected]/

Links to some reports of this issue:
https://bugzilla.kernel.org/show_bug.cgi?id=216836
https://bbs.archlinux.org/viewtopic.php?pid=2075700
https://bugs.archlinux.org/task/76917
https://www.reddit.com/r/archlinux/comments/zsqq7i/hdmi_audio_is_broken_after_updating_kernel_to_611

Quoted 3 lines

Could you give alsa-info.sh outputs from both working and non-working cases? Run the script with --no-upload option during the playback of HDMI stream, and attach the outputs.

Jaroslav

Signature · 2 lines
Jaroslav Kysela <[email protected]>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.
#5 lore raw

Re: [PATCH] ALSA: hda/hdmi: Use only dynamic PCM device allocation #forregzbot

In reply to Michael Laß

[Note: this mail contains only information for Linux kernel regression tracking. Mails like these contain '#forregzbot' in the subject to make then easy to spot and filter out. The author also tried to remove most or all individuals from the list of recipients to spare them the hassle.]

Quoted 10 lines · Michael Laß

CC'ing amd-gfx as this might be an issue in the amd driver.

This change causes a regression in Linux 6.1 at least on some AMD APUs. There are reports from users with Ryzen 4750U, 5800U and 5850U chips where the HDMI sound devices don't show up anymore. I'm affected by this as well.

Reverting this commit (ef6f5494) makes the HDMI audio devices show up again. I verified that this is still an issue in current Linux git (72a85e2b).

Thanks for the report. To be sure below issue doesn't fall through the cracks unnoticed, I'm adding it to regzbot, my Linux kernel regression tracking bot:

#regzbot ^introduced ef6f5494faf6a37c74990689a
#regzbot title alsa: hda/hdmi: HDMI sound devices don't show up anymore with some AMD APUs
#regzbot ignore-activity

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)

P.S.: As the Linux kernel's regression tracker I deal with a lot of reports and sometimes miss something important when writing mails like this. If that's the case here, don't hesitate to tell me in a public reply, it's in everyone's interest to set the public record straight.

Quoted 25 lines

Am Donnerstag, dem 22.09.2022 um 10:40 +0200 schrieb Jaroslav Kysela:

Quoted 10 lines
Quoted 10 lines

Per discussion on the alsa-devel mailing list [1], the legacy PIN to PCM device mapping is obsolete nowadays. The maximum number of the simultaneously usable PCM devices is equal to the HDMI codec converters.

Remove the extra PCM devices (beyond the detected converters) and force the use of the dynamic PCM device allocation. The legacy code is removed.

I believe that all HDMI codecs have the jack sensing feature. Move the check to the codec probe function and print a warning, if a codec without this feature is detected.

The corresponding message ("jack not detectable") is not shown on the affected system.

Quoted 1 line
Quoted 1 line

[1] https://lore.kernel.org/alsa-devel/[email protected]/

Links to some reports of this issue:
https://bugzilla.kernel.org/show_bug.cgi?id=216836
https://bbs.archlinux.org/viewtopic.php?pid=2075700
https://bugs.archlinux.org/task/76917
https://www.reddit.com/r/archlinux/comments/zsqq7i/hdmi_audio_is_broken_after_updating_kernel_to_611

Best regards,
Michael

#6 lore raw

Re: [PATCH] ALSA: hda/hdmi: Use only dynamic PCM device allocation #forregzbot

[TLDR: This mail in primarily relevant for Linux kernel regression tracking. See link in footer if these mails annoy you.]

Quoted 12 lines · Thorsten Leemhuis
Quoted 10 lines · Michael Laß

CC'ing amd-gfx as this might be an issue in the amd driver.

This change causes a regression in Linux 6.1 at least on some AMD APUs. There are reports from users with Ryzen 4750U, 5800U and 5850U chips where the HDMI sound devices don't show up anymore. I'm affected by this as well.

Reverting this commit (ef6f5494) makes the HDMI audio devices show up again. I verified that this is still an issue in current Linux git (72a85e2b).

Quoted 8 lines

Thanks for the report. To be sure below issue doesn't fall through the cracks unnoticed, I'm adding it to regzbot, my Linux kernel regression tracking bot:

#regzbot ^introduced ef6f5494faf6a37c74990689a
#regzbot title alsa: hda/hdmi: HDMI sound devices don't show up anymore with some AMD APUs
#regzbot ignore-activity

#regzbot fix: 090ddad4c7a9
#regzbot ignore-activity

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) --
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
That page also explains what to do if mails like this annoy you.