Skip to contentSkip to conversation

ath11k: fix IRQ affinity warning on shutdown

PATCH In review Johan Hovold 3 participants 4 messages May 23, 2022 – May 30, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ath11k: fix IRQ affinity warning on shutdown

Make sure to clear the IRQ affinity hint also on shutdown to avoid triggering a WARN_ON_ONCE() in __free_irq() when stopping MHI while using a single MSI vector.

Fixes e94b07493da3 ("ath11k: Set IRQ affinity to CPU0 in case of one MSI vector")
---
 drivers/net/wireless/ath/ath11k/pci.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/net/wireless/ath/ath11k/pci.c +2 -0
index dedf1b88ddf6..487a303b3077 100644
@@ -920,7 +920,9 @@ static void ath11k_pci_remove(struct pci_dev *pdev)
 static void ath11k_pci_shutdown(struct pci_dev *pdev)
 {
 	struct ath11k_base *ab = pci_get_drvdata(pdev);
+	struct ath11k_pci *ab_pci = ath11k_pci_priv(ab);
 
+	ath11k_pci_set_irq_affinity_hint(ab_pci, NULL);
 	ath11k_pci_power_down(ab);
 }
 
Signature · 1 line
2.35.1
#1 lore raw
Quoted 3 lines · Johan Hovold

Make sure to clear the IRQ affinity hint also on shutdown to avoid triggering a WARN_ON_ONCE() in __free_irq() when stopping MHI while using a single MSI vector.

Forgot the tested-on tag, sorry.

Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3

Quoted 2 lines
Fixes e94b07493da3 ("ath11k: Set IRQ affinity to CPU0 in case of one MSI vector")

Let me know if I should resend.

Johan

#2 lore raw
Quoted 8 lines · Johan Hovold
Quoted 3 lines · Johan Hovold

Make sure to clear the IRQ affinity hint also on shutdown to avoid triggering a WARN_ON_ONCE() in __free_irq() when stopping MHI while using a single MSI vector.

Forgot the tested-on tag, sorry.

Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3

Thanks, added in the pending branch.

Quoted 4 lines
Quoted 2 lines
Fixes e94b07493da3 ("ath11k: Set IRQ affinity to CPU0 in case of one MSI vector")

Let me know if I should resend.

No need, I can easily edit commit logs.

Signature · 8 lines
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

-- 
ath11k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath11k
#3 lore raw
In reply to Johan Hovold
Quoted 9 lines · Johan Hovold

Make sure to clear the IRQ affinity hint also on shutdown to avoid triggering a WARN_ON_ONCE() in __free_irq() when stopping MHI while using a single MSI vector.

Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3

Fixes e94b07493da3 ("ath11k: Set IRQ affinity to CPU0 in case of one MSI vector")

Patch applied to ath-next branch of ath.git, thanks.

3bd0c69653ac ath11k: fix IRQ affinity warning on shutdown

Signature · 9 lines
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


-- 
ath11k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath11k