Skip to contentSkip to conversation

PCI: tegra: Don't rename the Tegra MSI interrupt

PATCH In review Jon Hunter 3 participants 3 messages Apr 20, 2021

Subsystems (4)
lore
Share & tools
lore

Jon Hunter

author maintainer
#0 lore raw

PATCH 1/1 PCI: tegra: Don't rename the Tegra MSI interrupt

Commit 973a28677e39 ("PCI: tegra: Convert to MSI domains") renamed the Tegra PCIe MSI interrupt from 'Tegra PCIe MSI' to 'tegra PCIe MSI'. This is breaking a PCIe sanity test that we are running on Tegra124 Jetson TK1 because it is looking for an interrupt called 'Tegra PCIe MSI' which is no longer found. Although we could update the test to fix this, at the same time it does not seem necessary to rename the interrupt. Therefore, change the name of the interrupt back to 'Tegra PCIe MSI'.

Fixes 973a28677e39 ("PCI: tegra: Convert to MSI domains")
---
 drivers/pci/controller/pci-tegra.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/controller/pci-tegra.c +1 -1
index eaba7b2fab4a..32ca16c87092 100644
@@ -1593,7 +1593,7 @@ static void tegra_msi_top_irq_unmask(struct irq_data *d)
 }
 
 static struct irq_chip tegra_msi_top_chip = {
-	.name		= "tegra PCIe MSI",
+	.name		= "Tegra PCIe MSI",
 	.irq_ack	= tegra_msi_top_irq_ack,
 	.irq_mask	= tegra_msi_top_irq_mask,
 	.irq_unmask	= tegra_msi_top_irq_unmask,
Signature · 1 line
2.25.1
Acked-by on v1 1/1
#1 lore raw
Quoted 20 lines · Jon Hunter

Commit 973a28677e39 ("PCI: tegra: Convert to MSI domains") renamed the Tegra PCIe MSI interrupt from 'Tegra PCIe MSI' to 'tegra PCIe MSI'. This is breaking a PCIe sanity test that we are running on Tegra124 Jetson TK1 because it is looking for an interrupt called 'Tegra PCIe MSI' which is no longer found. Although we could update the test to fix this, at the same time it does not seem necessary to rename the interrupt. Therefore, change the name of the interrupt back to 'Tegra PCIe MSI'.

Fixes 973a28677e39 ("PCI: tegra: Convert to MSI domains")
---
 drivers/pci/controller/pci-tegra.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/controller/pci-tegra.c +0 -0
index eaba7b2fab4a..32ca16c87092 100644

drivers/pci/controller/pci-tegra.c static void tegra_msi_top_irq_unmask(struct irq_data *d) · line 1599

Quoted 8 lines
drivers/pci/controller/pci-tegra.c +1 -1
@@ -1593,7 +1593,7 @@ static void tegra_msi_top_irq_unmask(struct irq_data *d)
 }
 
 static struct irq_chip tegra_msi_top_chip = {
-	.name		= "tegra PCIe MSI",
+	.name		= "Tegra PCIe MSI",
 	.irq_ack	= tegra_msi_top_irq_ack,
 	.irq_mask	= tegra_msi_top_irq_mask,
 	.irq_unmask	= tegra_msi_top_irq_unmask,

Ah, apologies for the spurious renaming. I always wondered if userspace would actually be parsing this, and it turns out that it is indeed the case.

	M.
Signature · 1 line
Without deviation from the norm, progress is not possible.
#2 lore raw
In reply to Jon Hunter
Quoted 8 lines · Jon Hunter

Commit 973a28677e39 ("PCI: tegra: Convert to MSI domains") renamed the Tegra PCIe MSI interrupt from 'Tegra PCIe MSI' to 'tegra PCIe MSI'. This is breaking a PCIe sanity test that we are running on Tegra124 Jetson TK1 because it is looking for an interrupt called 'Tegra PCIe MSI' which is no longer found. Although we could update the test to fix this, at the same time it does not seem necessary to rename the interrupt. Therefore, change the name of the interrupt back to 'Tegra PCIe MSI'.

Quoted 5 lines
Fixes 973a28677e39 ("PCI: tegra: Convert to MSI domains")
---
 drivers/pci/controller/pci-tegra.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Squashed with the Fixes: commit in my pci/msi branch, pushed out.

Thanks,
Lorenzo

Quoted 16 lines
drivers/pci/controller/pci-tegra.c +1 -1
index eaba7b2fab4a..32ca16c87092 100644
@@ -1593,7 +1593,7 @@ static void tegra_msi_top_irq_unmask(struct irq_data *d)
 }
 
 static struct irq_chip tegra_msi_top_chip = {
-	.name		= "tegra PCIe MSI",
+	.name		= "Tegra PCIe MSI",
 	.irq_ack	= tegra_msi_top_irq_ack,
 	.irq_mask	= tegra_msi_top_irq_mask,
 	.irq_unmask	= tegra_msi_top_irq_unmask,
Signature · 1 line
2.25.1