Skip to contentSkip to conversation

package/libfribidi: enable host build

PATCH New Peter Seiderer 3 participants 8 messages Dec 9, 2019 – Dec 23, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 package/libfribidi: enable host build

---
 package/libfribidi/libfribidi.mk | 1 +
 1 file changed, 1 insertion(+)
package/libfribidi/libfribidi.mk +1 -0
index 4394623592..0e17be6db0 100644
@@ -13,3 +13,4 @@ LIBFRIBIDI_INSTALL_STAGING = YES
 LIBFRIBIDI_DEPENDENCIES = host-pkgconf
 
 $(eval $(autotools-package))
+$(eval $(host-autotools-package))
Signature · 1 line
2.24.0
#1 lore raw

PATCH 2/2 package/pango: needs libfribidi

Fixes:
http://autobuild.buildroot.net/results/f16fda910da23dfe5f8ac1cb51f9dbcec444b516

subprocess.CalledProcessError: Command '['git', 'clone', 'https://github.com/fribidi/fribidi.git', 'fribidi']' returned non-zero exit status 128.

---
 package/pango/Config.in | 1 +
 package/pango/pango.mk  | 2 ++
 2 files changed, 3 insertions(+)
package/pango/Config.in +1 -0
index cdf8b54171..e810598eef 100644
@@ -7,6 +7,7 @@ config BR2_PACKAGE_PANGO
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # harfbuzz
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # harfbuzz
 	select BR2_PACKAGE_LIBGLIB2
+	select BR2_PACKAGE_LIBFRIBIDI
 	select BR2_PACKAGE_EXPAT
 	select BR2_PACKAGE_CAIRO
 	select BR2_PACKAGE_FONTCONFIG
package/pango/pango.mk +2 -0
index 33e7825896..48edd18b05 100644
@@ -19,6 +19,7 @@ PANGO_DEPENDENCIES = \
 	$(TARGET_NLS_DEPENDENCIES) \
 	host-pkgconf \
 	libglib2 \
+	libfribidi \
 	cairo \
 	harfbuzz \
 	fontconfig \
@@ -26,6 +27,7 @@ PANGO_DEPENDENCIES = \
 HOST_PANGO_DEPENDENCIES = \
 	host-pkgconf \
 	host-libglib2 \
+	host-libfribidi \
 	host-cairo \
 	host-harfbuzz \
 	host-fontconfig \
Signature · 1 line
2.24.0
#2 lore raw

PATCH 2/2 package/pango: needs libfribidi

Quoted 6 lines · On Mon, 9 Dec 2019 21:52:24 +0100 Peter Seiderer <[email protected]> wrote:

Fixes:
http://autobuild.buildroot.net/results/f16fda910da23dfe5f8ac1cb51f9dbcec444b516

subprocess.CalledProcessError: Command '['git', 'clone', 'https://github.com/fribidi/fribidi.git', 'fribidi']' returned non-zero exit status 128.

This commit title really was too short, especially we like to understand since when this problem is occurring. So I've added the following paragraph:

Since commit 5cce413eb11ac75f5c48ed351896c5d1c33961d5 ("package/pango:
bump to version 1.44.6"), pango needs libfribidi. Through the Meson subprojects mechanism, it tries to download it by itself if not available. But in Buildroot, we definitely want to use the separate libfribidi package, so let's add it as a dependency of pango.

A side question is: is here a way to tell Meson to never ever download subprojects by itself, and instead bail out loudly ?

I've applied with the improved commit log. Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#3 lore raw

PATCH 2/2 package/pango: needs libfribidi

Hello Thomas,

Quoted 14 lines · Thomas Petazzoni
Quoted 6 lines · On Mon, 9 Dec 2019 21:52:24 +0100 Peter Seiderer <[email protected]> wrote:

Fixes:
http://autobuild.buildroot.net/results/f16fda910da23dfe5f8ac1cb51f9dbcec444b516

subprocess.CalledProcessError: Command '['git', 'clone', 'https://github.com/fribidi/fribidi.git', 'fribidi']' returned non-zero exit status 128.

This commit title really was too short, especially we like to understand since when this problem is occurring. So I've added the following paragraph:

Quoted 5 lines

Since commit 5cce413eb11ac75f5c48ed351896c5d1c33961d5 ("package/pango:
bump to version 1.44.6"), pango needs libfribidi. Through the Meson subprojects mechanism, it tries to download it by itself if not available. But in Buildroot, we definitely want to use the separate libfribidi package, so let's add it as a dependency of pango.

+2

Quoted 3 lines

A side question is: is here a way to tell Meson to never ever download subprojects by itself, and instead bail out loudly ?

Will investigate...

Quoted 2 lines

I've applied with the improved commit log. Thanks!

Thanks.

Regards,
Peter

Quoted 2 lines

Thomas

#4 lore raw

PATCH 2/2 package/pango: needs libfribidi

Hello Thomas,

Quoted 6 lines
Quoted 3 lines

A side question is: is here a way to tell Meson to never ever download subprojects by itself, and instead bail out loudly ?

Will investigate...

According to the meson documentation ([1]) the options

--wrap-mode=nodownload
--wrap-mode=nofallback
--wrap-mode=forcefallback

are available, I think one of the first two would be useful (the second as default, the fist-one for special cases)?

Regards,
Peter

[1] https://mesonbuild.com/Subprojects.html#commandline-options

#5 lore raw

PATCH 2/2 package/pango: needs libfribidi

In reply to Peter Seiderer
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Peter" == Peter Seiderer <[email protected]> writes:

Fixes:
http://autobuild.buildroot.net/results/f16fda910da23dfe5f8ac1cb51f9dbcec444b516

subprocess.CalledProcessError: Command '['git', 'clone', 'https://github.com/fribidi/fribidi.git', 'fribidi']' returned non-zero exit status 128.

Committed to 2019.11.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard