Skip to contentSkip to conversation

package/python-brotli: fix build failure due to gcc bug 68485

PATCH New Giulio Benetti 3 participants 3 messages Dec 5, 2019 – Dec 7, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/python-brotli: fix build failure due to gcc bug 68485

The python-brotli package exhibits gcc bug 68485 when built for the Microblaze architecture with optimization enabled, which causes a build failure.

As done for other packages in Buildroot work around this gcc bug by setting optimization to -O0 if BR2_TOOLCHAIN_HAS_GCC_BUG_68485=y.

Fixes:

http://autobuild.buildroot.net/results/24b/24b23175ab27615fb377bb4d5f6c656dccf10a86/

---
 package/python-brotli/python-brotli.mk | 8 ++++++++
 1 file changed, 8 insertions(+)
package/python-brotli/python-brotli.mk +8 -0
index 745255f413..2ec549ed0c 100644
@@ -11,6 +11,14 @@ PYTHON_BROTLI_SETUP_TYPE = setuptools
 PYTHON_BROTLI_LICENSE = MIT
 PYTHON_BROTLI_LICENSE_FILES = LICENSE
 
+PYTHON_BROTLI_CFLAGS = $(TARGET_CFLAGS)
+
+ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_68485),y)
+PYTHON_BROTLI_CFLAGS += -O0
+endif
+
+PYTHON_BROTLI_ENV = CFLAGS="$(PYTHON_BROTLI_CFLAGS)"
+
 define PYTHON_BROTLI_EXTRACT_CMDS
 	$(UNZIP) -d $(@D) $(PYTHON_BROTLI_DL_DIR)/$(PYTHON_BROTLI_SOURCE)
 	mv $(@D)/Brotli-$(PYTHON_BROTLI_VERSION)/* $(@D)
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 package/python-brotli: fix build failure due to gcc bug 68485

Quoted 7 lines · On Thu, 5 Dec 2019 12:16:50 +0100 Giulio Benetti…

The python-brotli package exhibits gcc bug 68485 when built for the Microblaze architecture with optimization enabled, which causes a build failure.

As done for other packages in Buildroot work around this gcc bug by setting optimization to -O0 if BR2_TOOLCHAIN_HAS_GCC_BUG_68485=y.

Quoted 8 lines

Fixes:

http://autobuild.buildroot.net/results/24b/24b23175ab27615fb377bb4d5f6c656dccf10a86/

---
 package/python-brotli/python-brotli.mk | 8 ++++++++
 1 file changed, 8 insertions(+)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 package/python-brotli: fix build failure due to gcc bug 68485

In reply to Giulio Benetti
Quoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Giulio" == Giulio Benetti <[email protected]> writes:

The python-brotli package exhibits gcc bug 68485 when built for the Microblaze architecture with optimization enabled, which causes a build failure.

Quoted 8 lines

As done for other packages in Buildroot work around this gcc bug by setting optimization to -O0 if BR2_TOOLCHAIN_HAS_GCC_BUG_68485=y.

Fixes:

http://autobuild.buildroot.net/results/24b/24b23175ab27615fb377bb4d5f6c656dccf10a86/

Committed to 2019.11.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard