Skip to contentSkip to conversation

package/gstreamer1/gst1-plugins-base: fix dispmanx option

PATCH New Thomas Petazzoni 2 participants 2 messages Aug 17, 2019 – Aug 20, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/gstreamer1/gst1-plugins-base: fix dispmanx option

There is a typo in the handling of the BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL_DISPMANX option: we're adding dispmax to GST1_PLUGINS_BASE_WINSYS_LIST, which causes the following build failure:

meson.build:1:0: ERROR: Options "dispmax" are not in allowed choices: "x11, wayland, win32, cocoa, dispmanx, viv-fb, gbm, auto"

We fix this by using the proper option name, "dispmanx" instead of the slightly incorrect "dispmax".

---
 package/gstreamer1/gst1-plugins-base/gst1-plugins-base.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/gstreamer1/gst1-plugins-base/gst1-plugins-base.mk +1 -1
index 66c136c36c..90d2478bbc 100644
@@ -74,7 +74,7 @@ GST1_PLUGINS_BASE_DEPENDENCIES += wayland wayland-protocols
 endif
 
 ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL_DISPMANX),y)
-GST1_PLUGINS_BASE_WINSYS_LIST += dispmax
+GST1_PLUGINS_BASE_WINSYS_LIST += dispmanx
 GST1_PLUGINS_BASE_DEPENDENCIES += rpi-userland
 endif
 GST1_PLUGINS_BASE_CONF_OPTS += -Dgl_winsys='$(subst $(space),$(comma),$(GST1_PLUGINS_BASE_WINSYS_LIST))'
Signature · 1 line
2.21.0
#1 lore raw

PATCH 1/1 package/gstreamer1/gst1-plugins-base: fix dispmanx option

Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

There is a typo in the handling of the BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL_DISPMANX option: we're adding dispmax to GST1_PLUGINS_BASE_WINSYS_LIST, which causes the following build failure:

Quoted 6 lines

meson.build:1:0: ERROR: Options "dispmax" are not in allowed choices: "x11, wayland, win32, cocoa, dispmanx, viv-fb, gbm, auto"

We fix this by using the proper option name, "dispmanx" instead of the slightly incorrect "dispmax".

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard