Skip to contentSkip to conversation

package/netsurf: disallow on archs requiring ABI specific CFLAGS

PATCH New Peter Korsgaard 3 participants 6 messages May 31, 2019 – Jun 6, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/netsurf: disallow on archs requiring ABI specific CFLAGS

Fixes:
http://autobuild.buildroot.net/results/67ef520d82ea529a9fe593d83a3aeae5f8b0ee5d/
http://autobuild.buildroot.net/results/eafc3e4be571d5ecee549a11530ac4e508f31782/
http://autobuild.buildroot.net/results/ba7f30833fef54162a82f4b336a72d6599594526/

The netsurf build system mixes up host and target CFLAGS, so it isn't compatible with architectures where we pass ABI specicif compiler flags (in TARGET_ABI).

Add a _ARCH_SUPPORTS kconfig variable matching the TARGET_ABI logic we have in package/Makefile.in, and use it to disallow netsurf for those architectures.

---
 package/netsurf/Config.in | 10 ++++++++++
 1 file changed, 10 insertions(+)
package/netsurf/Config.in +10 -0
index 30b2695309..4f7d5c2713 100644
@@ -1,10 +1,20 @@
+# netsurf mixes up host and target CFLAGS, so it isn't compatible with
+# architectures where we pass ABI specific compiler flags (TARGET_ABI)
+config BR2_PACKAGE_NETSURF_ARCH_SUPPORTS
+	bool
+	default y if !((BR2_arc && BR2_ARC_ATOMIC_EXT) || \
+		BR2_powerpc_8540 || BR2_powerpc_8548 || BR2_powerpc_e500mc || \
+		BR2_xtensa)
+
 comment "netsurf needs a toolchain w/ dynamic library"
 	depends on BR2_STATIC_LIBS
+	depends on BR2_PACKAGE_NETSURF_ARCH_SUPPORTS
 
 config BR2_PACKAGE_NETSURF
 	bool "netsurf"
 	# static linking support is broken beyond repair
 	depends on !BR2_STATIC_LIBS
+	depends on BR2_PACKAGE_NETSURF_ARCH_SUPPORTS
 	select BR2_PACKAGE_EXPAT
 	select BR2_PACKAGE_JPEG
 	select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE
Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/1 package/netsurf: disallow on archs requiring ABI specific CFLAGS

Am Fri, 31 May 2019 23:40:52 +0200
schrieb Peter Korsgaard <[email protected]>:

Quoted 7 lines

Fixes:
http://autobuild.buildroot.net/results/67ef520d82ea529a9fe593d83a3aeae5f8b0ee5d/
http://autobuild.buildroot.net/results/eafc3e4be571d5ecee549a11530ac4e508f31782/
http://autobuild.buildroot.net/results/ba7f30833fef54162a82f4b336a72d6599594526/

The netsurf build system mixes up host and target CFLAGS, so it isn't compatible with architectures where we pass ABI specicif compiler

s/specicif/specific/ please.

Quoted 23 lines

flags (in TARGET_ABI).

Add a _ARCH_SUPPORTS kconfig variable matching the TARGET_ABI logic we have in package/Makefile.in, and use it to disallow netsurf for those architectures.

---
 package/netsurf/Config.in | 10 ++++++++++
 1 file changed, 10 insertions(+)
package/netsurf/Config.in +1 -0
index 30b2695309..4f7d5c2713 100644
@@ -1,10 +1,20 @@
+# netsurf mixes up host and target CFLAGS, so it isn't compatible

with +# architectures where we pass ABI specific compiler flags (TARGET_ABI) +config BR2_PACKAGE_NETSURF_ARCH_SUPPORTS

package/netsurf/Config.in +3 -0
+	bool
+	default y if !((BR2_arc && BR2_ARC_ATOMIC_EXT) || \
+		BR2_powerpc_8540 || BR2_powerpc_8548 ||

BR2_powerpc_e500mc || \

package/netsurf/Config.in line 11

Quoted 5 lines
package/netsurf/Config.in +3 -0
+		BR2_xtensa)
+
 comment "netsurf needs a toolchain w/ dynamic library"
 	depends on BR2_STATIC_LIBS
+	depends on BR2_PACKAGE_NETSURF_ARCH_SUPPORTS

First, the comment is now not accurate anymore. It should also say something about the architectures where it is not available.

Then the logic below says that PACKAGE_NETSURF depends on "!STATIC_LIBS *AND* NETSURF_ARCH_SUPPORT". The dependency of the comment above is inverted, so I think this rather should be:

       depends on BR2_STATIC_LIBS || !BR2_PACKAGE_NETSURF_ARCH_SUPPORTS

?

package/netsurf/Config.in line 20

Quoted 8 lines

config BR2_PACKAGE_NETSURF

package/netsurf/Config.in +1 -0
 	bool "netsurf"
 	# static linking support is broken beyond repair
 	depends on !BR2_STATIC_LIBS
+	depends on BR2_PACKAGE_NETSURF_ARCH_SUPPORTS
 	select BR2_PACKAGE_EXPAT
 	select BR2_PACKAGE_JPEG
 	select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE

Thomas H

#2 lore raw

PATCH 1/1 package/netsurf: disallow on archs requiring ABI specific CFLAGS

Hello,

Quoted 6 lines · On Sat, 1 Jun 2019 07:33:51 +0200 Thomas Huth <[email protected]> wrote:

Review

Quoted 3 lines

comment "netsurf needs a toolchain w/ dynamic library"

(quoted diff) +1 -0
 	depends on BR2_STATIC_LIBS
+	depends on BR2_PACKAGE_NETSURF_ARCH_SUPPORTS  

First, the comment is now not accurate anymore. It should also say something about the architectures where it is not available.

No, we never put comments about architecture dependencies, because there's nothing the user can do about it.

Quoted 5 lines

Then the logic below says that PACKAGE_NETSURF depends on "!STATIC_LIBS *AND* NETSURF_ARCH_SUPPORT". The dependency of the comment above is inverted, so I think this rather should be:

       depends on BR2_STATIC_LIBS || !BR2_PACKAGE_NETSURF_ARCH_SUPPORTS

No, because we precisely don't want the comment to show up when we're on an architecture that cannot support the package.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#3 lore raw

PATCH 1/1 package/netsurf: disallow on archs requiring ABI specific CFLAGS

In reply to Peter Korsgaard

Hello,

Quoted 9 lines · On Fri, 31 May 2019 23:40:52 +0200 Peter Korsgaard <[email protected]> wrote:

Fixes:
http://autobuild.buildroot.net/results/67ef520d82ea529a9fe593d83a3aeae5f8b0ee5d/
http://autobuild.buildroot.net/results/eafc3e4be571d5ecee549a11530ac4e508f31782/
http://autobuild.buildroot.net/results/ba7f30833fef54162a82f4b336a72d6599594526/

The netsurf build system mixes up host and target CFLAGS, so it isn't compatible with architectures where we pass ABI specicif compiler flags (in TARGET_ABI).

Quoted 5 lines

Add a _ARCH_SUPPORTS kconfig variable matching the TARGET_ABI logic we have in package/Makefile.in, and use it to disallow netsurf for those architectures.

I understand the idea, but we need to realize it has some drawbacks:

- If we add additional flags for some architecture, this will have to be updated.

- If some custom flags are passed in BR2_TARGET_OPTIMIZATION, I would assume it would also cause a build failure, no ?

If we really can't remove the package, then I'm fine with this patch as a stop-gap measure. But I think removing the package is the sanest thing to do. If anything, removing the package might wake up the people using it so that they fix it.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#4 lore raw

PATCH 1/1 package/netsurf: disallow on archs requiring ABI specific CFLAGS

Quoted 19 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Hello,

Quoted 13 lines · On Fri, 31 May 2019 23:40:52 +0200 Peter Korsgaard <[email protected]> wrote:

Fixes:
http://autobuild.buildroot.net/results/67ef520d82ea529a9fe593d83a3aeae5f8b0ee5d/
http://autobuild.buildroot.net/results/eafc3e4be571d5ecee549a11530ac4e508f31782/
http://autobuild.buildroot.net/results/ba7f30833fef54162a82f4b336a72d6599594526/

The netsurf build system mixes up host and target CFLAGS, so it isn't compatible with architectures where we pass ABI specicif compiler flags (in TARGET_ABI).

Add a _ARCH_SUPPORTS kconfig variable matching the TARGET_ABI logic we have in package/Makefile.in, and use it to disallow netsurf for those architectures.

Quoted 6 lines
Quoted 1 line

I understand the idea, but we need to realize it has some drawbacks:

- If we add additional flags for some architecture, this will have to be updated.

Correct, but the autobuilders will presumably show us pretty fast.

Quoted 2 lines

- If some custom flags are passed in BR2_TARGET_OPTIMIZATION, I would assume it would also cause a build failure, no ?

Yes - If they are ABI specific, E.G. not understood by the host compiler.

Quoted 4 lines

If we really can't remove the package, then I'm fine with this patch as a stop-gap measure. But I think removing the package is the sanest thing to do. If anything, removing the package might wake up the people using it so that they fix it.

I agree, I only created this patch as there was pushback on IRC against removing netsurf this close to the release.

I'll apply this for master and then revisit the removal once we have next merged.

Signature · 1 line
Bye, Peter Korsgaard
#5 lore raw

PATCH 1/1 package/netsurf: disallow on archs requiring ABI specific CFLAGS

In reply to Peter Korsgaard
Quoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Peter" == Peter Korsgaard <[email protected]> writes:

Fixes:
http://autobuild.buildroot.net/results/67ef520d82ea529a9fe593d83a3aeae5f8b0ee5d/
http://autobuild.buildroot.net/results/eafc3e4be571d5ecee549a11530ac4e508f31782/
http://autobuild.buildroot.net/results/ba7f30833fef54162a82f4b336a72d6599594526/

The netsurf build system mixes up host and target CFLAGS, so it isn't compatible with architectures where we pass ABI specicif compiler flags (in TARGET_ABI).

Quoted 5 lines

Add a _ARCH_SUPPORTS kconfig variable matching the TARGET_ABI logic we have in package/Makefile.in, and use it to disallow netsurf for those architectures.

Committed to 2019.02.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard