Skip to contentSkip to conversation

package/musl: remove rcrt1.o from target installation

PATCH New Norbert Lange 3 participants 6 messages Mar 6, 2019 – Mar 25, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/musl: remove rcrt1.o from target installation

From: Norbert Lange <[email protected]>

---
 package/musl/musl.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/musl/musl.mk +1 -1
index 90c753926e..ff807c0cba 100644
@@ -58,7 +58,7 @@ endef
 define MUSL_INSTALL_TARGET_CMDS
 	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) \
 		DESTDIR=$(TARGET_DIR) install-libs
-	$(RM) $(addprefix $(TARGET_DIR)/lib/,crt1.o crtn.o crti.o Scrt1.o)
+	$(RM) $(addprefix $(TARGET_DIR)/lib/,crt1.o crtn.o crti.o rcrt1.o Scrt1.o)
 endef
 
 $(eval $(generic-package))
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 package/musl: remove rcrt1.o from target installation

Hello Norbert,

Thanks for your patch!

Quoted 3 lines · On Wed, 6 Mar 2019 17:33:16 +0100 Norbert Lange <[email protected]> wrote:

From: Norbert Lange <[email protected]>

Could you give some more details ?

In fact, your patch does not remove rcrt1.o from target installation:
it ensures that the target installation does *NOT* remove it from TARGET_DIR.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 package/musl: remove rcrt1.o from target installation

Quoted 2 lines

Could you give some more details ?

rcrt1.o is a new startup for "static-pie" apps, and only needed for building,
should not end up in the target filesystem

Quoted 4 lines

In fact, your patch does not remove rcrt1.o from target installation:
it ensures that the target installation does *NOT* remove it from TARGET_DIR.

One of us is eligible for a legasthenic fund, either its you or I am a really badly affected cause I still cant find a fault in the patch.

Norbert

#3 lore raw

PATCH 1/1 package/musl: remove rcrt1.o from target installation

Hello Norbert,

Quoted 5 lines · On Wed, 6 Mar 2019 18:09:19 +0100 Norbert Lange <[email protected]> wrote:
Quoted 1 line

Could you give some more details ?

rcrt1.o is a new startup for "static-pie" apps, and only needed for building,
should not end up in the target filesystem

OK.

Quoted 6 lines
Quoted 3 lines

In fact, your patch does not remove rcrt1.o from target installation:
it ensures that the target installation does *NOT* remove it from TARGET_DIR.

One of us is eligible for a legasthenic fund, either its you or I am a really badly affected cause I still cant find a fault in the patch.

It was me :-) The patch looks good!

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#4 lore raw

PATCH 1/1 package/musl: remove rcrt1.o from target installation

In reply to Norbert Lange
Quoted 8 lines
Quoted 4 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Norbert" == Norbert Lange <[email protected]> writes:

Could you give some more details ?

rcrt1.o is a new startup for "static-pie" apps, and only needed for building,
should not end up in the target filesystem

Committed to 2019.02.x after adding this description, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#5 lore raw

PATCH 1/1 package/musl: remove rcrt1.o from target installation

In reply to Norbert Lange
Quoted 6 lines · On Wed, 6 Mar 2019 17:33:16 +0100 Norbert Lange <[email protected]> wrote:

From: Norbert Lange <[email protected]>

---
 package/musl/musl.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com