package/optee-client: depends on thread support
PATCH 1/1 package/optee-client: depends on thread support
BR2_PACKAGE_OPTEE_CLIENT depends on BR2_TOOLCHAIN_HAS_THREADS. Library teec uses pthread support to protect clients state management. This change declares this dependency in the package.
Fixes [1] that set an toolchain without thread support and failed to build with trace:
CMake Error at /home/buildroot/autobuild/run/instance-1/output/host/share/cmake-3.8/Modules/FindPackageHandleStandardArgs.cmake:137 (message):
Could NOT find Threads (missing: Threads_FOUND)
Call Stack (most recent call first):
/home/buildroot/autobuild/run/instance-1/output/host/share/cmake-3.8/Modules/FindPackageHandleStandardArgs.cmake:377 (_FPHSA_FAILURE_MESSAGE) /home/buildroot/autobuild/run/instance-1/output/host/share/cmake-3.8/Modules/FindThreads.cmake:212 (FIND_PACKAGE_HANDLE_STANDARD_ARGS) libteec/CMakeLists.txt:8 (find_package)
[1] https://autobuild.buildroot.net/results/ed6ffe2197da4f3a970bd3c5522291236396cc8e
--- package/optee-client/Config.in | 1 + 1 file changed, 1 insertion(+)
package/optee-client/Config.in +1 -0
@@ -1,6 +1,7 @@ config BR2_PACKAGE_OPTEE_CLIENT bool "optee-client" depends on !BR2_STATIC_LIBS + depends on BR2_TOOLCHAIN_HAS_THREADS help Enable the OP-TEE client package that brings non-secure client application resources for OP-TEE support. OP-TEE
Signature · 1 line
1.9.1
PATCH 1/1 package/optee-client: depends on thread support
Hi Etienne,
Quoted 26 lines · Etienne Carriere
BR2_PACKAGE_OPTEE_CLIENTdepends onBR2_TOOLCHAIN_HAS_THREADS. Library teec uses pthread support to protect clients state management. This change declares this dependency in the package.Fixes [1] that set an toolchain without thread support and failed to build with trace:
CMake Error at
/home/buildroot/autobuild/run/instance-1/output/host/share/cmake-3.8/Modules/FindPackageHandleStandardArgs.cmake:137(message):
Could NOT find Threads (missing:Threads_FOUND)
Call Stack (most recent call first):
/home/buildroot/autobuild/run/instance-1/output/host/share/cmake-3.8/Modules/FindPackageHandleStandardArgs.cmake:377(_FPHSA_FAILURE_MESSAGE)/home/buildroot/autobuild/run/instance-1/output/host/share/cmake-3.8/Modules/FindThreads.cmake:212(FIND_PACKAGE_HANDLE_STANDARD_ARGS)libteec/CMakeLists.txt:8(find_package)[1] https://autobuild.buildroot.net/results/ed6ffe2197da4f3a970bd3c5522291236396cc8e
Signed-off-by Etienne Carriere <[email protected]>--- package/optee-client/Config.in | 1 + 1 file changed, 1 insertion(+)package/optee-client/Config.in +0
-0
package/optee-client/Config.in line 4
Quoted 4 lines
package/optee-client/Config.in +1
-0@@ -1,6 +1,7 @@ config BR2_PACKAGE_OPTEE_CLIENT bool "optee-client" depends on !BR2_STATIC_LIBS + depends on BR2_TOOLCHAIN_HAS_THREADS
You need to propagate this added dependencies to packages that select optee-client recursively. These are currently optee-test and optee-benchmark.
You should also update the dependencies commit below, and in all other packages you update.
baruch
package/optee-client/Config.in line 7
Quoted 3 lines
package/optee-client/Config.in +0
-0help Enable the OP-TEE client package that brings non-secure client application resources for OP-TEE support. OP-TEE
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
PATCH 1/1 package/optee-client: depends on thread support
Hello Baruch,
Quoted 39 lines · Baruch Siach
Hi Etienne,
Quoted 26 lines · Etienne Carriere
BR2_PACKAGE_OPTEE_CLIENTdepends onBR2_TOOLCHAIN_HAS_THREADS. Library teec uses pthread support to protect clients state management. This change declares this dependency in the package.Fixes [1] that set an toolchain without thread support and failed to build with trace:
CMake Error at
/home/buildroot/autobuild/run/instance-1/output/host/share/cmake-3.8/Modules/FindPackageHandleStandardArgs.cmake:137(message):
Could NOT find Threads (missing:Threads_FOUND)
Call Stack (most recent call first):
/home/buildroot/autobuild/run/instance-1/output/host/share/cmake-3.8/Modules/FindPackageHandleStandardArgs.cmake:377(_FPHSA_FAILURE_MESSAGE)/home/buildroot/autobuild/run/instance-1/output/host/share/cmake-3.8/Modules/FindThreads.cmake:212(FIND_PACKAGE_HANDLE_STANDARD_ARGS)libteec/CMakeLists.txt:8(find_package)[1] https://autobuild.buildroot.net/results/ed6ffe2197da4f3a970bd3c5522291236396cc8e
Signed-off-by Etienne Carriere <[email protected]>--- package/optee-client/Config.in | 1 + 1 file changed, 1 insertion(+)package/optee-client/Config.in +0
-0package/optee-client/Config.in line 4
Quoted 4 lines
package/optee-client/Config.in +1
-0@@ -1,6 +1,7 @@ config BR2_PACKAGE_OPTEE_CLIENT bool "optee-client" depends on !BR2_STATIC_LIBS + depends on BR2_TOOLCHAIN_HAS_THREADSYou need to propagate this added dependencies to packages that select optee-client recursively. These are currently optee-test and optee-benchmark.
Quoted 2 lines
You should also update the dependencies commit below, and in all other packages you update.
Ok thanks a lot, I will send a v2 series.
etienne
Quoted 11 lines
baruch
package/optee-client/Config.in line 7
Quoted 3 lines
package/optee-client/Config.in +0
-0help Enable the OP-TEE client package that brings non-secure client application resources for OP-TEE support. OP-TEE--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
PATCH v2 1/4 package/optee-client: depends on thread support
In reply to Etienne CarriereBR2_PACKAGE_OPTEE_CLIENT depends on BR2_TOOLCHAIN_HAS_THREADS. Library teec uses pthread support to protect clients state management. This change declares this dependency in the package.
Fixes [1] and [2] where config selected an toolchain without thread support and build failed with trace like:
CMake Error at /home/buildroot/autobuild/run/instance-1/output/host/share/cmake-3.8/Modules/FindPackageHandleStandardArgs.cmake:137 (message):
Could NOT find Threads (missing: Threads_FOUND)
Call Stack (most recent call first):
/home/buildroot/autobuild/run/instance-1/output/host/share/cmake-3.8/Modules/FindPackageHandleStandardArgs.cmake:377 (_FPHSA_FAILURE_MESSAGE) /home/buildroot/autobuild/run/instance-1/output/host/share/cmake-3.8/Modules/FindThreads.cmake:212 (FIND_PACKAGE_HANDLE_STANDARD_ARGS) libteec/CMakeLists.txt:8 (find_package)
[1] http://autobuild.buildroot.net/results/ed6ffe2197da4f3a970bd3c5522291236396cc8e
[2] http://autobuild.buildroot.net/results/406f90048db097580b626ef889823132f8676ba1
---
Changes v1 -> v2:
- No change. v2 appends changes to this change to propagate the optee-client dependency on threads to packages dependent on optee-client.
--- package/optee-client/Config.in | 1 + 1 file changed, 1 insertion(+)
package/optee-client/Config.in +1 -0
@@ -1,6 +1,7 @@ config BR2_PACKAGE_OPTEE_CLIENT bool "optee-client" depends on !BR2_STATIC_LIBS + depends on BR2_TOOLCHAIN_HAS_THREADS help Enable the OP-TEE client package that brings non-secure client application resources for OP-TEE support. OP-TEE
Signature · 1 line
1.9.1
PATCH v2 2/4 package/optee-benchmark: thread dependency from optee-client
Propagate dependency on BR2_TOOLCHAIN_HAS_THREADS inherited from optee-client this package depends on.
---
Changes v1 -> v2:
- New patch in the series. v2 propagates the optee-client dependency on threads to packages dependent on optee-client.
--- package/optee-benchmark/Config.in | 1 + 1 file changed, 1 insertion(+)
package/optee-benchmark/Config.in +1 -0
@@ -1,6 +1,7 @@ config BR2_PACKAGE_OPTEE_BENCHMARK bool "optee-benchmark" depends on !BR2_STATIC_LIBS # optee-client + depends on BR2_TOOLCHAIN_HAS_THREADS # optee-client select BR2_PACKAGE_OPTEE_CLIENT select BR2_PACKAGE_LIBYAML help
Signature · 1 line
1.9.1
PATCH v2 3/4 package/optee-examples: thread dependency from optee-client
In reply to Etienne CarrierePropagate dependency on BR2_TOOLCHAIN_HAS_THREADS inherited from optee-client this package depends on.
---
Changes v1 -> v2:
- New patch in the series. v2 propagates the optee-client dependency on threads to packages dependent on optee-client.
--- package/optee-examples/Config.in | 1 + 1 file changed, 1 insertion(+)
package/optee-examples/Config.in +1 -0
@@ -2,6 +2,7 @@ config BR2_PACKAGE_OPTEE_EXAMPLES bool "optee-examples" depends on BR2_TARGET_OPTEE_OS depends on !BR2_STATIC_LIBS # optee-client + depends on BR2_TOOLCHAIN_HAS_THREADS # optee-client select BR2_PACKAGE_OPTEE_CLIENT select BR2_TARGET_OPTEE_OS_SDK help
Signature · 1 line
1.9.1
PATCH v2 4/4 package/optee-test: thread dependency from optee-client
In reply to Etienne CarrierePropagate dependency on BR2_TOOLCHAIN_HAS_THREADS inherited from optee-client this package depends on.
---
Changes v1 -> v2:
- New patch in the series. v2 propagates the optee-client dependency on threads to packages dependent on optee-client.
--- package/optee-test/Config.in | 1 + 1 file changed, 1 insertion(+)
package/optee-test/Config.in +1 -0
@@ -2,6 +2,7 @@ config BR2_PACKAGE_OPTEE_TEST bool "optee-test" depends on BR2_TARGET_OPTEE_OS depends on !BR2_STATIC_LIBS # optee-client + depends on BR2_TOOLCHAIN_HAS_THREADS # optee-client select BR2_PACKAGE_OPTEE_CLIENT select BR2_TARGET_OPTEE_OS_SDK help
Signature · 1 line
1.9.1
PATCH v2 1/4 package/optee-client: depends on thread support
In reply to Etienne CarriereHi Etienne,
Quoted 14 lines · Etienne Carriere
BR2_PACKAGE_OPTEE_CLIENTdepends onBR2_TOOLCHAIN_HAS_THREADS. Library teec uses pthread support to protect clients state management. This change declares this dependency in the package.Fixes [1] and [2] where config selected an toolchain without thread support and build failed with trace like:
CMake Error at
/home/buildroot/autobuild/run/instance-1/output/host/share/cmake-3.8/Modules/FindPackageHandleStandardArgs.cmake:137(message):
Could NOT find Threads (missing:Threads_FOUND)
Call Stack (most recent call first):
/home/buildroot/autobuild/run/instance-1/output/host/share/cmake-3.8/Modules/FindPackageHandleStandardArgs.cmake:377(_FPHSA_FAILURE_MESSAGE)/home/buildroot/autobuild/run/instance-1/output/host/share/cmake-3.8/Modules/FindThreads.cmake:212(FIND_PACKAGE_HANDLE_STANDARD_ARGS)libteec/CMakeLists.txt:8(find_package)
Quoted 8 lines
[1] http://autobuild.buildroot.net/results/ed6ffe2197da4f3a970bd3c5522291236396cc8e
[2] http://autobuild.buildroot.net/results/406f90048db097580b626ef889823132f8676ba1Signed-off-by Etienne Carriere <[email protected]>---
Changes v1 -> v2:
- No change. v2 appends changes to this change to propagate the optee-client dependency on threads to packages dependent on optee-client.
All patches in this series should be squashed into a single patch. Otherwise the build is broken between patch #1 and others. This hurts the so called bisectability of git history.
In addition, this patch (and others) are missing update to dependencies comments to account for the added dependency.
baruch
Quoted 9 lines
--- package/optee-client/Config.in | 1 + 1 file changed, 1 insertion(+)package/optee-client/Config.in +0
-0
package/optee-client/Config.in line 7
Quoted 7 lines
package/optee-client/Config.in +1
-0@@ -1,6 +1,7 @@ config BR2_PACKAGE_OPTEE_CLIENT bool "optee-client" depends on !BR2_STATIC_LIBS + depends on BR2_TOOLCHAIN_HAS_THREADS help Enable the OP-TEE client package that brings non-secure client application resources for OP-TEE support. OP-TEE
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
PATCH v2 1/4 package/optee-client: depends on thread support
Quoted 28 lines · Baruch Siach
Hi Etienne,
Quoted 14 lines · Etienne Carriere
BR2_PACKAGE_OPTEE_CLIENTdepends onBR2_TOOLCHAIN_HAS_THREADS. Library teec uses pthread support to protect clients state management. This change declares this dependency in the package.Fixes [1] and [2] where config selected an toolchain without thread support and build failed with trace like:
CMake Error at
/home/buildroot/autobuild/run/instance-1/output/host/share/cmake-3.8/Modules/FindPackageHandleStandardArgs.cmake:137(message):
Could NOT find Threads (missing:Threads_FOUND)
Call Stack (most recent call first):
/home/buildroot/autobuild/run/instance-1/output/host/share/cmake-3.8/Modules/FindPackageHandleStandardArgs.cmake:377(_FPHSA_FAILURE_MESSAGE)/home/buildroot/autobuild/run/instance-1/output/host/share/cmake-3.8/Modules/FindThreads.cmake:212(FIND_PACKAGE_HANDLE_STANDARD_ARGS)libteec/CMakeLists.txt:8(find_package)Quoted 8 lines
[1] http://autobuild.buildroot.net/results/ed6ffe2197da4f3a970bd3c5522291236396cc8e
[2] http://autobuild.buildroot.net/results/406f90048db097580b626ef889823132f8676ba1Signed-off-by Etienne Carriere <[email protected]>---
Changes v1 -> v2:
- No change. v2 appends changes to this change to propagate the optee-client dependency on threads to packages dependent on optee-client.
Quoted 3 lines
All patches in this series should be squashed into a single patch. Otherwise the build is broken between patch #1 and others. This hurts the so called bisectability of git history.
Ok. So I'll squash them.
Quoted 3 lines
In addition, this patch (and others) are missing update to dependencies comments to account for the added dependency.
Oh yes! I forgot to update those comment.
Thanks.
By the way, this change will conflict with pending
http://patchwork.ozlabs.org/patch/1050302/ and its 3 related companions.
I should maybe setup a series for the whole.
Thanks for the feedback.
Regards,
etienne
Quoted 24 lines
baruch
Quoted 9 lines
--- package/optee-client/Config.in | 1 + 1 file changed, 1 insertion(+)package/optee-client/Config.in +0
-0package/optee-client/Config.in line 7
Quoted 7 lines
package/optee-client/Config.in +1
-0@@ -1,6 +1,7 @@ config BR2_PACKAGE_OPTEE_CLIENT bool "optee-client" depends on !BR2_STATIC_LIBS + depends on BR2_TOOLCHAIN_HAS_THREADS help Enable the OP-TEE client package that brings non-secure client application resources for OP-TEE support. OP-TEE--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
PATCH v3 1/1 package/optee-*: packages depend on thread support
In reply to Etienne CarriereBR2_PACKAGE_OPTEE_CLIENT depends on BR2_TOOLCHAIN_HAS_THREADS. Library teec uses pthread support to protect clients state management.
This change declares this dependency in package optee-client and updates dependent packages accordingly: optee-benchmark, optee-client, optee-examples and optee-test.
Fixes [1] and [2] where config selected an toolchain without thread support and build failed with trace like:
CMake Error at /home/buildroot/autobuild/run/instance-1/output/host/share/cmake-3.8/Modules/FindPackageHandleStandardArgs.cmake:137 (message):
Could NOT find Threads (missing: Threads_FOUND)
Call Stack (most recent call first):
/home/buildroot/autobuild/run/instance-1/output/host/share/cmake-3.8/Modules/FindPackageHandleStandardArgs.cmake:377 (_FPHSA_FAILURE_MESSAGE) /home/buildroot/autobuild/run/instance-1/output/host/share/cmake-3.8/Modules/FindThreads.cmake:212 (FIND_PACKAGE_HANDLE_STANDARD_ARGS) libteec/CMakeLists.txt:8 (find_package)
[1] http://autobuild.buildroot.net/results/ed6ffe2197da4f3a970bd3c5522291236396cc8e
[2] http://autobuild.buildroot.net/results/406f90048db097580b626ef889823132f8676ba1
---
Changes v2 -> v3:
- Squash v2 series into a single patch.
- Update config comment for unmet dependencies.
Changes v1 -> v2:
- No change. v2 appends changes to this change to propagate the optee-client dependency on threads to packages dependent on optee-client.
--- package/optee-benchmark/Config.in | 4 +++- package/optee-client/Config.in | 4 +++- package/optee-examples/Config.in | 4 +++- package/optee-test/Config.in | 4 +++- 4 files changed, 12 insertions(+), 4 deletions(-)
package/optee-benchmark/Config.in +3 -1
@@ -1,6 +1,7 @@ config BR2_PACKAGE_OPTEE_BENCHMARK bool "optee-benchmark" depends on !BR2_STATIC_LIBS # optee-client + depends on BR2_TOOLCHAIN_HAS_THREADS # optee-client select BR2_PACKAGE_OPTEE_CLIENT select BR2_PACKAGE_LIBYAML help
@@ -11,5 +12,6 @@ config BR2_PACKAGE_OPTEE_BENCHMARK http://github.com/linaro-swg/optee_benchmark -comment "optee-benchmark needs a toolchain w/ dynamic library" +comment "optee-benchmark needs a toolchain w/ dynamic library and threads" depends on BR2_STATIC_LIBS + depends on !BR2_TOOLCHAIN_HAS_THREADS
package/optee-client/Config.in +3 -1
@@ -1,6 +1,7 @@ config BR2_PACKAGE_OPTEE_CLIENT bool "optee-client" depends on !BR2_STATIC_LIBS + depends on BR2_TOOLCHAIN_HAS_THREADS help Enable the OP-TEE client package that brings non-secure client application resources for OP-TEE support. OP-TEE
@@ -13,5 +14,6 @@ config BR2_PACKAGE_OPTEE_CLIENT https://github.com/OP-TEE/optee_client -comment "optee-client needs a toolchain w/ dynamic library" +comment "optee-client needs a toolchain w/ dynamic library and threads" depends on BR2_STATIC_LIBS + depends on !BR2_TOOLCHAIN_HAS_THREADS
package/optee-examples/Config.in +3 -1
@@ -2,6 +2,7 @@ config BR2_PACKAGE_OPTEE_EXAMPLES bool "optee-examples" depends on BR2_TARGET_OPTEE_OS depends on !BR2_STATIC_LIBS # optee-client + depends on BR2_TOOLCHAIN_HAS_THREADS # optee-client select BR2_PACKAGE_OPTEE_CLIENT select BR2_TARGET_OPTEE_OS_SDK help
@@ -18,6 +19,7 @@ config BR2_PACKAGE_OPTEE_EXAMPLES https://github.com/linaro-swg/optee_examples -comment "optee-examples needs a toolchain w/ dynamic library" +comment "optee-examples needs a toolchain w/ dynamic library and threads" depends on BR2_TARGET_OPTEE_OS depends on BR2_STATIC_LIBS + depends on !BR2_TOOLCHAIN_HAS_THREADS
package/optee-test/Config.in +3 -1
@@ -2,6 +2,7 @@ config BR2_PACKAGE_OPTEE_TEST bool "optee-test" depends on BR2_TARGET_OPTEE_OS depends on !BR2_STATIC_LIBS # optee-client + depends on BR2_TOOLCHAIN_HAS_THREADS # optee-client select BR2_PACKAGE_OPTEE_CLIENT select BR2_TARGET_OPTEE_OS_SDK help
@@ -22,6 +23,7 @@ config BR2_PACKAGE_OPTEE_TEST http://github.com/OP-TEE/optee_test -comment "optee-test needs a toolchain w/ dynamic library" +comment "optee-test needs a toolchain w/ dynamic library and threads" depends on BR2_TARGET_OPTEE_OS depends on BR2_STATIC_LIBS + depends on !BR2_TOOLCHAIN_HAS_THREADS
Signature · 1 line
1.9.1
PATCH v3 1/1 package/optee-*: packages depend on thread support
Hi Etienne,
Almost there.
Quoted 51 lines · Etienne Carriere
BR2_PACKAGE_OPTEE_CLIENTdepends onBR2_TOOLCHAIN_HAS_THREADS. Library teec uses pthread support to protect clients state management.This change declares this dependency in package optee-client and updates dependent packages accordingly: optee-benchmark, optee-client, optee-examples and optee-test.
Fixes [1] and [2] where config selected an toolchain without thread support and build failed with trace like:
CMake Error at
/home/buildroot/autobuild/run/instance-1/output/host/share/cmake-3.8/Modules/FindPackageHandleStandardArgs.cmake:137(message):
Could NOT find Threads (missing:Threads_FOUND)
Call Stack (most recent call first):
/home/buildroot/autobuild/run/instance-1/output/host/share/cmake-3.8/Modules/FindPackageHandleStandardArgs.cmake:377(_FPHSA_FAILURE_MESSAGE)/home/buildroot/autobuild/run/instance-1/output/host/share/cmake-3.8/Modules/FindThreads.cmake:212(FIND_PACKAGE_HANDLE_STANDARD_ARGS)libteec/CMakeLists.txt:8(find_package)[1] http://autobuild.buildroot.net/results/ed6ffe2197da4f3a970bd3c5522291236396cc8e
[2] http://autobuild.buildroot.net/results/406f90048db097580b626ef889823132f8676ba1Signed-off-by Etienne Carriere <[email protected]>---
Changes v2 -> v3:
- Squash v2 series into a single patch.
- Update config comment for unmet dependencies.Changes v1 -> v2:
- No change. v2 appends changes to this change to propagate the optee-client dependency on threads to packages dependent on optee-client.--- package/optee-benchmark/Config.in | 4 +++- package/optee-client/Config.in | 4 +++- package/optee-examples/Config.in | 4 +++- package/optee-test/Config.in | 4 +++- 4 files changed, 12 insertions(+), 4 deletions(-)package/optee-benchmark/Config.in +1
-0@@ -1,6 +1,7 @@ config BR2_PACKAGE_OPTEE_BENCHMARK bool "optee-benchmark" depends on !BR2_STATIC_LIBS # optee-client + depends on BR2_TOOLCHAIN_HAS_THREADS # optee-client select BR2_PACKAGE_OPTEE_CLIENT select BR2_PACKAGE_LIBYAML help
package/optee-benchmark/Config.in config BR2_PACKAGE_OPTEE_BENCHMARK · line 17
Quoted 7 lines
package/optee-benchmark/Config.in +2
-1@@ -11,5 +12,6 @@ config BR2_PACKAGE_OPTEE_BENCHMARK http://github.com/linaro-swg/optee_benchmark -comment "optee-benchmark needs a toolchain w/ dynamic library" +comment "optee-benchmark needs a toolchain w/ dynamic library and threads" depends on BR2_STATIC_LIBS + depends on !BR2_TOOLCHAIN_HAS_THREADS
Multiple depends are ANDed. This is not what you want. We want to display the comment when either condition is true. So you need to OR the conditions like this:
depends on BR2_STATIC_LIBS || !BR2_TOOLCHAIN_HAS_THREADS
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
PATCH v3 1/1 package/optee-*: packages depend on thread support
Quoted 70 lines · Baruch Siach
Hi Etienne,
Almost there.
Quoted 51 lines · Etienne Carriere
BR2_PACKAGE_OPTEE_CLIENTdepends onBR2_TOOLCHAIN_HAS_THREADS. Library teec uses pthread support to protect clients state management.This change declares this dependency in package optee-client and updates dependent packages accordingly: optee-benchmark, optee-client, optee-examples and optee-test.
Fixes [1] and [2] where config selected an toolchain without thread support and build failed with trace like:
CMake Error at
/home/buildroot/autobuild/run/instance-1/output/host/share/cmake-3.8/Modules/FindPackageHandleStandardArgs.cmake:137(message):
Could NOT find Threads (missing:Threads_FOUND)
Call Stack (most recent call first):
/home/buildroot/autobuild/run/instance-1/output/host/share/cmake-3.8/Modules/FindPackageHandleStandardArgs.cmake:377(_FPHSA_FAILURE_MESSAGE)/home/buildroot/autobuild/run/instance-1/output/host/share/cmake-3.8/Modules/FindThreads.cmake:212(FIND_PACKAGE_HANDLE_STANDARD_ARGS)libteec/CMakeLists.txt:8(find_package)[1] http://autobuild.buildroot.net/results/ed6ffe2197da4f3a970bd3c5522291236396cc8e
[2] http://autobuild.buildroot.net/results/406f90048db097580b626ef889823132f8676ba1Signed-off-by Etienne Carriere <[email protected]>---
Changes v2 -> v3:
- Squash v2 series into a single patch.
- Update config comment for unmet dependencies.Changes v1 -> v2:
- No change. v2 appends changes to this change to propagate the optee-client dependency on threads to packages dependent on optee-client.--- package/optee-benchmark/Config.in | 4 +++- package/optee-client/Config.in | 4 +++- package/optee-examples/Config.in | 4 +++- package/optee-test/Config.in | 4 +++- 4 files changed, 12 insertions(+), 4 deletions(-)package/optee-benchmark/Config.in +1
-0@@ -1,6 +1,7 @@ config BR2_PACKAGE_OPTEE_BENCHMARK bool "optee-benchmark" depends on !BR2_STATIC_LIBS # optee-client + depends on BR2_TOOLCHAIN_HAS_THREADS # optee-client select BR2_PACKAGE_OPTEE_CLIENT select BR2_PACKAGE_LIBYAML helppackage/optee-benchmark/Config.in config BR2_PACKAGE_OPTEE_BENCHMARK · line 17
Quoted 7 lines
package/optee-benchmark/Config.in +2
-1@@ -11,5 +12,6 @@ config BR2_PACKAGE_OPTEE_BENCHMARK http://github.com/linaro-swg/optee_benchmark -comment "optee-benchmark needs a toolchain w/ dynamic library" +comment "optee-benchmark needs a toolchain w/ dynamic library and threads" depends on BR2_STATIC_LIBS + depends on !BR2_TOOLCHAIN_HAS_THREADSMultiple depends are ANDed. This is not what you want. We want to display the comment when either condition is true. So you need to OR the conditions like this:
Quoted 2 lines
depends on BR2_STATIC_LIBS || !BR2_TOOLCHAIN_HAS_THREADS
Damn', looks like i should have better test this PATCH v3. Thanks. I'll send a v4.
etienne
Quoted 6 lines
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
Thomas Petazzoni
AppliedPATCH v3 1/1 package/optee-*: packages depend on thread support
In reply to Etienne CarriereHello Etienne,
Quoted 18 lines · On Thu, 7 Mar 2019 16:45:28 +0100 Etienne Carriere…
BR2_PACKAGE_OPTEE_CLIENTdepends onBR2_TOOLCHAIN_HAS_THREADS. Library teec uses pthread support to protect clients state management.This change declares this dependency in package optee-client and updates dependent packages accordingly: optee-benchmark, optee-client, optee-examples and optee-test.
Fixes [1] and [2] where config selected an toolchain without thread support and build failed with trace like:
CMake Error at
/home/buildroot/autobuild/run/instance-1/output/host/share/cmake-3.8/Modules/FindPackageHandleStandardArgs.cmake:137(message):
Could NOT find Threads (missing:Threads_FOUND)
Call Stack (most recent call first):
/home/buildroot/autobuild/run/instance-1/output/host/share/cmake-3.8/Modules/FindPackageHandleStandardArgs.cmake:377(_FPHSA_FAILURE_MESSAGE)/home/buildroot/autobuild/run/instance-1/output/host/share/cmake-3.8/Modules/FindThreads.cmake:212(FIND_PACKAGE_HANDLE_STANDARD_ARGS)libteec/CMakeLists.txt:8(find_package)
Quoted 8 lines
[1] http://autobuild.buildroot.net/results/ed6ffe2197da4f3a970bd3c5522291236396cc8e
[2] http://autobuild.buildroot.net/results/406f90048db097580b626ef889823132f8676ba1Signed-off-by Etienne Carriere <[email protected]>---
Changes v2 -> v3:
- Squash v2 series into a single patch.
- Update config comment for unmet dependencies.
Applied to master after fixing the dependencies of the Config.in comment entries, as noticed by Baruch (thanks for the review!).
Thanks,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com