Skip to contentSkip to conversation

flare-engine: fix debug build

PATCH New Fabrice Fontaine 2 participants 4 messages Nov 18, 2018 – Nov 26, 2018

lore
Share & tools
lore

Fabrice Fontaine

author
#0 lore raw

PATCH 1/1 flare-engine: fix debug build

If BR2_ENABLE_DEBUG is set, use RelWithDebInfo instead of default Debug as Debug will add -pg (gprof) which is not always available on toolchain

Fixes:
- http://autobuild.buildroot.org/results/a12ae622a44bbe025c3a8b7e8e4c253b52927ae8

Signed-off-by Fabrice Fontaine <[email protected]>
---
 package/flare-engine/flare-engine.mk | 5 +++++
 1 file changed, 5 insertions(+)
package/flare-engine/flare-engine.mk +5 -0
index 0aac3bd33c..2f36602348 100644
@@ -14,4 +14,9 @@ FLARE_ENGINE_DEPENDENCIES += sdl2 sdl2_image sdl2_mixer sdl2_ttf
 # Don't use /usr/games and /usr/share/games
 FLARE_ENGINE_CONF_OPTS += -DBINDIR=bin -DDATADIR=share/flare
 
+# Don't use the default Debug type as it adds -pg (gprof)
+ifeq ($(BR2_ENABLE_DEBUG),y)
+FLARE_ENGINE_CONF_OPTS += -DCMAKE_BUILD_TYPE=RelWithDebInfo
+endif
+
 $(eval $(cmake-package))
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 flare-engine: fix debug build

Quoted 4 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Fabrice" == Fabrice Fontaine <[email protected]> writes:

If BR2_ENABLE_DEBUG is set, use RelWithDebInfo instead of default Debug as Debug will add -pg (gprof) which is not always available on toolchain

Is this RelWithDebInfo something specific to flare-engine or is that "standard" cmake? If so, perhaps we should use it globally instead of Debug?

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
author
#2 lore raw

PATCH 1/1 flare-engine: fix debug build

Dear Peter,
Le lun. 19 nov. 2018 ? 16:08, Peter Korsgaard <[email protected]> a ?crit :

Quoted 9 lines
Quoted 5 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

"Fabrice" == Fabrice Fontaine <[email protected]> writes:

If BR2_ENABLE_DEBUG is set, use RelWithDebInfo instead of default Debug as Debug will add -pg (gprof) which is not always available on toolchain

Is this RelWithDebInfo something specific to flare-engine or is that "standard" cmake? If so, perhaps we should use it globally instead of Debug?

Unfortunately, this is specific to flare-engine.

Quoted 5 lines

Committed, thanks.

--
Bye, Peter Korsgaard

Best Regards,

Fabrice

#3 lore raw

PATCH 1/1 flare-engine: fix debug build

In reply to Fabrice Fontaine
Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Fabrice" == Fabrice Fontaine <[email protected]> writes:

If BR2_ENABLE_DEBUG is set, use RelWithDebInfo instead of default Debug as Debug will add -pg (gprof) which is not always available on toolchain

Fixes:
- http://autobuild.buildroot.org/results/a12ae622a44bbe025c3a8b7e8e4c253b52927ae8

Signed-off-by Fabrice Fontaine <[email protected]>

Committed to 2018.08.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard