package/gdb: fix gdbserver build for m68k
PATCH 1/1 package/gdb: fix gdbserver build for m68k
As for strace [1], when <sys/reg.h> is included after <linux/ptrace.h>, the build fails on m68k with the following diagnostics:
In file included from ./../nat/linux-ptrace.h:28:0,
from linux-low.h:27,
from linux-m68k-low.c:20:[...]/usr/include/sys/reg.h:26:3: error: expected identifier before numeric constant
PT_D1 = 0,
^
[...]usr/include/sys/reg.h:26:3: error: expected ??}?? before numeric constant [...]usr/include/sys/reg.h:26:3: error: expected unqualified-id before numeric constant In file included from linux-m68k-low.c:27:0:
[...]usr/include/sys/reg.h:99:1: error: expected declaration before ??}?? token
};
^
Fix this by moving <sys/reg.h> on top of "linux-low.h".
Fixes:
https://gitlab.com/free-electrons/toolchains-builder/-/jobs/72006385
[1] https://github.com/strace/strace/commit/6ebf6c4f9e5ebca123a5b5f24afe67cf0473cf92
---
I'm not taking into acount gdb 7.11 and 7.10 since they will be removed soon.
http://patchwork.ozlabs.org/patch/869573/
http://patchwork.ozlabs.org/patch/869574/
gdb 8.1 needs this patch too.
http://patchwork.ozlabs.org/patch/869572/
--- .../7.12.1/0007-gdbserver-fix-build-for-m68k.patch | 62 ++++++++++++++++++++++ .../8.0.1/0005-gdbserver-fix-build-for-m68k.patch | 62 ++++++++++++++++++++++ 2 files changed, 124 insertions(+) create mode 100644 package/gdb/7.12.1/0007-gdbserver-fix-build-for-m68k.patch create mode 100644 package/gdb/8.0.1/0005-gdbserver-fix-build-for-m68k.patch
package/gdb/7.12.1/0007-gdbserver-fix-build-for-m68k.patch new file +62 -0
@@ -0,0 +1,62 @@ +From 80c60ea9fb3634272a98ec526eabff25f5255bae Mon Sep 17 00:00:00 2001 +From: Romain Naour <[email protected]> +Date: Fri, 22 Jun 2018 22:40:26 +0200 +Subject: [PATCH] gdbserver: fix build for m68k +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +As for strace [1], when <sys/reg.h> is included after <linux/ptrace.h>, +the build fails on m68k with the following diagnostics: + +In file included from ./../nat/linux-ptrace.h:28:0, + from linux-low.h:27, + from linux-m68k-low.c:20: +[...]/usr/include/sys/reg.h:26:3: error: expected identifier before numeric constant + PT_D1 = 0, + ^ +[...]usr/include/sys/reg.h:26:3: error: expected ??}?? before numeric constant +[...]usr/include/sys/reg.h:26:3: error: expected unqualified-id before numeric constant +In file included from linux-m68k-low.c:27:0: +[...]usr/include/sys/reg.h:99:1: error: expected declaration before ??}?? token + }; + ^ + +Fix this by moving <sys/reg.h> on top of "linux-low.h". + +[1] https://github.com/strace/strace/commit/6ebf6c4f9e5ebca123a5b5f24afe67cf0473cf92 + +Signed-off-by: Romain Naour <[email protected]> +--- + gdb/gdbserver/linux-m68k-low.c | 9 +++++---- + 1 file changed, 5 insertions(+), 4 deletions(-) + +diff --git a/gdb/gdbserver/linux-m68k-low.c b/gdb/gdbserver/linux-m68k-low.c +index 5594f10f927..19b4ef7b259 100644 +--- a/gdb/gdbserver/linux-m68k-low.c ++++ b/gdb/gdbserver/linux-m68k-low.c +@@ -17,16 +17,17 @@ + along with this program. If not, see <http://www.gnu.org/licenses/>. */ + + #include "server.h" ++ ++#ifdef HAVE_SYS_REG_H ++#include <sys/reg.h> ++#endif ++ + #include "linux-low.h" + + /* Defined in auto-generated file reg-m68k.c. */ + void init_registers_m68k (void); + extern const struct target_desc *tdesc_m68k; + +-#ifdef HAVE_SYS_REG_H +-#include <sys/reg.h> +-#endif +- + #define m68k_num_regs 29 + #define m68k_num_gregs 18 + +-- +2.14.4 +
package/gdb/8.0.1/0005-gdbserver-fix-build-for-m68k.patch new file +62 -0
62 lines not on this page · raw message
Signature · 1 line
2.14.4
PATCH 1/1 package/gdb: fix gdbserver build for m68k
Quoted 28 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Romain" == Romain Naour <[email protected]> writes:
As for strace [1], when <
sys/reg.h> is included after <linux/ptrace.h>, the build fails on m68k with the following diagnostics:In file included from
./../nat/linux-ptrace.h:28:0,from linux-low.h:27, from linux-m68k-low.c:20:[...]/usr/include/sys/reg.h:26:3: error: expected identifier before numeric constant
PT_D1= 0,
^
[...]usr/include/sys/reg.h:26:3: error: expected ??}?? before numeric constant [...]usr/include/sys/reg.h:26:3: error: expected unqualified-id before numeric constant In file included from linux-m68k-low.c:27:0:
[...]usr/include/sys/reg.h:99:1: error: expected declaration before ??}?? token
};
^Fix this by moving <
sys/reg.h> on top of "linux-low.h".Fixes:
https://gitlab.com/free-electrons/toolchains-builder/-/jobs/72006385[1] https://github.com/strace/strace/commit/6ebf6c4f9e5ebca123a5b5f24afe67cf0473cf92
Signed-off-by Romain Naour <[email protected]>Cc Thomas Petazzoni <[email protected]>Cc Waldemar Brodkorb <[email protected]>
Quoted 7 lines
---
I'm not taking into acount gdb 7.11 and 7.10 since they will be removed soon.
http://patchwork.ozlabs.org/patch/869573/
http://patchwork.ozlabs.org/patch/869574/gdb 8.1 needs this patch too.
http://patchwork.ozlabs.org/patch/869572/
Committed, thanks.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 1/1 package/gdb: fix gdbserver build for m68k
In reply to Romain NaourQuoted 20 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Romain" == Romain Naour <[email protected]> writes:
As for strace [1], when <
sys/reg.h> is included after <linux/ptrace.h>, the build fails on m68k with the following diagnostics:In file included from
./../nat/linux-ptrace.h:28:0,from linux-low.h:27, from linux-m68k-low.c:20:[...]/usr/include/sys/reg.h:26:3: error: expected identifier before numeric constant
PT_D1= 0,
^
[...]usr/include/sys/reg.h:26:3: error: expected ??}?? before numeric constant [...]usr/include/sys/reg.h:26:3: error: expected unqualified-id before numeric constant In file included from linux-m68k-low.c:27:0:
[...]usr/include/sys/reg.h:99:1: error: expected declaration before ??}?? token
};
^Fix this by moving <
sys/reg.h> on top of "linux-low.h".
Quoted 8 lines
Fixes:
https://gitlab.com/free-electrons/toolchains-builder/-/jobs/72006385[1] https://github.com/strace/strace/commit/6ebf6c4f9e5ebca123a5b5f24afe67cf0473cf92
Signed-off-by Romain Naour <[email protected]>Cc Thomas Petazzoni <[email protected]>Cc Waldemar Brodkorb <[email protected]>
Committed to 2018.02.x and 2018.05.x, thanks.
Signature · 1 line
Bye, Peter Korsgaard