Skip to contentSkip to conversation

arm64: dts: marvell: armada-3720-espressobin: Add vqmmc regulator for SD slot

PATCH New Sean Nyekjaer 3 participants 6 messages Jul 29, 2017 – Aug 3, 2017

Subsystems (2)
Device tree bindings Arm/Marvell Kirkwood and Armada 370, 375, 38x, 39x, XP, 3700, 7K/8K, CN9130 SoC support
lore
Share & tools
lore

Sean Nyekjaer

author
#0 lore raw

PATCH 1/1 arm64: dts: marvell: armada-3720-espressobin: Add vqmmc regulator for SD slot

By adding this regulator, the SD cards are usable at higher speed protocols such as SDR104.

This patch was tested with an SDHC card compatible with UHS-I.

Signed-off-by Sean Nyekjaer <[email protected]>

---

This patch depends on "[PATCH] arm64: dts: marvell: Add microsd card definition for the ESPRESSObin"

 arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)
arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts +14 -1
index 2dadd77e08eb..d5ab5b47f8d4 100644
@@ -60,6 +60,19 @@
 		device_type = "memory";
 		reg = <0x00000000 0x00000000 0x00000000 0x20000000>;
 	};
+
+	vcc_sd_reg1: regulator {
+		compatible = "regulator-gpio";
+		regulator-name= "vcc_sd1";
+		regulator-min-microvolt = <1800000>;
+		regulator-max-microvolt = <3300000>;
+
+		gpios = <&gpionb 4 GPIO_ACTIVE_HIGH>;
+		gpios-states = <0>;
+		states = <1800000 0x1
+			  3300000 0x0>;
+		enable-active-high;
+	};
 };
 
 /* J9 */

@@ -82,7 +95,7 @@
 	wp-inverted;
 	bus-width = <4>;
 	cd-gpios = <&gpionb 3 GPIO_ACTIVE_LOW>;
-	no-1-8-v;
+	vqmmc-supply = <&vcc_sd_reg1>;
 	marvell,pad-type = "sd";
 	status = "okay";
 };
Signature · 1 line
2.13.3
#1 lore raw

PATCH 1/1 arm64: dts: marvell: armada-3720-espressobin: Add vqmmc regulator for SD slot

Hi,

Quoted 6 lines · On Sat, 29 Jul 2017 12:44:11 +0200 Sean Nyekjaer <[email protected]> wrote:

By adding this regulator, the SD cards are usable at higher speed protocols such as SDR104.

This patch was tested with an SDHC card compatible with UHS-I.

Signed-off-by Sean Nyekjaer <[email protected]>

The patch does the job, but does not apply as is.

Tested-by Miquel Raynal <[email protected]>

Regards,
Miqu?l

Quoted 41 lines

---

This patch depends on "[PATCH] arm64: dts: marvell: Add microsd card definition for the ESPRESSObin"

 arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts | 15

++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-)

(quoted diff) +0 -0

b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts index 2dadd77e08eb..d5ab5b47f8d4 100644 --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts @@ -60,6 +60,19 @@ device_type = "memory";

arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts +14 -1
 		reg = <0x00000000 0x00000000 0x00000000 0x20000000>;
 	};
+
+	vcc_sd_reg1: regulator {
+		compatible = "regulator-gpio";
+		regulator-name= "vcc_sd1";
+		regulator-min-microvolt = <1800000>;
+		regulator-max-microvolt = <3300000>;
+
+		gpios = <&gpionb 4 GPIO_ACTIVE_HIGH>;
+		gpios-states = <0>;
+		states = <1800000 0x1
+			  3300000 0x0>;
+		enable-active-high;
+	};
 };
 
 /* J9 */

@@ -82,7 +95,7 @@
 	wp-inverted;
 	bus-width = <4>;
 	cd-gpios = <&gpionb 3 GPIO_ACTIVE_LOW>;
-	no-1-8-v;
+	vqmmc-supply = <&vcc_sd_reg1>;
 	marvell,pad-type = "sd";
 	status = "okay";
 };
Signature · 3 lines
Miquel Raynal, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
author
#2 lore raw

PATCH 1/1 arm64: dts: marvell: armada-3720-espressobin: Add vqmmc regulator for SD slot

Quoted 5 lines · Miquel RAYNAL

Hi,

On Sat, 29 Jul 2017 12:44:11 +0200
Sean Nyekjaer <[email protected]> wrote:

Quoted 8 lines
Quoted 6 lines

By adding this regulator, the SD cards are usable at higher speed protocols such as SDR104.

This patch was tested with an SDHC card compatible with UHS-I.

Signed-off-by Sean Nyekjaer <[email protected]>

The patch does the job, but does not apply as is.

Try applying "[PATCH] arm64: dts: marvell: Add microsd card definition for the ESPRESSObin" first :-)

Br
Sean

Quoted 54 lines
Tested-by Miquel Raynal <[email protected]>

Regards,
Miqu?l

Quoted 33 lines

---

This patch depends on "[PATCH] arm64: dts: marvell: Add microsd card definition for the ESPRESSObin"

 arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts | 15

++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-)

(quoted diff) +0 -0

b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts index 2dadd77e08eb..d5ab5b47f8d4 100644 --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts @@ -60,6

+60,19 @@ device_type = "memory";
              reg = <0x00000000 0x00000000 0x00000000 0x20000000>;
      };
arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts +13 -0
+
+     vcc_sd_reg1: regulator {
+             compatible = "regulator-gpio";
+             regulator-name= "vcc_sd1";
+             regulator-min-microvolt = <1800000>;
+             regulator-max-microvolt = <3300000>;
+
+             gpios = <&gpionb 4 GPIO_ACTIVE_HIGH>;
+             gpios-states = <0>;
+             states = <1800000 0x1
+                       3300000 0x0>;
+             enable-active-high;
+     };
 };
 
 /* J9 */

arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts line 101

Quoted 8 lines
arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts +1 -1
@@ -82,7 +95,7 @@
      wp-inverted;
      bus-width = <4>;
      cd-gpios = <&gpionb 3 GPIO_ACTIVE_LOW>;
-     no-1-8-v;
+     vqmmc-supply = <&vcc_sd_reg1>;
      marvell,pad-type = "sd";
      status = "okay";
 };

--
Miquel Raynal, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

#3 lore raw

PATCH 1/1 arm64: dts: marvell: armada-3720-espressobin: Add vqmmc regulator for SD slot

Hi,

Quoted 10 lines · On Thu, 3 Aug 2017 08:03:24 +0200 Sean Nyekj?r <[email protected]> wrote:
Quoted 8 lines · Miquel RAYNAL

Hi,

Quoted 3 lines · On Sat, 29 Jul 2017 12:44:11 +0200 Sean Nyekjaer <[email protected]> wrote:

By adding this regulator, the SD cards are usable at higher speed protocols such as SDR104.

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

This patch was tested with an SDHC card compatible with UHS-I.

Signed-off-by Sean Nyekjaer <[email protected]>

The patch does the job, but does not apply as is.

Try applying "[PATCH] arm64: dts: marvell: Add microsd card definition for the ESPRESSObin" first :-)

I know, but I was pointing the dependency again because there is at least one other patch that does the same uSD addition in ESPRESSObin DT and I do not know which one will be selected by the maintainer.

BR,
Miqu?l

Quoted 57 lines

Br
Sean

Quoted 54 lines
Tested-by Miquel Raynal <[email protected]>

Regards,
Miqu?l

Quoted 33 lines

---

This patch depends on "[PATCH] arm64: dts: marvell: Add microsd card definition for the ESPRESSObin"

 arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts | 15

++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts index 2dadd77e08eb..d5ab5b47f8d4 100644 --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts @@ -60,6 +60,19 @@ device_type = "memory"; reg = <0x00000000 0x00000000 0x00000000 0x20000000>; };

arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts +13 -0
+
+     vcc_sd_reg1: regulator {
+             compatible = "regulator-gpio";
+             regulator-name= "vcc_sd1";
+             regulator-min-microvolt = <1800000>;
+             regulator-max-microvolt = <3300000>;
+
+             gpios = <&gpionb 4 GPIO_ACTIVE_HIGH>;
+             gpios-states = <0>;
+             states = <1800000 0x1
+                       3300000 0x0>;
+             enable-active-high;
+     };
 };
 
 /* J9 */

arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts line 101

Quoted 8 lines
arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts +1 -1
@@ -82,7 +95,7 @@
      wp-inverted;
      bus-width = <4>;
      cd-gpios = <&gpionb 3 GPIO_ACTIVE_LOW>;
-     no-1-8-v;
+     vqmmc-supply = <&vcc_sd_reg1>;
      marvell,pad-type = "sd";
      status = "okay";
 };

--
Miquel Raynal, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Signature · 3 lines
Miquel Raynal, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
#4 lore raw

PATCH 1/1 arm64: dts: marvell: armada-3720-espressobin: Add vqmmc regulator for SD slot

Hi Sean,

Quoted 19 lines · Miquel RAYNAL

Hi,

Quoted 14 lines · On Thu, 3 Aug 2017 08:03:24 +0200 Sean Nyekj?r <[email protected]> wrote:
Quoted 12 lines · Miquel RAYNAL

Hi,

Quoted 6 lines · On Sat, 29 Jul 2017 12:44:11 +0200 Sean Nyekjaer <[email protected]> wrote:

By adding this regulator, the SD cards are usable at higher speed protocols such as SDR104.

This patch was tested with an SDHC card compatible with UHS-I.

Signed-off-by Sean Nyekjaer <[email protected]>
Quoted 7 lines
Quoted 3 lines
Quoted 1 line

The patch does the job, but does not apply as is.

Try applying "[PATCH] arm64: dts: marvell: Add microsd card definition for the ESPRESSObin" first :-)

I know, but I was pointing the dependency again because there is at least one other patch that does the same uSD addition in ESPRESSObin DT and I do not know which one will be selected by the maintainer.

As you didn't copy any of the mvebu maintainer I missed your patch. And I saw this one only thanks to the patch "ARM64: dts: marvell:
armada-37xx: Enable uSD on ESPRESSObin", because I thought your patch was a follow-up of this one.

I will still apply ""ARM64: dts: marvell: armada-37xx: Enable uSD on ESPRESSObin" which is already well formatted and enables everything in a single patch, I will just have to remove the "no-1-8-v" that Marcin should have let by mistake.

Next time please don't forget to CC the maintainers.

Thanks,

Gregory

Quoted 73 lines

BR,
Miqu?l

Quoted 57 lines

Br
Sean

Quoted 54 lines
Tested-by Miquel Raynal <[email protected]>

Regards,
Miqu?l

Quoted 33 lines

---

This patch depends on "[PATCH] arm64: dts: marvell: Add microsd card definition for the ESPRESSObin"

 arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts | 15

++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts index 2dadd77e08eb..d5ab5b47f8d4 100644 --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts @@ -60,6 +60,19 @@ device_type = "memory"; reg = <0x00000000 0x00000000 0x00000000 0x20000000>; };

arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts +13 -0
+
+     vcc_sd_reg1: regulator {
+             compatible = "regulator-gpio";
+             regulator-name= "vcc_sd1";
+             regulator-min-microvolt = <1800000>;
+             regulator-max-microvolt = <3300000>;
+
+             gpios = <&gpionb 4 GPIO_ACTIVE_HIGH>;
+             gpios-states = <0>;
+             states = <1800000 0x1
+                       3300000 0x0>;
+             enable-active-high;
+     };
 };
 
 /* J9 */

arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts line 101

Quoted 8 lines
arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts +1 -1
@@ -82,7 +95,7 @@
      wp-inverted;
      bus-width = <4>;
      cd-gpios = <&gpionb 3 GPIO_ACTIVE_LOW>;
-     no-1-8-v;
+     vqmmc-supply = <&vcc_sd_reg1>;
      marvell,pad-type = "sd";
      status = "okay";
 };

--
Miquel Raynal, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Signature · 8 lines
Miquel Raynal, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Signature · 4 lines
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
author
#5 lore raw

PATCH 1/1 arm64: dts: marvell: armada-3720-espressobin: Add vqmmc regulator for SD slot

Hi Gregory

Quoted 36 lines · Gregory CLEMENT

Hi Sean,

Quoted 19 lines · Miquel RAYNAL

Hi,

Quoted 14 lines · On Thu, 3 Aug 2017 08:03:24 +0200 Sean Nyekj?r <[email protected]> wrote:
Quoted 12 lines · Miquel RAYNAL

Hi,

Quoted 6 lines · On Sat, 29 Jul 2017 12:44:11 +0200 Sean Nyekjaer <[email protected]> wrote:

By adding this regulator, the SD cards are usable at higher speed protocols such as SDR104.

This patch was tested with an SDHC card compatible with UHS-I.

Signed-off-by Sean Nyekjaer <[email protected]>
Quoted 7 lines
Quoted 3 lines
Quoted 1 line

The patch does the job, but does not apply as is.

Try applying "[PATCH] arm64: dts: marvell: Add microsd card definition for the ESPRESSObin" first :-)

I know, but I was pointing the dependency again because there is at least one other patch that does the same uSD addition in ESPRESSObin DT and I do not know which one will be selected by the maintainer.

As you didn't copy any of the mvebu maintainer I missed your patch. And I saw this one only thanks to the patch "ARM64: dts: marvell:
armada-37xx: Enable uSD on ESPRESSObin", because I thought your patch was a follow-up of this one.

Quoted 6 lines

I will still apply ""ARM64: dts: marvell: armada-37xx: Enable uSD on ESPRESSObin" which is already well formatted and enables everything in a single patch, I will just have to remove the "no-1-8-v" that Marcin should have let by mistake.

Next time please don't forget to CC the maintainers.

Sorry i will remember next time :-) Sometimes when somebody CC's the maintainer i think i looks a bit pushy ... But on the arm-soc list i can see the point +1

Quoted 79 lines

Thanks,

Gregory

Quoted 69 lines

BR,
Miqu?l

Quoted 57 lines

Br
Sean

Quoted 54 lines
Tested-by Miquel Raynal <[email protected]>

Regards,
Miqu?l

Quoted 33 lines

---

This patch depends on "[PATCH] arm64: dts: marvell: Add microsd card definition for the ESPRESSObin"

 arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts | 15

++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts index 2dadd77e08eb..d5ab5b47f8d4 100644 --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts @@ -60,6 +60,19 @@ device_type = "memory"; reg = <0x00000000 0x00000000 0x00000000 0x20000000>; };

arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts +13 -0
+
+     vcc_sd_reg1: regulator {
+             compatible = "regulator-gpio";
+             regulator-name= "vcc_sd1";
+             regulator-min-microvolt = <1800000>;
+             regulator-max-microvolt = <3300000>;
+
+             gpios = <&gpionb 4 GPIO_ACTIVE_HIGH>;
+             gpios-states = <0>;
+             states = <1800000 0x1
+                       3300000 0x0>;
+             enable-active-high;
+     };
 };
 
 /* J9 */

arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts line 101

Quoted 8 lines
arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts +1 -1
@@ -82,7 +95,7 @@
      wp-inverted;
      bus-width = <4>;
      cd-gpios = <&gpionb 3 GPIO_ACTIVE_LOW>;
-     no-1-8-v;
+     vqmmc-supply = <&vcc_sd_reg1>;
      marvell,pad-type = "sd";
      status = "okay";
 };

--
Miquel Raynal, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

--
Miquel Raynal, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Quoted 4 lines

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Quoted 5 lines

--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

Br
Sean