module: keep percpu symbols in module's symtab
PATCH 1/1 module: keep percpu symbols in module's symtab
Currently, percpu symbols from .data..percpu ELF section of a module are not copied over and stored in final symtab array of struct module. Consequently such symbol cannot be returned via kallsyms API (for example kallsyms_lookup_name). This can be especially confusing when the percpu symbol is exported. Only its __ksymtab et al. are present in its symtab.
The culprit is in layout_and_allocate() function where SHF_ALLOC flag is dropped for .data..percpu section. There is in fact no need to copy the section to final struct module, because kernel module loader allocates extra percpu section by itself. Unfortunately only symbols from SHF_ALLOC sections are copied (see is_core_symbol()).
The patch restores SHF_ALLOC flag for original percpu section. The section with its symbols is thus copied over, but not otherwise used. st_value of percpu symbols points to correct newly allocated section thanks to correction in simplify_symbols().
---
I don't deem the solution nice. The other one I came up with was to hack is_core_symbol() to copy percpu symbols. There is a catch though. Elf_Sym's st_shndx is an index to an associated section. If we do not preserve .data..percpu section the index would be invalid. But this is similar to other symbols as well I guess. The index is never valid after move_module(), right? The only relevant check I found in the kernel is in get_ksymbol() - 'st_shndx == SHN_UNDEF'. So it could be harmless.
On the other hand copying of percpu section is simple and should not break anything.
What do you think?
Thanks,
Miroslav
kernel/module.c | 3 --- 1 file changed, 3 deletions(-)
kernel/module.c +0 -3
@@ -3108,9 +3108,6 @@ static struct module *layout_and_allocate(struct load_info *info, int flags)if (err <0 )return ERR_PTR (err); -/* We will do a special allocation for per-cpu sections later. */ - info->sechdrs[info->index.pcpu].sh_flags &= ~(unsigned long )SHF_ALLOC ; -/* Determine total sizes, and put offsets in sh_entsize. For now this is done generically; there doesn't appear to be any special cases for the architectures. */
Signature · 1 line
2.1.4
Quoted 21 lines · Miroslav Benes
Currently, percpu symbols from .data..percpu ELF section of a module are not copied over and stored in final symtab array of struct module. Consequently such symbol cannot be returned via kallsyms API (for example
kallsyms_lookup_name). This can be especially confusing when the percpu symbol is exported. Only its__ksymtabet al. are present in its symtab.The culprit is in
layout_and_allocate()function whereSHF_ALLOCflag is dropped for .data..percpu section. There is in fact no need to copy the section to final struct module, because kernel module loader allocates extra percpu section by itself. Unfortunately only symbols fromSHF_ALLOCsections are copied (seeis_core_symbol()).The patch restores
SHF_ALLOCflag for original percpu section. The section with its symbols is thus copied over, but not otherwise used.st_valueof percpu symbols points to correct newly allocated section thanks to correction insimplify_symbols().Signed-off-by Miroslav Benes <[email protected]>---
Quoted 7 lines
I don't deem the solution nice. The other one I came up with was to hack
is_core_symbol()to copy percpu symbols. There is a catch though. Elf_Sym'sst_shndxis an index to an associated section. If we do not preserve .data..percpu section the index would be invalid. But this is similar to other symbols as well I guess. The index is never valid aftermove_module(), right? The only relevant check I found in the kernel is inget_ksymbol()- 'st_shndx==SHN_UNDEF'. So it could be harmless.
Yes, you should do this instead, I think.
Cheers,
Rusty.