Skip to contentSkip to conversation

manual: Clarify wrapper and debug

PATCH New Maxime Hadjinlian 2 participants 4 messages Feb 3, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 manual: Clarify wrapper and debug

Try to clarify how the wrapper passes arguments and why. This is mainly because the output you can see when you build, does not reflect what is invoked by the wrapper.

---
 docs/manual/customize-toolchain.txt | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
docs/manual/customize-toolchain.txt +4 -3
index 31c9140..4f3fe23 100644
@@ -17,9 +17,10 @@ generate it.
 It also requires to set the Buildroot settings according to the toolchain ones
 (see xref:external-toolchain-backend[]).
 
-When using an external toolchain, Buildroot generates a wrapper program, that
-passes the appropriate options (according to the configuration) to the
-external toolchain programs. In case you need to debug this wrapper, you can
+When using an external toolchain, Buildroot generates a wrapper program,
+that transparently passes the appropriate options (according to the
+configuration) to the external toolchain programs. In case you need to
+debug this wrapper to check exactly what arguments are passed, you can
 set the environment variable BR_DEBUG_WRAPPER to either one of:
 
 * +0+, empty or not set: no debug
Signature · 1 line
1.8.5.3
#1 lore raw

PATCH 1/1 manual: Clarify wrapper and debug

Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Maxime" == Maxime Hadjinlian <[email protected]> writes:

Try to clarify how the wrapper passes arguments and why. This is mainly because the output you can see when you build, does not reflect what is invoked by the wrapper.

This patch is quite hard to read as you rewrapped the entire paragraph, but OK - look good to me. Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH 1/1 manual: Clarify wrapper and debug

Hi Peter,

Quoted 10 lines · Peter Korsgaard
Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Maxime" == Maxime Hadjinlian <[email protected]> writes:

Try to clarify how the wrapper passes arguments and why. This is mainly because the output you can see when you build, does not reflect what is invoked by the wrapper.

This patch is quite hard to read as you rewrapped the entire paragraph, but OK - look good to me. Committed, thanks.

How should I have done it ? I was adding a few words, then, I rewrapped the whole things using gq in vim.
Should I have only wrapped by hand ?

Quoted 3 lines

--
Bye, Peter Korsgaard

#3 lore raw

PATCH 1/1 manual: Clarify wrapper and debug

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Maxime" == Maxime Hadjinlian <[email protected]> writes:

Hi,

Quoted 5 lines
Quoted 2 lines

This patch is quite hard to read as you rewrapped the entire paragraph, but OK - look good to me. Committed, thanks.

How should I have done it ? I was adding a few words, then, I rewrapped the whole things using gq in vim.
Should I have only wrapped by hand ?

I would have preferred to only wrap from the line where you added text to the end of the section, just to make the diff smaller / more readable, but it's not a big deal.

Signature · 1 line
Bye, Peter Korsgaard