Skip to contentSkip to conversation

uclibc: fix MIPS variables

PATCH New Thomas Petazzoni 3 participants 3 messages Nov 10, 2013 – Nov 11, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 uclibc: fix MIPS variables

The BR2_UCLIBC_MIPS_ISA hidden Config.in variable defines which uClibc config option should be enabled for a given MIPS architecture variant. Therefore, using lower case names doesn't work: they should be upper case, to match uClibc config option names. This commit makes sure the mips32, mips32r2 and mips64 builds select the appropriate uClibc configuration.

---
 package/uclibc/Config.in | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
package/uclibc/Config.in +3 -3
index 2dbac12..82dd3aa 100644
@@ -230,9 +230,9 @@ config BR2_UCLIBC_MIPS_ISA
 	default 2 if BR2_mips_2
 	default 3 if BR2_mips_3
 	default 4 if BR2_mips_4
-	default mips32 if BR2_mips_32
-	default mips32r2 if BR2_mips_32r2
-	default mips64 if BR2_mips_64
+	default MIPS32 if BR2_mips_32
+	default MIPS32R2 if BR2_mips_32r2
+	default MIPS64 if BR2_mips_64
 
 config BR2_UCLIBC_SH_TYPE
 	string
Signature · 1 line
1.8.1.2
#1 lore raw

PATCH 1/1 uclibc: fix MIPS variables

Quoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

The BR2_UCLIBC_MIPS_ISA hidden Config.in variable defines which uClibc config option should be enabled for a given MIPS architecture variant. Therefore, using lower case names doesn't work: they should be upper case, to match uClibc config option names. This commit makes sure the mips32, mips32r2 and mips64 builds select the appropriate uClibc configuration.

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH 1/1 uclibc: fix MIPS variables

In reply to Thomas Petazzoni
Quoted 21 lines · Thomas Petazzoni

The BR2_UCLIBC_MIPS_ISA hidden Config.in variable defines which uClibc config option should be enabled for a given MIPS architecture variant. Therefore, using lower case names doesn't work: they should be upper case, to match uClibc config option names. This commit makes sure the mips32, mips32r2 and mips64 builds select the appropriate uClibc configuration.

---
  package/uclibc/Config.in | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
package/uclibc/Config.in +0 -0
index 2dbac12..82dd3aa 100644
@@ -230,9 +230,9 @@ config BR2_UCLIBC_MIPS_ISA
  	default 2 if BR2_mips_2
  	default 3 if BR2_mips_3

package/uclibc/Config.in config BR2_UCLIBC_MIPS_ISA · line 238

Quoted 10 lines
package/uclibc/Config.in +3 -3
  	default 4 if BR2_mips_4
-	default mips32 if BR2_mips_32
-	default mips32r2 if BR2_mips_32r2
-	default mips64 if BR2_mips_64
+	default MIPS32 if BR2_mips_32
+	default MIPS32R2 if BR2_mips_32r2
+	default MIPS64 if BR2_mips_64
 
  config BR2_UCLIBC_SH_TYPE
  	string

That looks good to me. Thanks for fixing it.

Signature · 1 line
markos