Skip to contentSkip to conversation

arm: armada: Add .dts file for Netgear ReadyNAS 102

PATCH New Arnaud Ebalard 3 participants 8 messages Jul 4, 2013 – Aug 5, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm: armada: Add .dts file for Netgear ReadyNAS 102

All hardware parts of the (Armada 370 based) NETGEAR ReadyNAS 102 are supported by mainline kernel (USB 3.0 rear ports, USB 2.0 front port, Gigabit controller and PHY, serial port, leds, buttons, SATA ports, G762 fan controller) except for:

- the Intersil ISL12057 I2C RTC Chip,
- the Armada NAND controller.

Support for both of those is currently work in progress and does not prevent boot.

---
Hi Jason and Andrew,

As requested

- this version is tested against current head of linus tree (+ I2C fixes for a race condition; for details, see message #94 of
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=622325).
- nand layout entry and ISL12057 entry have been removed until support is available in mainline kernel for eahc of those
- clock, gpio led and keys have been made siblings of soc, memory and chosen (reported by Sebastian).

Is it still acceptable for current merge window or am I too late?

Cheers,

a+

 arch/arm/boot/dts/Makefile                     |   1 +
 arch/arm/boot/dts/armada-370-netgear-rn102.dts | 176 +++++++++++++++++++++++++
 2 files changed, 177 insertions(+)
 create mode 100644 arch/arm/boot/dts/armada-370-netgear-rn102.dts
arch/arm/boot/dts/Makefile +1 -0
index 641b3c9..d869d83 100644
@@ -100,6 +100,7 @@ dtb-$(CONFIG_ARCH_MSM) += msm8660-surf.dtb \
 	msm8960-cdp.dtb
 dtb-$(CONFIG_ARCH_MVEBU) += armada-370-db.dtb \
 	armada-370-mirabox.dtb \
+	armada-370-netgear-rn102.dtb \
 	armada-370-rd.dtb \
 	armada-xp-db.dtb \
 	armada-xp-gp.dtb \
arch/arm/boot/dts/armada-370-netgear-rn102.dts new file +176 -0

176 lines not on this page · raw message

Signature · 1 line
1.8.3.1
#1 lore raw

PATCH 1/1 arm: armada: Add .dts file for Netgear ReadyNAS 102

Quoted 26 lines · Arnaud Ebalard

All hardware parts of the (Armada 370 based) NETGEAR ReadyNAS 102 are supported by mainline kernel (USB 3.0 rear ports, USB 2.0 front port, Gigabit controller and PHY, serial port, leds, buttons, SATA ports, G762 fan controller) except for:

- the Intersil ISL12057 I2C RTC Chip,
- the Armada NAND controller.

Support for both of those is currently work in progress and does not prevent boot.

---
Hi Jason and Andrew,

As requested

- this version is tested against current head of linus tree (+ I2C fixes for a race condition; for details, see message #94 of
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=622325).
- nand layout entry and ISL12057 entry have been removed until support is available in mainline kernel for eahc of those
- clock, gpio led and keys have been made siblings of soc, memory and chosen (reported by Sebastian).

Quoted 1 line

Is it still acceptable for current merge window or am I too late?

Unfortunately, it's too late for v3.11. The arm-soc cutoff is typically -rc6 or so. Which usually means we need to see it on lakml by -rc5. So, you're ahead of schedule for v3.12 :-P

However, with any luck, maybe Ezequiel will have something ready for the nand driver in time as well...

thx,

Jason.

#2 lore raw

PATCH 1/1 arm: armada: Add .dts file for Netgear ReadyNAS 102

Hi,

Quoted 27 lines · Jason Cooper
Quoted 26 lines · Arnaud Ebalard

All hardware parts of the (Armada 370 based) NETGEAR ReadyNAS 102 are supported by mainline kernel (USB 3.0 rear ports, USB 2.0 front port, Gigabit controller and PHY, serial port, leds, buttons, SATA ports, G762 fan controller) except for:

- the Intersil ISL12057 I2C RTC Chip,
- the Armada NAND controller.

Support for both of those is currently work in progress and does not prevent boot.

---
Hi Jason and Andrew,

As requested

- this version is tested against current head of linus tree (+ I2C fixes for a race condition; for details, see message #94 of
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=622325).
- nand layout entry and ISL12057 entry have been removed until support is available in mainline kernel for eahc of those
- clock, gpio led and keys have been made siblings of soc, memory and chosen (reported by Sebastian).

Quoted 8 lines
Quoted 1 line

Is it still acceptable for current merge window or am I too late?

Unfortunately, it's too late for v3.11. The arm-soc cutoff is typically -rc6 or so. Which usually means we need to see it on lakml by -rc5. So, you're ahead of schedule for v3.12 :-P

However, with any luck, maybe Ezequiel will have something ready for the nand driver in time as well...

ok, no problem. That may be better in the end. And regarding the addition of G762 entries to ReadyNAS Duo v2 .dts file you queued a few days ago? I was unable to find it in one of your branches and just wonder where it went and hide.

Cheers,

a+

#3 lore raw

PATCH 1/1 arm: armada: Add .dts file for Netgear ReadyNAS 102

Quoted 37 lines · Arnaud Ebalard

Hi,

Quoted 33 lines · Jason Cooper
Quoted 26 lines · Arnaud Ebalard

All hardware parts of the (Armada 370 based) NETGEAR ReadyNAS 102 are supported by mainline kernel (USB 3.0 rear ports, USB 2.0 front port, Gigabit controller and PHY, serial port, leds, buttons, SATA ports, G762 fan controller) except for:

- the Intersil ISL12057 I2C RTC Chip,
- the Armada NAND controller.

Support for both of those is currently work in progress and does not prevent boot.

---
Hi Jason and Andrew,

As requested

- this version is tested against current head of linus tree (+ I2C fixes for a race condition; for details, see message #94 of
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=622325).
- nand layout entry and ISL12057 entry have been removed until support is available in mainline kernel for eahc of those
- clock, gpio led and keys have been made siblings of soc, memory and chosen (reported by Sebastian).

Quoted 1 line

Is it still acceptable for current merge window or am I too late?

Unfortunately, it's too late for v3.11. The arm-soc cutoff is typically -rc6 or so. Which usually means we need to see it on lakml by -rc5. So, you're ahead of schedule for v3.12 :-P

Quoted 7 lines
Quoted 2 lines

However, with any luck, maybe Ezequiel will have something ready for the nand driver in time as well...

ok, no problem. That may be better in the end. And regarding the addition of G762 entries to ReadyNAS Duo v2 .dts file you queued a few days ago? I was unable to find it in one of your branches and just wonder where it went and hide.

It's hiding in ~/.maildir/.TODO.linux-next/ :-) atm, there's really nothing stable to base a branch off of. Once -rc1 lands, I'll create new branches with all the stuff I have so far for v3.12. I'll also rebuild for-next with that same material.

hth,

Jason.

Applied
#4 lore raw

PATCH 1/1 arm: armada: Add .dts file for Netgear ReadyNAS 102

In reply to Arnaud Ebalard
Quoted 26 lines · Arnaud Ebalard

All hardware parts of the (Armada 370 based) NETGEAR ReadyNAS 102 are supported by mainline kernel (USB 3.0 rear ports, USB 2.0 front port, Gigabit controller and PHY, serial port, leds, buttons, SATA ports, G762 fan controller) except for:

- the Intersil ISL12057 I2C RTC Chip,
- the Armada NAND controller.

Support for both of those is currently work in progress and does not prevent boot.

---
Hi Jason and Andrew,

As requested

- this version is tested against current head of linus tree (+ I2C fixes for a race condition; for details, see message #94 of
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=622325).
- nand layout entry and ISL12057 entry have been removed until support is available in mainline kernel for eahc of those
- clock, gpio led and keys have been made siblings of soc, memory and chosen (reported by Sebastian).

Quoted 1 line

Is it still acceptable for current merge window or am I too late?

Well, for v3.12... ;-)

Quoted 8 lines

Cheers,

a+

 arch/arm/boot/dts/Makefile                     |   1 +
 arch/arm/boot/dts/armada-370-netgear-rn102.dts | 176 +++++++++++++++++++++++++
 2 files changed, 177 insertions(+)
 create mode 100644 arch/arm/boot/dts/armada-370-netgear-rn102.dts

Applied to mvebu/dt

thx,

Jason.

#5 lore raw

PATCH 1/1 arm: armada: Add .dts file for Netgear ReadyNAS 102

In reply to Arnaud Ebalard
Quoted 11 lines · Arnaud Ebalard

All hardware parts of the (Armada 370 based) NETGEAR ReadyNAS 102 are supported by mainline kernel (USB 3.0 rear ports, USB 2.0 front port, Gigabit controller and PHY, serial port, leds, buttons, SATA ports, G762 fan controller) except for:

- the Intersil ISL12057 I2C RTC Chip,
- the Armada NAND controller.

Support for both of those is currently work in progress and does not prevent boot.

If it is not too late you can add my

Just a nitpick:

For a better coherency in your file you could add an extra line before each sub-node as you have done for all the other nodes:

arch/arm/boot/dts/armada-370-netgear-rn102.dts line 158

Quoted 4 lines
arch/arm/boot/dts/armada-370-netgear-rn102.dts new file +4 -0
+	gpio_keys {
+		compatible = "gpio-keys";
+		#address-cells = <1>;
+		#size-cells = <0>;

Here

arch/arm/boot/dts/armada-370-netgear-rn102.dts line 163

Quoted 5 lines
arch/arm/boot/dts/armada-370-netgear-rn102.dts new file +5 -0
+		button at 1 {
+			label = "Power Button";
+			linux,code = <116>;     /* KEY_POWER */
+			gpios = <&gpio1 30 1>;
+		};

Here

arch/arm/boot/dts/armada-370-netgear-rn102.dts line 168

Quoted 5 lines
arch/arm/boot/dts/armada-370-netgear-rn102.dts new file +5 -0
+		button at 2 {
+			label = "Reset Button";
+			linux,code = <0x198>;   /* KEY_RESTART */
+			gpios = <&gpio0 6 1>;
+		};

and here

Quoted 9 lines
arch/arm/boot/dts/armada-370-netgear-rn102.dts new file +8 -0
+		button at 3 {
+			label = "Backup Button";
+			linux,code = <133>;     /* KEY_COPY */
+			gpios = <&gpio1 26 1>;
+		};
+	};
+
+};
Signature · 4 lines
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#6 lore raw

PATCH 1/1 arm: armada: Add .dts file for Netgear ReadyNAS 102

Quoted 10 lines · Gregory CLEMENT
Quoted 9 lines · Arnaud Ebalard

All hardware parts of the (Armada 370 based) NETGEAR ReadyNAS 102 are supported by mainline kernel (USB 3.0 rear ports, USB 2.0 front port, Gigabit controller and PHY, serial port, leds, buttons, SATA ports, G762 fan controller) except for:

- the Intersil ISL12057 I2C RTC Chip,
- the Armada NAND controller.

Quoted 6 lines
Quoted 2 lines

Support for both of those is currently work in progress and does not prevent boot.

If it is not too late you can add my

Added.

Quoted 4 lines

Just a nitpick:

For a better coherency in your file you could add an extra line before each sub-node as you have done for all the other nodes:

fixed.

thx,

Jason.

#7 lore raw

PATCH 1/1 arm: armada: Add .dts file for Netgear ReadyNAS 102

Hi Jason and Gregory,

Quoted 18 lines · Jason Cooper
Quoted 10 lines · Gregory CLEMENT
Quoted 9 lines · Arnaud Ebalard

All hardware parts of the (Armada 370 based) NETGEAR ReadyNAS 102 are supported by mainline kernel (USB 3.0 rear ports, USB 2.0 front port, Gigabit controller and PHY, serial port, leds, buttons, SATA ports, G762 fan controller) except for:

- the Intersil ISL12057 I2C RTC Chip,
- the Armada NAND controller.

Quoted 6 lines
Quoted 2 lines

Support for both of those is currently work in progress and does not prevent boot.

If it is not too late you can add my

Quoted 8 lines

Added.

Quoted 4 lines

Just a nitpick:

For a better coherency in your file you could add an extra line before each sub-node as you have done for all the other nodes:

fixed.

Thank you guys for resurrecting the thread. I was kind of waiting some more days for some feedback on ISL 12057 RTC chip driver from rtc-linux group. It now seems unlikely the driver will be in 3.12 so let's leave the .dts as is. I'll push an update for the .dts file to reference the device for 3.13-rc* cycle.

Cheers,

a+