perf tools: Introduce new -P/--parent-deep report option
Hi Jiri,
About the patch below, can't this be solved by using a regex
instead of a simple substring search instead of adding a new command line option?
- Arnaldo
commit 5b42ff035ec784c5c42c4a6bb9e7fada882f097e
Author: Jiri Olsa <[email protected]> Date: Tue Jun 18 18:31:50 2013 +0200
perf tools: Introduce new -P/--parent-deep report option
Introducing new -P/--parent-deep report option. It does the same as '-p' but it force the deep search of the callchain and looks for the deepest possible match.
The -p option searches for the first match of the parent pattern in the callchain.
$ perf report -i perf.data.delete -p perf_session__delete -s parent
+ 99.51% [other]
+ 0.46% perf_session__delete_dead_threads
+ 0.03% perf_session__delete
+ 0.00% perf_session__delete_threads
so we got multiple 'different' matches instancies, while they all belong under perf_session__delete function:
$ perf report -i perf.data.delete -P perf_session__delete -s parent
+ 99.51% [other]
+ 0.49% perf_session__delete
NOTE the 'p' vs 'P' difference in above commands above.
Hi Arnaldo,
Quoted 5 lines · Arnaldo Carvalho de Melo
Hi Jiri,
About the patch below, can't this be solved by using a regex
instead of a simple substring search instead of adding a new command line option?
???
IIUC he reused parent_regex for this.
And I think we can have the same effect by using -G and -p option together without this new option.
Thanks,
Namhyung
Quoted 32 lines
- Arnaldo
commit
5b42ff035ec784c5c42c4a6bb9e7fada882f097eAuthor: Jiri Olsa <[email protected]> Date: Tue Jun 18 18:31:50 2013 +0200perf tools: Introduce new -P/--parent-deep report option
Introducing new -P/--parent-deep report option. It does the same as '-p' but it force the deep search of the callchain and looks for the deepest possible match.
The -p option searches for the first match of the parent pattern in the callchain.
$ perf report -i perf.data.delete -p
perf_session__delete-s parent+ 99.51% [other]
+ 0.46%perf_session__delete_dead_threads
+ 0.03%perf_session__delete
+ 0.00%perf_session__delete_threadsso we got multiple 'different' matches instancies, while they all belong under
perf_session__deletefunction:$ perf report -i perf.data.delete -P
perf_session__delete-s parent+ 99.51% [other]
+ 0.49%perf_session__deleteNOTE the 'p' vs 'P' difference in above commands above.
Quoted 9 lines · Namhyung Kim
Hi Arnaldo,
Quoted 5 lines · Arnaldo Carvalho de Melo
Hi Jiri,
About the patch below, can't this be solved by using a regex
instead of a simple substring search instead of adding a new command line option?
Quoted 6 lines
???
IIUC he reused
parent_regexfor this.And I think we can have the same effect by using -G and -p option together without this new option.
I think you're right.. I haven't realized I could reverse the backtrace and search the same way via -p
thanks,
jirka