Skip to contentSkip to conversation

Fix typo: struct nandsin_geometry

PATCH In review Ferenc Wagner 3 participants 3 messages Mar 6, 2010 – Apr 1, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix typo: struct nandsin_geometry

Actually, this embedded struct (together with nandsim_regs) could as well remain nameless...

---
 drivers/mtd/nand/nandsim.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mtd/nand/nandsim.c +1 -1
index 7281000..803ae12 100644
@@ -312,7 +312,7 @@ struct nandsim {
 	union ns_mem buf;
 
 	/* NAND flash "geometry" */
-	struct nandsin_geometry {
+	struct nandsim_geometry {
 		uint64_t totsz;     /* total flash size, bytes */
 		uint32_t secsz;     /* flash sector (erase block) size, bytes */
 		uint pgsz;          /* NAND flash page size, bytes */
Signature · 1 line
1.5.6.5
#1 lore raw
Quoted 1 line · On Sat, 06 Mar 2010 20:08:00 +0100 Ferenc Wagner <[email protected]> wrote:

Subject: [PATCH] [mtd, nandsim] Fix typo: struct nandsin_geometry

fyi, the text inside [] is conventionally considered "transient, to be removed by receiver", so you should have placed the subsystem-identification text outside the [].

Quoted 3 lines

Actually, this embedded struct (together with nandsim_regs) could as well remain nameless...

Sounds like a fine idea.

Quoted 9 lines
---
 drivers/mtd/nand/nandsim.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mtd/nand/nandsim.c +0 -0
index 7281000..803ae12 100644

drivers/mtd/nand/nandsim.c struct nandsim { · line 318

Quoted 8 lines
drivers/mtd/nand/nandsim.c +1 -1
@@ -312,7 +312,7 @@ struct nandsim {
 	union ns_mem buf;
 
 	/* NAND flash "geometry" */
-	struct nandsin_geometry {
+	struct nandsim_geometry {
 		uint64_t totsz;     /* total flash size, bytes */
 		uint32_t secsz;     /* flash sector (erase block) size, bytes */
 		uint pgsz;          /* NAND flash page size, bytes */

this:

From: Ferenc Wagner <[email protected]>

The name was spelled wrong. We don't need an identifier on this struct anyway, so remove it altogether.

---

 drivers/mtd/nand/nandsim.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mtd/nand/nandsim.c renamed from drivers/mtd/nand/nandsim.c~mtd-nandsim-fix-typo-struct-nandsin_geometry +1 -1
diff -puN drivers/mtd/nand/nandsim.c~mtd-nandsim-fix-typo-struct-nandsin_geometry drivers/mtd/nand/nandsim.c
@@ -315,7 +315,7 @@ struct nandsim {
 	union ns_mem buf;
 
 	/* NAND flash "geometry" */
-	struct nandsin_geometry {
+	struct {
 		uint64_t totsz;     /* total flash size, bytes */
 		uint32_t secsz;     /* flash sector (erase block) size, bytes */
 		uint pgsz;          /* NAND flash page size, bytes */

_

#2 lore raw
In reply to Ferenc Wagner
Quoted 13 lines · Ferenc Wagner

Actually, this embedded struct (together with nandsim_regs) could as well remain nameless...

---
 drivers/mtd/nand/nandsim.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mtd/nand/nandsim.c +0 -0
index 7281000..803ae12 100644

drivers/mtd/nand/nandsim.c struct nandsim { · line 318

Quoted 8 lines
drivers/mtd/nand/nandsim.c +1 -1
@@ -312,7 +312,7 @@ struct nandsim {
 	union ns_mem buf;
 
 	/* NAND flash "geometry" */
-	struct nandsin_geometry {
+	struct nandsim_geometry {
 		uint64_t totsz;     /* total flash size, bytes */
 		uint32_t secsz;     /* flash sector (erase block) size, bytes */
 		uint pgsz;          /* NAND flash page size, bytes */

Instead of taking your patch, I've made this structure anonymous as well as few other structures. See
http://git.infradead.org/users/dedekind/l2-mtd-2.6.git/commit/833ba5e74a8b141ea7d7b318d6ac8c112659efa6

I've referred you as the person who suggested the change.

Signature · 2 lines
Best Regards,
Artem Bityutskiy (Артём Битюцкий)