Fix typo: struct nandsin_geometry
Subsystems (2)
PATCH 1/1 Fix typo: struct nandsin_geometry
Actually, this embedded struct (together with nandsim_regs) could as well remain nameless...
--- drivers/mtd/nand/nandsim.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mtd/nand/nandsim.c +1 -1
@@ -312,7 +312,7 @@ struct nandsim {union ns_mem buf;/* NAND flash "geometry" */ -struct nandsin_geometry { +struct nandsim_geometry {uint64_t totsz;/* total flash size, bytes */ uint32_t secsz;/* flash sector (erase block) size, bytes */ uint pgsz;/* NAND flash page size, bytes */
Signature · 1 line
1.5.6.5
Quoted 1 line · On Sat, 06 Mar 2010 20:08:00 +0100 Ferenc Wagner <[email protected]> wrote:
Subject: [PATCH] [mtd, nandsim] Fix typo: struct
nandsin_geometry
fyi, the text inside [] is conventionally considered "transient, to be removed by receiver", so you should have placed the subsystem-identification text outside the [].
Quoted 3 lines
Actually, this embedded struct (together with
nandsim_regs) could as well remain nameless...
Sounds like a fine idea.
Quoted 9 lines
--- drivers/mtd/nand/nandsim.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)drivers/mtd/nand/nandsim.c +0
-0
drivers/mtd/nand/nandsim.c struct nandsim { · line 318
Quoted 8 lines
drivers/mtd/nand/nandsim.c +1
-1@@ -312,7 +312,7 @@ struct nandsim {union ns_mem buf;/* NAND flash "geometry" */ -struct nandsin_geometry { +struct nandsim_geometry {uint64_t totsz;/* total flash size, bytes */ uint32_t secsz;/* flash sector (erase block) size, bytes */ uint pgsz;/* NAND flash page size, bytes */
this:
From: Ferenc Wagner <[email protected]>
The name was spelled wrong. We don't need an identifier on this struct anyway, so remove it altogether.
---
drivers/mtd/nand/nandsim.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mtd/nand/nandsim.c renamed from drivers/mtd/nand/nandsim.c~mtd-nandsim-fix-typo-struct-nandsin_geometry +1 -1
@@ -315,7 +315,7 @@ struct nandsim {union ns_mem buf;/* NAND flash "geometry" */ -struct nandsin_geometry { +struct {uint64_t totsz;/* total flash size, bytes */ uint32_t secsz;/* flash sector (erase block) size, bytes */ uint pgsz;/* NAND flash page size, bytes */
_
Quoted 13 lines · Ferenc Wagner
Actually, this embedded struct (together with
nandsim_regs) could as well remain nameless...Signed-off-by Ferenc Wagner <[email protected]>--- drivers/mtd/nand/nandsim.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)drivers/mtd/nand/nandsim.c +0
-0
drivers/mtd/nand/nandsim.c struct nandsim { · line 318
Quoted 8 lines
drivers/mtd/nand/nandsim.c +1
-1@@ -312,7 +312,7 @@ struct nandsim {union ns_mem buf;/* NAND flash "geometry" */ -struct nandsin_geometry { +struct nandsim_geometry {uint64_t totsz;/* total flash size, bytes */ uint32_t secsz;/* flash sector (erase block) size, bytes */ uint pgsz;/* NAND flash page size, bytes */
Instead of taking your patch, I've made this structure anonymous as well as few other structures. See
http://git.infradead.org/users/dedekind/l2-mtd-2.6.git/commit/833ba5e74a8b141ea7d7b318d6ac8c112659efa6
I've referred you as the person who suggested the change.
Signature · 2 lines
Best Regards, Artem Bityutskiy (Артём Битюцкий)