Skip to contentSkip to conversation

Add KVM version to monitor "info version"

PATCH In review Bjørn Mork 4 participants 5 messages Nov 26, 2008 – Dec 8, 2008 KVM

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Add KVM version to monitor "info version"

Trying to track the current KVM head as closely as possible, I often find myself wondering which KVM version a particular guest instance is running. The attached patch adds this information to the monitor command "info version":

(qemu) info version
0.9.1 (kvm-79)

---
 qemu/monitor.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
qemu/monitor.c +1 -1
index a58a18e..f61fe56 100644
@@ -246,7 +246,7 @@ static void do_info(const char *item)
 
 static void do_info_version(void)
 {
-  term_printf("%s\n", QEMU_VERSION);
+  term_printf("%s\n", QEMU_VERSION " (" KVM_VERSION ")");
 }
 
 static void do_info_name(void)
#1 lore raw
Quoted 7 lines · Bj?rn Mork

Trying to track the current KVM head as closely as possible, I often find myself wondering which KVM version a particular guest instance is running. The attached patch adds this information to the monitor command "info version":

(qemu) info version
0.9.1 (kvm-79)

I'd really rather we didn't touch the 'info version' command since it means we have different syntax from upstream QEMU. If we want KVM version info exposed, then I'd suggest 'info kvmversion' or some other new command.

Daniel

Signature · 4 lines
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
#2 lore raw
Quoted 6 lines · Daniel P. Berrange
Quoted 5 lines · Bj?rn Mork

Trying to track the current KVM head as closely as possible, I often find myself wondering which KVM version a particular guest instance is running. The attached patch adds this information to the monitor command "info version":

Quoted 7 lines
Quoted 2 lines

(qemu) info version
0.9.1 (kvm-79)

I'd really rather we didn't touch the 'info version' command since it means we have different syntax from upstream QEMU. If we want KVM version info exposed, then I'd suggest 'info kvmversion' or some other new command.

I believe it fits nicely into info kvm. Instead of enabled/disabled, we could answer
disabled or kvm-whatever

Signature · 5 lines
Glauber  Costa.
"Free as in Freedom"
http://glommer.net

"The less confident you are, the more serious you have to act."
#3 lore raw
Quoted 18 lines · Glauber Costa
Quoted 7 lines · Daniel P. Berrange
Quoted 5 lines · Bj?rn Mork

Trying to track the current KVM head as closely as possible, I often find myself wondering which KVM version a particular guest instance is running. The attached patch adds this information to the monitor command "info version":

Quoted 8 lines
Quoted 3 lines

(qemu) info version
0.9.1 (kvm-79)

I'd really rather we didn't touch the 'info version' command since it means we have different syntax from upstream QEMU. If we want KVM version info exposed, then I'd suggest 'info kvmversion' or some other new command.

Quoted 5 lines

I believe it fits nicely into info kvm. Instead of enabled/disabled, we could answer
disabled or kvm-whatever

(qemu) info kvm
enabled (kvm-123)

or

(qemu) info kvm
enabled
version kvm-123

May be easier to parse, and more backwards compatible.

Signature · 1 line
error compiling committee.c: too many arguments to function
#4 lore raw
Quoted 10 lines · Avi Kivity

(qemu) info kvm
enabled (kvm-123)

or

(qemu) info kvm
enabled
version kvm-123

May be easier to parse, and more backwards compatible.

Something like this then?

The attached patch adds KVM version to the monitor command "info kvm":

(qemu) info kvm
kvm support: enabled
kvm version: kvm-80

qemu/monitor.c +1 -0
index 3948aae..3831789 100644
@@ -1297,6 +1297,7 @@ static void do_info_kvm(void)
 	term_printf("enabled\n");
     else
 	term_printf("disabled\n");
+    term_printf("kvm version: "  KVM_VERSION "\n");
 #else
     term_printf("kvm support: not compiled\n");
 #endif