ALSA: aoa/onyx: Fix OF node leak on probe failure
Subsystems (2)
PATCH v2 1/2 ALSA: aoa/onyx: Fix OF node leak on probe failure
From: wangdicheng <[email protected]>
Add missing of_node_put() in the error path.
Signed-off-by wangdicheng <[email protected]>
---
v1->v2:
onyx_read_register()--->goto fail--->kfree aoa_codec_register()--->goto fail_put--->of_node_put + kfree
sound/aoa/codecs/onyx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
sound/aoa/codecs/onyx.c +3 -1
@@ -980,10 +980,12 @@ static int onyx_i2c_probe(struct i2c_client *client) onyx->codec.node =of_node_get (node);if (aoa_codec_register (&onyx->codec)) { - goto fail; + goto fail_put; } printk(KERN_DEBUG PFX "created and attached onyx instance\n");return 0 ; + fail_put: +of_node_put (onyx->codec.node); fail:kfree (onyx);return -ENODEV ;
Signature · 1 line
2.25.1
Takashi Iwai
AppliedQuoted 6 lines · On Fri, 03 Apr 2026 03:47:36 +0200, [email protected] wrote:
From: wangdicheng <[email protected]>
Add missing
of_node_put()in the error path.Signed-off-by wangdicheng <[email protected]>
Applied to for-next branch now.
thanks,
Takashi