Skip to contentSkip to conversation

package/sdbus-cpp: fix build failure on gcc14

PATCH In review Sergey Bobrenok 2 participants 2 messages Feb 8, 2025 – Feb 9, 2025

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/sdbus-cpp: fix build failure on gcc14

The original commit [1] was merged [2] in sdbus-cpp v1.5.0.

Fixes:
https://autobuild.buildroot.org/results/bd0a9fe123956f01336462a31c3375a036744234/

[1]
https://github.com/Kistler-Group/sdbus-cpp/commit/f50e4676fe9289eec0744efae2216aa8795fa461
[2] https://github.com/Kistler-Group/sdbus-cpp/pull/380

---
(2024.05.x, 2024.08.x, 2024.11.x and master are not affected as the version was bumped)

---
 ...missing-algorithm-header-include-380.patch | 29 +++++++++++++++++++
 1 file changed, 29 insertions(+)
 create mode 100644 package/sdbus-cpp/0001-fix-add-missing-algorithm-header-include-380.patch
package/sdbus-cpp/0001-fix-add-missing-algorithm-header-include-380.patch new file +29 -0
new file mode 100644
index 0000000000..df4b78edca
@@ -0,0 +1,29 @@
+From f50e4676fe9289eec0744efae2216aa8795fa461 Mon Sep 17 00:00:00 2001
+From: Alfred Wingate <[email protected]>
+Date: Thu, 16 Nov 2023 21:26:42 +0000
+Subject: [PATCH] fix: add missing algorithm header include (#380)
+
+* https://gcc.gnu.org/gcc-14/porting_to.html
+
+Using gcc 14 uncovers a missing include in Message.h
+
+Signed-off-by: Alfred Wingate <[email protected]>
+---
+ include/sdbus-c++/Message.h | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/include/sdbus-c++/Message.h b/include/sdbus-c++/Message.h
+index 915a071..9c85c01 100644
+--- a/include/sdbus-c++/Message.h
++++ b/include/sdbus-c++/Message.h
+@@ -42,6 +42,7 @@
+ #include <cassert>
+ #include <functional>
+ #include <sys/types.h>
++#include <algorithm>
+ 
+ // Forward declarations
+ namespace sdbus {
+-- 
+2.48.1
+
Signature · 6 lines
2.48.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw
Quoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Sergey" == Sergey Bobrenok <[email protected]> writes:

The original commit [1] was merged [2] in sdbus-cpp v1.5.0. Fixes:
https://autobuild.buildroot.org/results/bd0a9fe123956f01336462a31c3375a036744234/

Quoted 8 lines

[1]
https://github.com/Kistler-Group/sdbus-cpp/commit/f50e4676fe9289eec0744efae2216aa8795fa461
[2] https://github.com/Kistler-Group/sdbus-cpp/pull/380

---
(2024.05.x, 2024.08.x, 2024.11.x and master are not affected as the version was bumped)

You missed the upstream: tag in the patch. Committed with that fixed to 2024.02.x, thanks!

Quoted 48 lines
---
 ...missing-algorithm-header-include-380.patch | 29 +++++++++++++++++++
 1 file changed, 29 insertions(+)
 create mode 100644 package/sdbus-cpp/0001-fix-add-missing-algorithm-header-include-380.patch
package/sdbus-cpp/0001-fix-add-missing-algorithm-header-include-380.patch new file +29 -0
new file mode 100644
index 0000000000..df4b78edca
@@ -0,0 +1,29 @@
+From f50e4676fe9289eec0744efae2216aa8795fa461 Mon Sep 17 00:00:00 2001
+From: Alfred Wingate <[email protected]>
+Date: Thu, 16 Nov 2023 21:26:42 +0000
+Subject: [PATCH] fix: add missing algorithm header include (#380)
+
+* https://gcc.gnu.org/gcc-14/porting_to.html
+
+Using gcc 14 uncovers a missing include in Message.h
+
+Signed-off-by: Alfred Wingate <[email protected]>
+---
+ include/sdbus-c++/Message.h | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/include/sdbus-c++/Message.h b/include/sdbus-c++/Message.h
+index 915a071..9c85c01 100644
+--- a/include/sdbus-c++/Message.h
++++ b/include/sdbus-c++/Message.h
+@@ -42,6 +42,7 @@
+ #include <cassert>
+ #include <functional>
+ #include <sys/types.h>
++#include <algorithm>
+ 
+ // Forward declarations
+ namespace sdbus {
+-- 
+2.48.1
+
Signature · 6 lines
2.48.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Signature · 5 lines
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot