Skip to contentSkip to conversation

sound: Support microphone from device Acer 315-24p

PATCH In review end.to.start 4 participants 5 messages Apr 8, 2024 – May 5, 2024

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sound: Support microphone from device Acer 315-24p

This patch adds microphone detection for the Acer 315-24p, after which a microphone appears on the device and starts working

---
 sound/soc/amd/yc/acp6x-mach.c | 7 +++++++
 1 file changed, 7 insertions(+)
sound/soc/amd/yc/acp6x-mach.c +7 -0
index 69c68d8e7..1760b5d42 100644
@@ -430,6 +430,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = {
 			DMI_MATCH(DMI_BOARD_NAME, "MRID6"),
 		}
 	},
+	{
+		.driver_data = &acp6x_card,
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "MDC"),
+			DMI_MATCH(DMI_BOARD_NAME, "Herbag_MDU"),
+		}
+	},
 	{
 		.driver_data = &acp6x_card,
 		.matches = {
Signature · 1 line
2.44.0
maintainer
#1 lore raw
Quoted 3 lines · end.to.start

This patch adds microphone detection for the Acer 315-24p, after which a microphone appears on the device and starts working

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] sound: Support microphone from device Acer 315-24p

      commit: 4b9a474c7c820391c0913d64431ae9e1f52a5143

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

maintainer
#2 lore raw
Quoted 11 lines · Mark Brown
Quoted 3 lines · end.to.start

This patch adds microphone detection for the Acer 315-24p, after which a microphone appears on the device and starts working

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

Quoted 7 lines

[1/1] sound: Support microphone from device Acer 315-24p

       commit: 4b9a474c7c820391c0913d64431ae9e1f52a5143

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

Shall we really accept those anonymous contributions?

From submitting-patches.rst:

"""
then you just add a line saying::

using a known identity (sorry, no anonymous contributions.) """

Jaroslav

Signature · 2 lines
Jaroslav Kysela <[email protected]>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.
#3 lore raw
Quoted 25 lines · Jaroslav Kysela
Quoted 11 lines · Mark Brown
Quoted 3 lines · end.to.start

This patch adds microphone detection for the Acer 315-24p, after which a microphone appears on the device and starts working

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

Quoted 7 lines

[1/1] sound: Support microphone from device Acer 315-24p

       commit: 4b9a474c7c820391c0913d64431ae9e1f52a5143

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

Shall we really accept those anonymous contributions?

From submitting-patches.rst:

Quoted 7 lines

"""
then you just add a line saying::

using a known identity (sorry, no anonymous contributions.) """

Yeah, that's a bad example, and I noticed too late after sending a PR to Linus, too (I concentrated only on the diffs).

The code change itself looks OK, so this is no big problem. But let's decline such a submission at the next time.

thanks,

Takashi

maintainer
#4 lore raw
In reply to Jaroslav Kysela
Quoted 7 lines · Jaroslav Kysela
Quoted 4 lines · Mark Brown

On Mon, 08 Apr 2024 18:24:54 +0300, end.to.start wrote:

[1/1] sound: Support microphone from device Acer 315-24p

       commit: 4b9a474c7c820391c0913d64431ae9e1f52a5143

Shall we really accept those anonymous contributions?

I was on the edge here, what pushed me towards accepting it was that the change was just a data based quirk addition which is almost if not quite a trivial change.