m68k: fix strcmp inline
PATCH 1/1 m68k: fix strcmp inline
The return value of strcmp needs to be computed from the ordering of the unsigned characters.
Signed-off-by Andreas Schwab <[email protected]>
--- arch/m68k/include/asm/string.h | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)
arch/m68k/include/asm/string.h +5 -4
@@ -42,18 +42,19 @@ static inline char *strncpy(char *dest, const char *src, size_t n)#define __HAVE_ARCH_STRCMPstatic inline int strcmp (const char *cs,const char *ct) { -char res; +int res =0 , tmp =0 ; asm ("\n" "1: move.b (%0)+,%2\n" /* get *cs */ -" cmp.b (%1)+,%2\n" /* compare a byte */ +" move.b (%1)+,%3\n" /* get *ct */ +" cmp.b %3,%2\n" /* compare a byte */ " jne 2f\n" /* not equal, break out */ " tst.b %2\n" /* at end of cs? */ " jne 1b\n" /* no, keep going */ " jra 3f\n" /* strings are equal */ -"2: sub.b -(%1),%2\n" /* *cs - *ct */ +"2: sub.l %3,%2\n" /* *cs - *ct */ "3:" - :"+a" (cs),"+a" (ct),"=d" (res)); + :"+a" (cs),"+a" (ct),"+d" (res),"+d" (tmp));return res; }#endif /* CONFIG_COLDFIRE */
Signature · 7 lines
2.39.0 -- Andreas Schwab, [email protected] GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."