Skip to contentSkip to conversation

plugins: Assert mmu_idx in range before use in qemu_plugin_get_hwaddr

PATCH Applied Richard Henderson 3 participants 3 messages Apr 1, 2022 – Apr 8, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 plugins: Assert mmu_idx in range before use in qemu_plugin_get_hwaddr

Coverity reports out-of-bound accesses here. This should be a false positive due to how the index is decoded from MemOpIdx.

Fixes Coverity CID 1487201
---
 plugins/api.c | 2 ++
 1 file changed, 2 insertions(+)
plugins/api.c +2 -0
index 7bf71b189d..2078b16edb 100644
@@ -289,6 +289,8 @@ struct qemu_plugin_hwaddr *qemu_plugin_get_hwaddr(qemu_plugin_meminfo_t info,
     enum qemu_plugin_mem_rw rw = get_plugin_meminfo_rw(info);
     hwaddr_info.is_store = (rw & QEMU_PLUGIN_MEM_W) != 0;
 
+    assert(mmu_idx < NB_MMU_MODES);
+
     if (!tlb_plugin_lookup(cpu, vaddr, mmu_idx,
                            hwaddr_info.is_store, &hwaddr_info)) {
         error_report("invalid use of qemu_plugin_get_hwaddr");
Signature · 1 line
2.25.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 22 lines · Richard Henderson

Coverity reports out-of-bound accesses here. This should be a false positive due to how the index is decoded from MemOpIdx.

Fixes Coverity CID 1487201
---
  plugins/api.c | 2 ++
  1 file changed, 2 insertions(+)
plugins/api.c +2 -0
index 7bf71b189d..2078b16edb 100644
@@ -289,6 +289,8 @@ struct qemu_plugin_hwaddr *qemu_plugin_get_hwaddr(qemu_plugin_meminfo_t info,
      enum qemu_plugin_mem_rw rw = get_plugin_meminfo_rw(info);
      hwaddr_info.is_store = (rw & QEMU_PLUGIN_MEM_W) != 0;
 
+    assert(mmu_idx < NB_MMU_MODES);
+
      if (!tlb_plugin_lookup(cpu, vaddr, mmu_idx,
                             hwaddr_info.is_store, &hwaddr_info)) {
          error_report("invalid use of qemu_plugin_get_hwaddr");