plugins: Assert mmu_idx in range before use in qemu_plugin_get_hwaddr
PATCH 1/1 plugins: Assert mmu_idx in range before use in qemu_plugin_get_hwaddr
Coverity reports out-of-bound accesses here. This should be a false positive due to how the index is decoded from MemOpIdx.
Fixes Coverity CID 1487201
Signed-off-by Richard Henderson <[email protected]>
--- plugins/api.c | 2 ++ 1 file changed, 2 insertions(+)
plugins/api.c +2 -0
@@ -289,6 +289,8 @@ struct qemu_plugin_hwaddr *qemu_plugin_get_hwaddr(qemu_plugin_meminfo_t info,enum qemu_plugin_mem_rw rw =get_plugin_meminfo_rw (info); hwaddr_info.is_store = (rw &QEMU_PLUGIN_MEM_W ) !=0 ; +assert (mmu_idx <NB_MMU_MODES ); +if (!tlb_plugin_lookup (cpu, vaddr, mmu_idx, hwaddr_info.is_store, &hwaddr_info)) {error_report ("invalid use of qemu_plugin_get_hwaddr" );
Signature · 1 line
2.25.1
Reviewed-by Damien Hedde <[email protected]>
Quoted 22 lines · Richard Henderson
Coverity reports out-of-bound accesses here. This should be a false positive due to how the index is decoded from MemOpIdx.
Fixes Coverity CID 1487201Signed-off-by Richard Henderson <[email protected]>--- plugins/api.c | 2 ++ 1 file changed, 2 insertions(+)plugins/api.c +2
-0@@ -289,6 +289,8 @@ struct qemu_plugin_hwaddr *qemu_plugin_get_hwaddr(qemu_plugin_meminfo_t info,enum qemu_plugin_mem_rw rw =get_plugin_meminfo_rw (info); hwaddr_info.is_store = (rw &QEMU_PLUGIN_MEM_W ) !=0 ; +assert (mmu_idx <NB_MMU_MODES ); +if (!tlb_plugin_lookup (cpu, vaddr, mmu_idx, hwaddr_info.is_store, &hwaddr_info)) {error_report ("invalid use of qemu_plugin_get_hwaddr" );
Alex Bennée
AppliedQuoted 5 lines · Richard Henderson
Coverity reports out-of-bound accesses here. This should be a false positive due to how the index is decoded from MemOpIdx.
Fixes Coverity CID 1487201Signed-off-by Richard Henderson <[email protected]>
Queued to plugins/next, thanks.
Signature · 1 line
Alex Bennée