Skip to contentSkip to conversation

package/zlib-ng: drop unrecognized CC variable

PATCH New Fabrice Fontaine 3 participants 5 messages Oct 11, 2020 – Oct 12, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 package/zlib-ng: drop unrecognized CC variable

Drop unneeded CC variable which is not recognized by cmake:

CMake Warning:
Manually-specified variables were not used by the project:

BUILD_DOC
BUILD_DOCS
BUILD_EXAMPLE
BUILD_EXAMPLES
BUILD_TEST
BUILD_TESTING
BUILD_TESTS
CC

---
 package/zlib-ng/zlib-ng.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/zlib-ng/zlib-ng.mk +1 -1
index 098dfcb28a..3b27574a79 100644
@@ -12,7 +12,7 @@ ZLIB_NG_INSTALL_STAGING = YES
 ZLIB_NG_PROVIDES = zlib
 
 # Build with zlib compatible API, gzFile support and optimizations on
-ZLIB_NG_CONF_OPTS += -DZLIB_COMPAT=1 -DWITH_GZFILEOP=1 -DWITH_OPTIM=1 -DCC=$(TARGET_CC)
+ZLIB_NG_CONF_OPTS += -DZLIB_COMPAT=1 -DWITH_GZFILEOP=1 -DWITH_OPTIM=1
 
 # Enable NEON and ACLE on ARM
 ifeq ($(BR2_arm),y)
Signature · 1 line
2.28.0
#1 lore raw

PATCH 2/2 package/zlib-ng: disable tests

Tests are enabled by default and can be disabled since
https://github.com/zlib-ng/zlib-ng/commit/b0730d030a9ce5c53faa88bd8259c9afccce6881

---
 package/zlib-ng/zlib-ng.mk | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
package/zlib-ng/zlib-ng.mk +5 -1
index 3b27574a79..1cb00d075b 100644
@@ -12,7 +12,11 @@ ZLIB_NG_INSTALL_STAGING = YES
 ZLIB_NG_PROVIDES = zlib
 
 # Build with zlib compatible API, gzFile support and optimizations on
-ZLIB_NG_CONF_OPTS += -DZLIB_COMPAT=1 -DWITH_GZFILEOP=1 -DWITH_OPTIM=1
+ZLIB_NG_CONF_OPTS += \
+	-DWITH_GZFILEOP=1 \
+	-DWITH_OPTIM=1 \
+	-DZLIB_COMPAT=1 \
+	-DZLIB_ENABLE_TESTS=OFF
 
 # Enable NEON and ACLE on ARM
 ifeq ($(BR2_arm),y)
Signature · 1 line
2.28.0
#3 lore raw

PATCH 1/2 package/zlib-ng: drop unrecognized CC variable

In reply to Fabrice Fontaine
Quoted 14 lines · On Sun, 11 Oct 2020 21:43:56 +0200 Fabrice Fontaine…

Drop unneeded CC variable which is not recognized by cmake:

CMake Warning:
Manually-specified variables were not used by the project:

BUILD_DOC
BUILD_DOCS
BUILD_EXAMPLE
BUILD_EXAMPLES
BUILD_TEST
BUILD_TESTING
BUILD_TESTS
CC

Quoted 4 lines
---
 package/zlib-ng/zlib-ng.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Both applied to master. Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#4 lore raw

PATCH 1/2 package/zlib-ng: drop unrecognized CC variable

In reply to Fabrice Fontaine
Quoted 15 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Fabrice" == Fabrice Fontaine <[email protected]> writes:

Drop unneeded CC variable which is not recognized by cmake:
CMake Warning:
Manually-specified variables were not used by the project:

BUILD_DOC
BUILD_DOCS
BUILD_EXAMPLE
BUILD_EXAMPLES
BUILD_TEST
BUILD_TESTING
BUILD_TESTS
CC

Quoted 1 line

Committed to 2020.08.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard