Skip to contentSkip to conversation

docker: remove libcap development packages

PATCH In review Paolo Bonzini 3 participants 4 messages Nov 29, 2019 – Dec 3, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 docker: remove libcap development packages

Libcap was dropped from virtio-9p, so remove it from the dockerfiles as well.

---
 tests/docker/dockerfiles/fedora.docker     | 1 -
 tests/docker/dockerfiles/ubuntu.docker     | 1 -
 tests/docker/dockerfiles/ubuntu1804.docker | 1 -
 3 files changed, 3 deletions(-)
tests/docker/dockerfiles/fedora.docker +0 -1
index 4ddc7dd112..47732fc5d5 100644
@@ -25,7 +25,6 @@ ENV PACKAGES \
     libasan \
     libattr-devel \
     libblockdev-mpath-devel \
-    libcap-devel \
     libcap-ng-devel \
     libcurl-devel \
     libfdt-devel \
tests/docker/dockerfiles/ubuntu.docker +0 -1
index f486492224..ecea155646 100644
@@ -23,7 +23,6 @@ ENV PACKAGES flex bison \
     libbrlapi-dev \
     libbz2-dev \
     libcacard-dev \
-    libcap-dev \
     libcap-ng-dev \
     libcurl4-gnutls-dev \
     libdrm-dev \
tests/docker/dockerfiles/ubuntu1804.docker +0 -1
index 3cc4f492c4..32a607471a 100644
@@ -12,7 +12,6 @@ ENV PACKAGES flex bison \
     libbrlapi-dev \
     libbz2-dev \
     libcacard-dev \
-    libcap-dev \
     libcap-ng-dev \
     libcurl4-gnutls-dev \
     libdrm-dev \
Signature · 1 line
2.21.0
#1 lore raw
Quoted 4 lines · On Fri, 29 Nov 2019 16:08:01 +0100 Paolo Bonzini <[email protected]> wrote:

Libcap was dropped from virtio-9p, so remove it from the dockerfiles as well.

---

Similarly to what was discussed in these threads:

[email protected]

[email protected]

I'm ok to take this one in my tree as well if I get an ack from Alex or Fam.

Quoted 41 lines
 tests/docker/dockerfiles/fedora.docker     | 1 -
 tests/docker/dockerfiles/ubuntu.docker     | 1 -
 tests/docker/dockerfiles/ubuntu1804.docker | 1 -
 3 files changed, 3 deletions(-)
tests/docker/dockerfiles/fedora.docker +0 -1
index 4ddc7dd112..47732fc5d5 100644
@@ -25,7 +25,6 @@ ENV PACKAGES \
     libasan \
     libattr-devel \
     libblockdev-mpath-devel \
-    libcap-devel \
     libcap-ng-devel \
     libcurl-devel \
     libfdt-devel \
tests/docker/dockerfiles/ubuntu.docker +0 -1
index f486492224..ecea155646 100644
@@ -23,7 +23,6 @@ ENV PACKAGES flex bison \
     libbrlapi-dev \
     libbz2-dev \
     libcacard-dev \
-    libcap-dev \
     libcap-ng-dev \
     libcurl4-gnutls-dev \
     libdrm-dev \
tests/docker/dockerfiles/ubuntu1804.docker +0 -1
index 3cc4f492c4..32a607471a 100644
@@ -12,7 +12,6 @@ ENV PACKAGES flex bison \
     libbrlapi-dev \
     libbz2-dev \
     libcacard-dev \
-    libcap-dev \
     libcap-ng-dev \
     libcurl4-gnutls-dev \
     libdrm-dev \
#2 lore raw
Quoted 8 lines · On Mon, 2 Dec 2019 11:49:58 +0100 Greg Kurz <[email protected]> wrote:
Quoted 4 lines · On Fri, 29 Nov 2019 16:08:01 +0100 Paolo Bonzini <[email protected]> wrote:

Libcap was dropped from virtio-9p, so remove it from the dockerfiles as well.

---

Quoted 9 lines

Similarly to what was discussed in these threads:

[email protected]

[email protected]

I'm ok to take this one in my tree as well if I get an ack from Alex or Fam.

Oops, I didn't realize my mail client still had Fam's previous address...

Quoted 43 lines
Quoted 41 lines
 tests/docker/dockerfiles/fedora.docker     | 1 -
 tests/docker/dockerfiles/ubuntu.docker     | 1 -
 tests/docker/dockerfiles/ubuntu1804.docker | 1 -
 3 files changed, 3 deletions(-)
tests/docker/dockerfiles/fedora.docker +0 -1
index 4ddc7dd112..47732fc5d5 100644
@@ -25,7 +25,6 @@ ENV PACKAGES \
     libasan \
     libattr-devel \
     libblockdev-mpath-devel \
-    libcap-devel \
     libcap-ng-devel \
     libcurl-devel \
     libfdt-devel \
tests/docker/dockerfiles/ubuntu.docker +0 -1
index f486492224..ecea155646 100644
@@ -23,7 +23,6 @@ ENV PACKAGES flex bison \
     libbrlapi-dev \
     libbz2-dev \
     libcacard-dev \
-    libcap-dev \
     libcap-ng-dev \
     libcurl4-gnutls-dev \
     libdrm-dev \
tests/docker/dockerfiles/ubuntu1804.docker +0 -1
index 3cc4f492c4..32a607471a 100644
@@ -12,7 +12,6 @@ ENV PACKAGES flex bison \
     libbrlapi-dev \
     libbz2-dev \
     libcacard-dev \
-    libcap-dev \
     libcap-ng-dev \
     libcurl4-gnutls-dev \
     libdrm-dev \
Acked-by
#3 lore raw
In reply to Greg Kurz
Quoted 8 lines · Greg Kurz
Quoted 4 lines · On Fri, 29 Nov 2019 16:08:01 +0100 Paolo Bonzini <[email protected]> wrote:

Libcap was dropped from virtio-9p, so remove it from the dockerfiles as well.

---

Quoted 8 lines

Similarly to what was discussed in these threads:

[email protected]

[email protected]

I'm ok to take this one in my tree as well if I get an ack from Alex or Fam.

Quoted 42 lines
Quoted 42 lines
 tests/docker/dockerfiles/fedora.docker     | 1 -
 tests/docker/dockerfiles/ubuntu.docker     | 1 -
 tests/docker/dockerfiles/ubuntu1804.docker | 1 -
 3 files changed, 3 deletions(-)
tests/docker/dockerfiles/fedora.docker +0 -1
index 4ddc7dd112..47732fc5d5 100644
@@ -25,7 +25,6 @@ ENV PACKAGES \
     libasan \
     libattr-devel \
     libblockdev-mpath-devel \
-    libcap-devel \
     libcap-ng-devel \
     libcurl-devel \
     libfdt-devel \
tests/docker/dockerfiles/ubuntu.docker +0 -1
index f486492224..ecea155646 100644
@@ -23,7 +23,6 @@ ENV PACKAGES flex bison \
     libbrlapi-dev \
     libbz2-dev \
     libcacard-dev \
-    libcap-dev \
     libcap-ng-dev \
     libcurl4-gnutls-dev \
     libdrm-dev \
tests/docker/dockerfiles/ubuntu1804.docker +0 -1
index 3cc4f492c4..32a607471a 100644
@@ -12,7 +12,6 @@ ENV PACKAGES flex bison \
     libbrlapi-dev \
     libbz2-dev \
     libcacard-dev \
-    libcap-dev \
     libcap-ng-dev \
     libcurl4-gnutls-dev \
     libdrm-dev \
Signature · 1 line
Alex Bennée