Skip to contentSkip to conversation

package/gcc: backport fix for xtensa PR 90922

PATCH New Max Filippov 3 participants 3 messages Sep 23, 2019 – Oct 1, 2019

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 package/gcc: backport fix for xtensa PR 90922

Stack pointer adjustment code in xtensa call0 ABI prologue missed a case of no callee-saved registers and a stack frame size bigger than 128 bytes. Handle that case.

---
Changes v1->v2:
- fix subject line

 ...2-xtensa-backport-fix-for-PR-target-90922.patch | 43 ++++++++++++++++++++++
 ...1-xtensa-backport-fix-for-PR-target-90922.patch | 43 ++++++++++++++++++++++
 ...1-xtensa-backport-fix-for-PR-target-90922.patch | 43 ++++++++++++++++++++++
 3 files changed, 129 insertions(+)
 create mode 100644 package/gcc/7.4.0/1002-xtensa-backport-fix-for-PR-target-90922.patch
 create mode 100644 package/gcc/8.3.0/0001-xtensa-backport-fix-for-PR-target-90922.patch
 create mode 100644 package/gcc/9.2.0/0001-xtensa-backport-fix-for-PR-target-90922.patch
package/gcc/7.4.0/1002-xtensa-backport-fix-for-PR-target-90922.patch new file +43 -0
new file mode 100644
index 000000000000..38e0309e5c5d
@@ -0,0 +1,43 @@
+From a592242578e573778241cae6d3928c064dcdfda4 Mon Sep 17 00:00:00 2001
+From: jcmvbkbc <jcmvbkbc@138bc75d-0d04-0410-961f-82ee72b054a4>
+Date: Tue, 18 Jun 2019 22:19:12 +0000
+Subject: [PATCH] xtensa: fix for PR target/90922
+
+Stack pointer adjustment code in prologue missed a case of no
+callee-saved registers and a stack frame size bigger than 128 bytes.
+Handle that case.
+
+This fixes the following gcc tests with call0 ABI:
+  gcc.c-torture/execute/stdarg-2.c
+  gcc.dg/torture/pr55882.c
+  gcc.dg/torture/pr57569.c
+
+gcc/
+2019-06-18  Max Filippov  <[email protected]>
+
+	* config/xtensa/xtensa.c (xtensa_expand_prologue): Add stack
+	pointer adjustment for the case of no callee-saved registers and
+	stack frame bigger than 128 bytes.
+
+Signed-off-by: Max Filippov <[email protected]>
+---
+ gcc/config/xtensa/xtensa.c | 3 ++-
+ 1 file changed, 2 insertions(+), 1 deletion(-)
+
+diff --git a/gcc/config/xtensa/xtensa.c b/gcc/config/xtensa/xtensa.c
+index 19bd616d67f6..ee5612441e25 100644
+--- a/gcc/config/xtensa/xtensa.c
++++ b/gcc/config/xtensa/xtensa.c
+@@ -2802,7 +2802,8 @@ xtensa_expand_prologue (void)
+ 			    gen_rtx_SET (mem, reg));
+ 	    }
+ 	}
+-      if (total_size > 1024)
++      if (total_size > 1024
++	  || (!callee_save_size && total_size > 128))
+ 	{
+ 	  rtx tmp_reg = gen_rtx_REG (Pmode, A9_REG);
+ 	  emit_move_insn (tmp_reg, GEN_INT (total_size -
+-- 
+2.11.0
+
package/gcc/8.3.0/0001-xtensa-backport-fix-for-PR-target-90922.patch new file +43 -0

43 lines not on this page · raw message

package/gcc/9.2.0/0001-xtensa-backport-fix-for-PR-target-90922.patch new file +43 -0

43 lines not on this page · raw message

Signature · 1 line
2.11.0
#1 lore raw

PATCH v2 1/1 package/gcc: backport fix for xtensa PR 90922

Quoted 8 lines · On Mon, 23 Sep 2019 13:47:03 -0700 Max Filippov <[email protected]> wrote:

Stack pointer adjustment code in xtensa call0 ABI prologue missed a case of no callee-saved registers and a stack frame size bigger than 128 bytes. Handle that case.

---
Changes v1->v2:
- fix subject line

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH v2 1/1 package/gcc: backport fix for xtensa PR 90922

In reply to Max Filippov
Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Max" == Max Filippov <[email protected]> writes:

Stack pointer adjustment code in xtensa call0 ABI prologue missed a case of no callee-saved registers and a stack frame size bigger than 128 bytes. Handle that case.

---
Changes v1->v2:
- fix subject line

Committed to 2019.02.x, 2019.05.x and 2019.08.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard