Skip to contentSkip to conversation

package/openocd: add missing host-pkgconf dependency

PATCH New Thomas Petazzoni 2 participants 3 messages Nov 15, 2018 – Nov 26, 2018

lore
Share & tools
lore

Thomas Petazzoni

author
#0 lore raw

PATCH 1/1 package/openocd: add missing host-pkgconf dependency

The configure.ac script uses PKG_CHECK_MODULES(), and we autoreconf the package, so host-pkgconf should be listed in the dependencies.

This issue is seen either with per-package folders, or by doing a clean build with just "make openocd":

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

openocd 0.10.0 Configuring
openocd 0.10.0 Autoreconfiguring

[...]
configure.ac:12: error: possibly undefined macro: AC_MSG_WARN
If this token and others are legitimate, please use m4_pattern_allow. See the Autoconf documentation.
configure.ac:201: error: possibly undefined macro: AC_DEFINE configure.ac:582: error: possibly undefined macro: AC_MSG_NOTICE

Even if the message seems unrelated, it's really the lack of pkg.m4 from host-pkgconf that causes the issue.

Signed-off-by Thomas Petazzoni <[email protected]>
---
 package/openocd/openocd.mk | 1 +
 1 file changed, 1 insertion(+)
package/openocd/openocd.mk +1 -0
index 548d8b81a0..ca13d99366 100644
@@ -31,6 +31,7 @@ OPENOCD_CONF_OPTS = \
 # the dependencies they need.
 
 OPENOCD_DEPENDENCIES = \
+	host-pkgconf \
 	$(if $(BR2_PACKAGE_LIBFTDI1),libftdi1) \
 	$(if $(BR2_PACKAGE_LIBUSB),libusb) \
 	$(if $(BR2_PACKAGE_LIBUSB_COMPAT),libusb-compat) \
Signature · 1 line
2.19.1
#1 lore raw

PATCH 1/1 package/openocd: add missing host-pkgconf dependency

Quoted 17 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

The configure.ac script uses PKG_CHECK_MODULES(), and we autoreconf the package, so host-pkgconf should be listed in the dependencies.

This issue is seen either with per-package folders, or by doing a clean build with just "make openocd":

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

openocd 0.10.0 Configuring
openocd 0.10.0 Autoreconfiguring

[...]
configure.ac:12: error: possibly undefined macro: AC_MSG_WARN
If this token and others are legitimate, please use m4_pattern_allow. See the Autoconf documentation.
configure.ac:201: error: possibly undefined macro: AC_DEFINE configure.ac:582: error: possibly undefined macro: AC_MSG_NOTICE

Quoted 4 lines

Even if the message seems unrelated, it's really the lack of pkg.m4 from host-pkgconf that causes the issue.

Signed-off-by Thomas Petazzoni <[email protected]>

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH 1/1 package/openocd: add missing host-pkgconf dependency

In reply to Thomas Petazzoni
Quoted 17 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

The configure.ac script uses PKG_CHECK_MODULES(), and we autoreconf the package, so host-pkgconf should be listed in the dependencies.

This issue is seen either with per-package folders, or by doing a clean build with just "make openocd":

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

openocd 0.10.0 Configuring
openocd 0.10.0 Autoreconfiguring

[...]
configure.ac:12: error: possibly undefined macro: AC_MSG_WARN
If this token and others are legitimate, please use m4_pattern_allow. See the Autoconf documentation.
configure.ac:201: error: possibly undefined macro: AC_DEFINE configure.ac:582: error: possibly undefined macro: AC_MSG_NOTICE

Quoted 4 lines

Even if the message seems unrelated, it's really the lack of pkg.m4 from host-pkgconf that causes the issue.

Signed-off-by Thomas Petazzoni <[email protected]>

Committed to 2018.02.x and 2018.08.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard