USB: inode.c: fix unbalanced spin_lock in ep0_write
PATCH v2 1/1 USB: inode.c: fix unbalanced spin_lock in ep0_write
Fix bad unlock balance: ep0_write enter with the locks locked from inode.c:1769, hence it must exit with spinlock held to avoid double unlock in dev_config.
--- drivers/usb/gadget/legacy/inode.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/usb/gadget/legacy/inode.c +1 -2
@@ -1137,10 +1137,9 @@ ep0_write (struct file *fd, const char __user *buf, size_t len, loff_t *ptr) dev->gadget->ep0, dev->req, GFP_KERNEL); } +spin_lock_irq (&dev->lock);if (retval <0 ) { -spin_lock_irq (&dev->lock);clean_req (dev->gadget->ep0, dev->req); -spin_unlock_irq (&dev->lock); }else retval = len;
Signature · 1 line
1.8.1.2
Hi,
Quoted 5 lines · David Eccher
Fix bad unlock balance:
ep0_writeenter with the locks locked from inode.c:1769, hence it must exit with spinlock held to avoid double unlock indev_config.Signed-off-by David Eccher <[email protected]>
which commit is this fixing ? Do we need this backported to stable kernels ?
Signature · 1 line
balbi
Quoted 11 lines · Felipe Balbi
Hi,
Quoted 5 lines · David Eccher
Fix bad unlock balance:
ep0_writeenter with the locks locked from inode.c:1769, hence it must exit with spinlock held to avoid double unlock indev_config.Signed-off-by David Eccher <[email protected]>which commit is this fixing ? Do we need this backported to stable kernels ?
oh, this has been like this since before git came to be. Nevermind.
Signature · 1 line
balbi