legacy: update the BR2_PREFER_STATIC_LIB option

PATCH New Samuel Martin 2 participants 2 messages Dec 14, 2014

Share & tools

Samuel Martin

author

2014-12-14 16:24 UTC #0 lore raw

PATCH v2 1/1 legacy: update the BR2_PREFER_STATIC_LIB option

Since the refactoring of the type of libraries in the target filesystem, these options belong to a choice, and the default is "shared only".

The former option BR2_PREFER_STATIC_LIB has been moved in the legacy menu, and only selects the BR2_STATIC_LIBS ("static only") option. However, because BR2_STATIC_LIBS belongs to a choice, when BR2_PREFER_STATIC_LIB is selected, it does not affect the choice. So, existing Buildroot configurations, which have BR2_PREFER_STATIC_LIB set, will silently end with BR2_SHARED_LIBS ("shared only") enabled.

So, the backward compatibility is not kept.

Besides, the legacy BR2_PREFER_STATIC_LIB option does not select BR2_LEGACY, so the user is not notified of this legacy option, and the build silently continues with some undesired changes.

This patch removes the inefficient BR2_STATIC_LIBS selection, correctly selects the BR2_LEGACY option and extend the help message so the user can easily know how to update his/her Buildroot configuration.

Signed-off-by Samuel Martin <[email protected]>

Cc "Yann E. MORIN" <[email protected]>

Cc Thomas Petazzoni <[email protected]>

Acked-by "Yann E. MORIN" <[email protected]>

---
changes v1->v2:
- fix typos in commit log
- update A/R/T tags

---
 Config.in.legacy | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Config.in.legacy +4 -1

index 09c025c..a969662 100644
@@ -104,13 +104,16 @@ comment "Legacy options removed in 2015.02"
 
 config BR2_PREFER_STATIC_LIB
 	bool "static library option renamed"
-	select BR2_STATIC_LIBS
+	select BR2_LEGACY
 	help
 	  The BR2_PREFER_STATIC_LIB was renamed to BR2_STATIC_LIBS. It
 	  highlights the fact that the option no longer "prefers"
 	  static libraries, but "enforces" static libraries (i.e
 	  shared libraries are completely unused).
 
+	  Take care of updating the type of libraries you want under the
+	  "Build options" menu.
+
 comment "Legacy options removed in 2014.11"
 
 config BR2_x86_generic

Signature · 1 line

2.1.3

Peter Korsgaard

2014-12-14 16:50 UTC #1 lore raw

PATCH v2 1/1 legacy: update the BR2_PREFER_STATIC_LIB option

Quoted 27 lines

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Samuel" == Samuel Martin <[email protected]> writes:
Since the refactoring of the type of libraries in the target filesystem, these options belong to a choice, and the default is "shared only".
The former option BR2_PREFER_STATIC_LIB has been moved in the legacy menu, and only selects the BR2_STATIC_LIBS ("static only") option. However, because BR2_STATIC_LIBS belongs to a choice, when BR2_PREFER_STATIC_LIB is selected, it does not affect the choice. So, existing Buildroot configurations, which have BR2_PREFER_STATIC_LIB set, will silently end with BR2_SHARED_LIBS ("shared only") enabled.
So, the backward compatibility is not kept.
Besides, the legacy BR2_PREFER_STATIC_LIB option does not select BR2_LEGACY, so the user is not notified of this legacy option, and the build silently continues with some undesired changes.
This patch removes the inefficient BR2_STATIC_LIBS selection, correctly selects the BR2_LEGACY option and extend the help message so the user can easily know how to update his/her Buildroot configuration.
Signed-off-by Samuel Martin <[email protected]>
Cc "Yann E. MORIN" <[email protected]>
Cc Thomas Petazzoni <[email protected]>
Acked-by "Yann E. MORIN" <[email protected]>

Quoted 4 lines

---
changes v1->v2:
- fix typos in commit log
- update A/R/T tags

Committed, thanks.

Signature · 1 line

Bye, Peter Korsgaard