Skip to contentSkip to conversation

video: mxsfb: Add missing break

PATCH New Marek Vasut 2 participants 3 messages Oct 1, 2013 – Oct 3, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 video: mxsfb: Add missing break

Add missing break into the restore function.

Upstream commit: 6d0bb818041a02be682abadb3ba35ff608f7d60a

Cc Fabio Estevam <[email protected]>
Cc Shawn Guo <[email protected]>
Cc stable at vger.kernel.org
---
 drivers/video/mxsfb.c | 1 +
 1 file changed, 1 insertion(+)
drivers/video/mxsfb.c +1 -0
index 21223d4..75c5b4e 100644
@@ -647,6 +647,7 @@ static int mxsfb_restore_mode(struct mxsfb_info *host)
 		break;
 	case 3:
 		bits_per_pixel = 32;
+		break;
 	case 1:
 	default:
 		return -EINVAL;
Signature · 1 line
1.8.4.rc3
#1 lore raw

PATCH 1/1 video: mxsfb: Add missing break

Quoted 18 lines · Marek Vasut

Add missing break into the restore function.

Upstream commit: 6d0bb818041a02be682abadb3ba35ff608f7d60a

Cc Fabio Estevam <[email protected]>
Cc Shawn Guo <[email protected]>
Cc stable at vger.kernel.org
---
 drivers/video/mxsfb.c | 1 +
 1 file changed, 1 insertion(+)
drivers/video/mxsfb.c +0 -0
index 21223d4..75c5b4e 100644

drivers/video/mxsfb.c static int mxsfb_restore_mode(struct mxsfb_info *host) · line 653

Quoted 7 lines
drivers/video/mxsfb.c +1 -0
@@ -647,6 +647,7 @@ static int mxsfb_restore_mode(struct mxsfb_info *host)
 		break;
 	case 3:
 		bits_per_pixel = 32;
+		break;
 	case 1:
 	default:
 		return -EINVAL;

Thanks, I believe this fix is applicable to all the stable kernels. I'm queuing it for the 3.5 kernel.

Cheers,

Signature · 1 line
Luis
#2 lore raw

PATCH 1/1 video: mxsfb: Add missing break

Dear Luis Henriques,

Quoted 29 lines
Quoted 28 lines · Marek Vasut

Add missing break into the restore function.

Upstream commit: 6d0bb818041a02be682abadb3ba35ff608f7d60a

Cc Fabio Estevam <[email protected]>
Cc Shawn Guo <[email protected]>
Cc stable at vger.kernel.org

---

 drivers/video/mxsfb.c | 1 +
 1 file changed, 1 insertion(+)
drivers/video/mxsfb.c +1 -0
index 21223d4..75c5b4e 100644
@@ -647,6 +647,7 @@ static int mxsfb_restore_mode(struct mxsfb_info
 *host)
 
 		break;
 
 	case 3:
 		bits_per_pixel = 32;
 
+		break;
Quoted 7 lines

drivers/video/mxsfb.c static int mxsfb_restore_mode(struct mxsfb_info *host) · line 653

Quoted 4 lines
drivers/video/mxsfb.c +0 -0
 	case 1:
 
 	default:
 		return -EINVAL;

Thanks, I believe this fix is applicable to all the stable kernels. I'm queuing it for the 3.5 kernel.

Thanks!

btw. it'd be nice if you could push the kernel.ubuntu.com admins to fix their git server ( https://bugs.launchpad.net/ubuntu/+source/git/+bug/1228148 ) ;-)

Best regards,
Marek Vasut