Skip to contentSkip to conversation

ARM: OMAP2+: omap2plus_defconfig: enable OMAP DMA engine support

PATCH New Javier Martinez Canillas 3 participants 4 messages Jul 15, 2012 – Jul 19, 2012

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: OMAP2+: omap2plus_defconfig: enable OMAP DMA engine support

commit 13f30fc893e4610f67dd7a8b0b67aec02eac1775

Author: Russell King <[email protected]>
Date:   Sat Apr 21 22:41:10 2012 +0100

mmc: omap: remove private DMA API implementation

removed the private DMA API implementation from the OMAP mmc host to make it use exclusively the DMA engine API.

Unfortunately the omap2plus_defconfig doesn't enable this feature leading to the following error on an IGEPv2 Rev.C (and probably on most boards with MMC support):

[    2.199981] omap_hsmmc omap_hsmmc.1: unable to obtain RX DMA engine channel 48
[    2.215087] omap_hsmmc omap_hsmmc.0: unable to obtain RX DMA engine channel 62
---
 arch/arm/configs/omap2plus_defconfig |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
arch/arm/configs/omap2plus_defconfig +2 -0
index b152de7..e58edc3 100644
@@ -193,6 +193,8 @@ CONFIG_MMC_OMAP_HS=y
 CONFIG_RTC_CLASS=y
 CONFIG_RTC_DRV_TWL92330=y
 CONFIG_RTC_DRV_TWL4030=y
+CONFIG_DMADEVICES=y
+CONFIG_DMA_OMAP=y
 CONFIG_EXT2_FS=y
 CONFIG_EXT3_FS=y
 # CONFIG_EXT3_FS_XATTR is not set
Signature · 1 line
1.7.7.6
#1 lore raw

PATCH 1/1 ARM: OMAP2+: omap2plus_defconfig: enable OMAP DMA engine support

Quoted 4 lines · Javier Martinez Canillas

commit 13f30fc893e4610f67dd7a8b0b67aec02eac1775

Author: Russell King <[email protected]>
Date:   Sat Apr 21 22:41:10 2012 +0100
Quoted 8 lines

mmc: omap: remove private DMA API implementation

removed the private DMA API implementation from the OMAP mmc host to make it use exclusively the DMA engine API.

Unfortunately the omap2plus_defconfig doesn't enable this feature leading to the following error on an IGEPv2 Rev.C (and probably on most boards with MMC support):

Personally, I'd rather see this fixed by having the drivers that depend on DMA engine 'select DMADEVICES'. That way, any defconfig will work correctly instead of just omap2plus_defconfig.

Kevin

Quoted 21 lines
[    2.199981] omap_hsmmc omap_hsmmc.1: unable to obtain RX DMA engine channel 48
[    2.215087] omap_hsmmc omap_hsmmc.0: unable to obtain RX DMA engine channel 62
---
 arch/arm/configs/omap2plus_defconfig |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
arch/arm/configs/omap2plus_defconfig +2 -0
index b152de7..e58edc3 100644
@@ -193,6 +193,8 @@ CONFIG_MMC_OMAP_HS=y
 CONFIG_RTC_CLASS=y
 CONFIG_RTC_DRV_TWL92330=y
 CONFIG_RTC_DRV_TWL4030=y
+CONFIG_DMADEVICES=y
+CONFIG_DMA_OMAP=y
 CONFIG_EXT2_FS=y
 CONFIG_EXT3_FS=y
 # CONFIG_EXT3_FS_XATTR is not set
#2 lore raw

PATCH 1/1 ARM: OMAP2+: omap2plus_defconfig: enable OMAP DMA engine support

Quoted 15 lines · Kevin Hilman
Quoted 4 lines · Javier Martinez Canillas

commit 13f30fc893e4610f67dd7a8b0b67aec02eac1775

Author: Russell King <[email protected]>
Date:   Sat Apr 21 22:41:10 2012 +0100
Quoted 8 lines

mmc: omap: remove private DMA API implementation

removed the private DMA API implementation from the OMAP mmc host to make it use exclusively the DMA engine API.

Unfortunately the omap2plus_defconfig doesn't enable this feature leading to the following error on an IGEPv2 Rev.C (and probably on most boards with MMC support):

Quoted 6 lines

Personally, I'd rather see this fixed by having the drivers that depend on DMA engine 'select DMADEVICES'. That way, any defconfig will work correctly instead of just omap2plus_defconfig.

Kevin

Hi Kevin,

Thanks a lot for your feedback. I'll do what you suggest and send a v2 of the patch.

Best regards,
Javier

maintainer
#3 lore raw

PATCH 1/1 ARM: OMAP2+: omap2plus_defconfig: enable OMAP DMA engine support

Quoted 20 lines · Javier Martinez Canillas
Quoted 19 lines · Kevin Hilman
Quoted 4 lines · Javier Martinez Canillas

commit 13f30fc893e4610f67dd7a8b0b67aec02eac1775

Author: Russell King <[email protected]>
Date:   Sat Apr 21 22:41:10 2012 +0100
Quoted 8 lines

mmc: omap: remove private DMA API implementation

removed the private DMA API implementation from the OMAP mmc host to make it use exclusively the DMA engine API.

Unfortunately the omap2plus_defconfig doesn't enable this feature leading to the following error on an IGEPv2 Rev.C (and probably on most boards with MMC support):

Personally, I'd rather see this fixed by having the drivers that depend on DMA engine 'select DMADEVICES'. That way, any defconfig will work correctly instead of just omap2plus_defconfig.

Quoted 7 lines
Quoted 2 lines

Kevin

Hi Kevin,

Thanks a lot for your feedback. I'll do what you suggest and send a v2 of the patch.

I'd rather see the drivers fixed to work with and without DMA as the channels can run out. Also forcing the select is not good for distro kernels.

I'll apply this fix into l-o master branch while we're discussing the issue.

Regards,

Tony